You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "bowenliang123 (via GitHub)" <gi...@apache.org> on 2023/02/10 01:15:11 UTC
[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4295: introduce super-linter action for multiple linters
bowenliang123 opened a new pull request, #4295:
URL: https://github.com/apache/kyuubi/pull/4295
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
- introduce `action/super-linter` with multiple linters, (https://github.com/marketplace/actions/super-linter)
- using the slim version of image `github/super-linter/slim`
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4295: Introduce `super-linter` action for linting JSON, XML, ENV files and bash_exec
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4295:
URL: https://github.com/apache/kyuubi/pull/4295#issuecomment-1471585843
It's ready for review. Have a check when you have time.
cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4295: introduce super-linter action for multiple linters
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4295:
URL: https://github.com/apache/kyuubi/pull/4295#issuecomment-1467402913
The licence header in JSON files like `kyuubi-server/web-ui/tsconfig.json`, as comments are not supported originally in JSON. As in Spark, [eslint.json](https://github.com/apache/spark/blob/master/dev/eslint.json) is also remained without licence header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] codecov-commenter commented on pull request #4295: Introduce `super-linter` action for linting JSON, XML, ENV files and bash_exec
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4295:
URL: https://github.com/apache/kyuubi/pull/4295#issuecomment-1471435144
## [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4295?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4295](https://codecov.io/gh/apache/kyuubi/pull/4295?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (43787e2) into [master](https://codecov.io/gh/apache/kyuubi/commit/8267108e7f4ff282aa0f56639a81a1bdf992ff6d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8267108) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 43787e2 differs from pull request most recent head 497bf80. Consider uploading reports for the commit 497bf80 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4295 +/- ##
============================================
- Coverage 53.37% 53.34% -0.04%
Complexity 13 13
============================================
Files 571 571
Lines 31294 31294
Branches 4219 4219
============================================
- Hits 16703 16693 -10
- Misses 13012 13020 +8
- Partials 1579 1581 +2
```
[see 6 files with indirect coverage changes](https://codecov.io/gh/apache/kyuubi/pull/4295/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4295: Introduce super-linter action for linting JSON, XML, ENV files and bash_exec
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4295:
URL: https://github.com/apache/kyuubi/pull/4295#issuecomment-1467970784
Actually, the extended JSON format supports comments syntax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4295: introduce super-linter action for multiple linters
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4295:
URL: https://github.com/apache/kyuubi/pull/4295#issuecomment-1464949735
Fix https://github.com/apache/kyuubi/actions/runs/4393204237/jobs/7693453883#step:4:29
```
2023-03-11 16:40:51 [WARN] Warnings found in [bash-exec] linter!
2023-03-11 16:40:51 [WARN] Error: File:[/github/workspace/tools/spark-block-cleaner/kubernetes/docker/entrypoint.sh] is not executable
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4295: introduce super-linter action for multiple linters
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4295:
URL: https://github.com/apache/kyuubi/pull/4295#issuecomment-1467401056
The follow-up to do after this PR:
- apply linting for shell scripts with `shellcheck` tool.
- until `super-linter` merged this PR to support config `severity`. The `super-linter` is currently showing too many verbose messages of INFO level which causes errors and failures.
- this PR (https://github.com/apache/kyuubi/pull/4500) helps fix the auto-fixable violation in shell scripts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4295: Introduce super-linter action for linting JSON, XML, ENV files and bash_exec
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4295:
URL: https://github.com/apache/kyuubi/pull/4295#issuecomment-1468038463
> Actually, the extended JSON format supports comments syntax.
we use JSON file in original style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 closed pull request #4295: Introduce `super-linter` action for linting JSON, XML, ENV files and bash_exec
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 closed pull request #4295: Introduce `super-linter` action for linting JSON, XML, ENV files and bash_exec
URL: https://github.com/apache/kyuubi/pull/4295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4295: Introduce `super-linter` action for linting JSON, XML, ENV files and bash_exec
Posted by "bowenliang123 (via GitHub)" <gi...@apache.org>.
bowenliang123 commented on PR #4295:
URL: https://github.com/apache/kyuubi/pull/4295#issuecomment-1474858185
Thanks, merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org