You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "shahar1 (via GitHub)" <gi...@apache.org> on 2025/01/10 18:43:30 UTC
[PR] Upgrade sphinx and related dependencies [airflow]
shahar1 opened a new pull request, #45563:
URL: https://github.com/apache/airflow/pull/45563
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
This PR update the following dependencies:
- `sphinx` to v7+ (there's already v8, but it is supported only for Python 3.10)
- `docutils` to v0.21+ (haven't encountered any `<section>` tags as mentioned in the deleted inline comment)
- `sphinx-autoapi` to v3+ and `astroid` to v3+ (possible now that `sphinx` is v7+)
- `sphinxcontrib-serializinghtml` to v1.1.5+ (pinning it causes dependency conflicts)
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #45563:
URL: https://github.com/apache/airflow/pull/45563#discussion_r1912251165
##########
Dockerfile.ci:
##########
@@ -1355,6 +1355,402 @@ ENV PATH="/files/bin/:/opt/airflow/scripts/in_container/bin/:${PATH}" \
# so we can go back to the default link mode being hardlink.
Review Comment:
This file should be removed before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #45563:
URL: https://github.com/apache/airflow/pull/45563#issuecomment-2585393127
#protm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #45563:
URL: https://github.com/apache/airflow/pull/45563#issuecomment-2584045630
one more thing - last time when we tried to upgrade sphinx and docutils, the documentation looked ....weird .... lots of extra whitespace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #45563:
URL: https://github.com/apache/airflow/pull/45563#issuecomment-2585187198
Apparently it is a **really** tough task, here are some insights:
- A requirement for upgrading Sphinx to v7 is to merge https://github.com/apache/airflow-site/pull/1103 and create a new version for `sphinx_airflow_theme` (`0.1.0`). For now, I made a workaround by injecting the contents of the file that was modified via `Dockerfile.ci` (struggled with mounting it - created an [issue](https://github.com/apache/airflow/issues/45576) for anyone who wants to tackle it in the future).
- When running only the build docs workflow, locally and on GitHub Actions, using `breeze build-docs apache-airflow docker-stack --docs-only --clean-build`, the build succeeds without any errors (see [GitHub Action workflow](https://github.com/apache/airflow/actions/runs/12722412749/job/35466510483)). When running the docs server locally, the extra spaces issue indeed persists - we need to find out how to modify the related CSS (no success with it so far).
- When running only the spellchecks workflow, locally and on GitHub Actions, using `breeze build-docs apache-airflow docker-stack --clean-build` (see raw [logs](https://productionresultssa15.blob.core.windows.net/actions-results/150f2642-909d-4db9-9c5d-8fbcbdac4d97/workflow-job-run-d861e44f-2bbb-5cfa-a1f8-37f87cf3d990/logs/job/job-logs.txt?rsct=text%2Fplain&se=2025-01-11T08%3A50%3A51Z&sig=VqIwiRSbgJv4DXcHviF0uu1tQNPJiaXCgdLlVnQ7eOM%3D&ske=2025-01-11T17%3A27%3A16Z&skoid=ca7593d4-ee42-46cd-af88-8b886a2f84eb&sks=b&skt=2025-01-11T05%3A27%3A16Z&sktid=398a6654-997b-47e9-b12b-9515b896b4de&skv=2024-11-04&sp=r&spr=https&sr=b&st=2025-01-11T08%3A40%3A46Z&sv=2024-11-04) - BIG FILE warning) - we get a lot of weird errors. If you take a look at the logs, it often fails when parsing from `/opt/airflow/providers/src/airflow/providers/amazon/aws/hooks/ssm.py::SsmHook:: get_parameter_value`. If we figure it out, we will get
- When running the workflow for building docs and spelling **altogether** (`breeze build-docs apache-airflow docker-stack --clean-build`), the build fails due to a large number of implicit errors (which might be related to the failure of the spelling checks?).
- The [MyPy workflow](https://github.com/apache/airflow/actions/runs/12722412749/job/35466520027), but it doesn't seem too bad - in the worst case we just ignore it.
I'll be happy for some help in solving some of the riddles above, it will gets us closer to upgrading to Sphinx 7 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "kaxil (via GitHub)" <gi...@apache.org>.
kaxil commented on PR #45563:
URL: https://github.com/apache/airflow/pull/45563#issuecomment-2585711499
Merge conflicts on `hatch_build.py` @shahar1 and then hopefully we are good 🤞
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #45563:
URL: https://github.com/apache/airflow/pull/45563#discussion_r1912251701
##########
hatch_build.py:
##########
@@ -148,24 +148,18 @@
DOC_EXTRAS: dict[str, list[str]] = {
"doc": [
- "astroid>=2.12.3,<3.0",
+ "astroid>=3",
"checksumdir>=1.2.0",
"click>=8.1.8",
- # Docutils 0.17.0 converts generated <div class="section"> into <section> and breaks our doc formatting
- # By adding a lot of whitespace separation. This limit can be lifted when we update our doc to handle
- # <section> tags for sections
- "docutils<0.17,>=0.16",
+ "docutils>=0.21",
"sphinx-airflow-theme>=0.0.12",
Review Comment:
Before merging, we should create a new version for `sphinx-airflow-theme` (0.1.0) after merging https://github.com/apache/airflow-site/pull/1103
Edit: maybe even a new package, because past versions will get broken as we don't pin `sphinx-airflow-theme`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #45563:
URL: https://github.com/apache/airflow/pull/45563#issuecomment-2585751520
LGTM ! 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉 🎉
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #45563:
URL: https://github.com/apache/airflow/pull/45563#issuecomment-2583607553
Drafting, weirdly on `v2-10-test` it worked fine but here there are errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #45563:
URL: https://github.com/apache/airflow/pull/45563#discussion_r1912424949
##########
hatch_build.py:
##########
@@ -148,24 +148,18 @@
DOC_EXTRAS: dict[str, list[str]] = {
"doc": [
- "astroid>=2.12.3,<3.0",
+ "astroid>=3",
"checksumdir>=1.2.0",
"click>=8.1.8",
- # Docutils 0.17.0 converts generated <div class="section"> into <section> and breaks our doc formatting
- # By adding a lot of whitespace separation. This limit can be lifted when we update our doc to handle
- # <section> tags for sections
- "docutils<0.17,>=0.16",
+ "docutils>=0.21",
"sphinx-airflow-theme>=0.0.12",
Review Comment:
Cool :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on PR #45563:
URL: https://github.com/apache/airflow/pull/45563#issuecomment-2585740175
> Merge conflicts on `hatch_build.py` @shahar1 and then hopefully we are good 🤞
Resolved conclicts, I'd be happy if @potiuk could review before merging :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #45563:
URL: https://github.com/apache/airflow/pull/45563#discussion_r1912454398
##########
hatch_build.py:
##########
@@ -148,25 +148,20 @@
DOC_EXTRAS: dict[str, list[str]] = {
"doc": [
- "astroid>=2.12.3,<3.0",
+ "astroid>=3",
"checksumdir>=1.2.0",
"click>=8.1.8",
- # Docutils 0.17.0 converts generated <div class="section"> into <section> and breaks our doc formatting
- # By adding a lot of whitespace separation. This limit can be lifted when we update our doc to handle
- # <section> tags for sections
- "docutils<0.17,>=0.16",
- # The new theme 0.1.0 is for Sphinx 7. We should change it to >=0.1.0 when we move to Sphinx 7
- "sphinx-airflow-theme>=0.0.12,<0.1.0",
+ "docutils>=0.21",
+ "sphinx-airflow-theme>=0.1.0",
+ "docutils>=0.21",
+ "sphinx-airflow-theme>=0.1.0",
Review Comment:
Dependency is doubled now - due to merge conflict...
```suggestion
"docutils>=0.21",
"sphinx-airflow-theme>=0.1.0",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 merged PR #45563:
URL: https://github.com/apache/airflow/pull/45563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #45563:
URL: https://github.com/apache/airflow/pull/45563#discussion_r1912415828
##########
hatch_build.py:
##########
@@ -148,24 +148,18 @@
DOC_EXTRAS: dict[str, list[str]] = {
"doc": [
- "astroid>=2.12.3,<3.0",
+ "astroid>=3",
"checksumdir>=1.2.0",
"click>=8.1.8",
- # Docutils 0.17.0 converts generated <div class="section"> into <section> and breaks our doc formatting
- # By adding a lot of whitespace separation. This limit can be lifted when we update our doc to handle
- # <section> tags for sections
- "docutils<0.17,>=0.16",
+ "docutils>=0.21",
"sphinx-airflow-theme>=0.0.12",
Review Comment:
As it is now there:
```suggestion
"sphinx-airflow-theme>=0.1.0",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #45563:
URL: https://github.com/apache/airflow/pull/45563#discussion_r1912251701
##########
hatch_build.py:
##########
@@ -148,24 +148,18 @@
DOC_EXTRAS: dict[str, list[str]] = {
"doc": [
- "astroid>=2.12.3,<3.0",
+ "astroid>=3",
"checksumdir>=1.2.0",
"click>=8.1.8",
- # Docutils 0.17.0 converts generated <div class="section"> into <section> and breaks our doc formatting
- # By adding a lot of whitespace separation. This limit can be lifted when we update our doc to handle
- # <section> tags for sections
- "docutils<0.17,>=0.16",
+ "docutils>=0.21",
"sphinx-airflow-theme>=0.0.12",
Review Comment:
Before merging, we should create a new version for `sphinx-airflow-theme` (0.1.0) after merging https://github.com/apache/airflow-site/pull/1103
Edit: maybe even a completely new package, because past versions will get broken as we don't pin `sphinx-airflow-theme`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #45563:
URL: https://github.com/apache/airflow/pull/45563#issuecomment-2585689346
It needs conflict resolution though :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on code in PR #45563:
URL: https://github.com/apache/airflow/pull/45563#discussion_r1912429547
##########
docs/sphinx_design/static/custom.css:
##########
@@ -40,3 +40,14 @@ div.admonition.warning {
.rst-content .warning .admonition-title {
background: #cc341d;
}
+
+section {
+ padding-top: 0rem !important;
+ padding-bottom: 0rem !important;
+}
+
+a.headerlink::after {
+ content: url(/images/anchor.svg) !important; /* TODO - Image not existing :-( Needs replacement */
+ visibility: visible !important;
+ font-size: 100% !important;
+}
Review Comment:
Further rework
```suggestion
/* Patches as of moving to Sphinx 7 to get layout to previous state */
/* Needs to be cleaned in a follow-up to source this from the origin style in */
/* https://github.com/apache/airflow-site/blob/main/landing-pages/site/assets/scss/_rst-content.scss */
.base-layout {
padding-top: 123px !important;
}
section {
padding-top: 0rem !important;
padding-bottom: 0rem !important;
}
section ol li p:last-child, section ul li p:last-child {
margin-bottom: 0 !important;
}
a.headerlink {
content: "" !important;
font-size: 75% !important;
}
a.headerlink::after {
content: " [link]" !important; /* Theme image not existing */
visibility: visible !important;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #45563:
URL: https://github.com/apache/airflow/pull/45563#discussion_r1912251701
##########
hatch_build.py:
##########
@@ -148,24 +148,18 @@
DOC_EXTRAS: dict[str, list[str]] = {
"doc": [
- "astroid>=2.12.3,<3.0",
+ "astroid>=3",
"checksumdir>=1.2.0",
"click>=8.1.8",
- # Docutils 0.17.0 converts generated <div class="section"> into <section> and breaks our doc formatting
- # By adding a lot of whitespace separation. This limit can be lifted when we update our doc to handle
- # <section> tags for sections
- "docutils<0.17,>=0.16",
+ "docutils>=0.21",
"sphinx-airflow-theme>=0.0.12",
Review Comment:
Before merging, we should create a new version for `sphinx-airflow-theme` (0.1.0) after merging https://github.com/apache/airflow-site/pull/1103
Edit: maybe even a new package, because past versions might get broken as we don't pin `sphinx-airflow-theme`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #45563:
URL: https://github.com/apache/airflow/pull/45563#discussion_r1912455445
##########
hatch_build.py:
##########
@@ -148,25 +148,20 @@
DOC_EXTRAS: dict[str, list[str]] = {
"doc": [
- "astroid>=2.12.3,<3.0",
+ "astroid>=3",
"checksumdir>=1.2.0",
"click>=8.1.8",
- # Docutils 0.17.0 converts generated <div class="section"> into <section> and breaks our doc formatting
- # By adding a lot of whitespace separation. This limit can be lifted when we update our doc to handle
- # <section> tags for sections
- "docutils<0.17,>=0.16",
- # The new theme 0.1.0 is for Sphinx 7. We should change it to >=0.1.0 when we move to Sphinx 7
- "sphinx-airflow-theme>=0.0.12,<0.1.0",
+ "docutils>=0.21",
+ "sphinx-airflow-theme>=0.1.0",
+ "docutils>=0.21",
+ "sphinx-airflow-theme>=0.1.0",
Review Comment:
Thanks X2 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45563:
URL: https://github.com/apache/airflow/pull/45563#issuecomment-2585764159
### Backport failed to create: v2-10-test. View the failure log <a href='https://github.com/apache/airflow/actions/runs/12734537509'> Run details </a>
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>❌</td>
<td>v2-10-test</td>
<td><a href="https://github.com/apache/airflow/commit/a51ebe43780afc7ba95453a46fd3b8bfae450540"><img src='https://img.shields.io/badge/Commit-a51ebe4-red' alt='Commit Link'></a></td>
</tr>
</table>
You can attempt to backport this manually by running:
```bash
cherry_picker a51ebe4 v2-10-test
```
This should apply the commit to the v2-10-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.
After you have resolved the conflicts, you can continue the backport process by running:
```bash
cherry_picker --continue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #45563:
URL: https://github.com/apache/airflow/pull/45563#discussion_r1912251701
##########
hatch_build.py:
##########
@@ -148,24 +148,18 @@
DOC_EXTRAS: dict[str, list[str]] = {
"doc": [
- "astroid>=2.12.3,<3.0",
+ "astroid>=3",
"checksumdir>=1.2.0",
"click>=8.1.8",
- # Docutils 0.17.0 converts generated <div class="section"> into <section> and breaks our doc formatting
- # By adding a lot of whitespace separation. This limit can be lifted when we update our doc to handle
- # <section> tags for sections
- "docutils<0.17,>=0.16",
+ "docutils>=0.21",
"sphinx-airflow-theme>=0.0.12",
Review Comment:
Before merging, we should create a new version for `sphinx-airflow-theme` (0.1.0) after merging https://github.com/apache/airflow-site/pull/1103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgrade sphinx and related dependencies [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #45563:
URL: https://github.com/apache/airflow/pull/45563#discussion_r1912251165
##########
Dockerfile.ci:
##########
@@ -1355,6 +1355,402 @@ ENV PATH="/files/bin/:/opt/airflow/scripts/in_container/bin/:${PATH}" \
# so we can go back to the default link mode being hardlink.
Review Comment:
This change should be removed before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org