You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/19 08:37:17 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27956: [SPARK-31189][SQL][DOCS] Fix errors and missing parts for datetime pattern document

HyukjinKwon commented on a change in pull request #27956: [SPARK-31189][SQL][DOCS] Fix errors and missing parts for datetime pattern document
URL: https://github.com/apache/spark/pull/27956#discussion_r394863592
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/DataStreamReader.scala
 ##########
 @@ -253,11 +253,13 @@ final class DataStreamReader private[sql](sparkSession: SparkSession) extends Lo
    * `spark.sql.columnNameOfCorruptRecord`): allows renaming the new field having malformed string
    * created by `PERMISSIVE` mode. This overrides `spark.sql.columnNameOfCorruptRecord`.</li>
    * <li>`dateFormat` (default `yyyy-MM-dd`): sets the string that indicates a date format.
-   * Custom date formats follow the formats at `java.time.format.DateTimeFormatter`.
+   * Custom date formats follow the formats at
+   * http://spark.apache.org/docs/latest/sql-ref-datetime-pattern.html.
    * This applies to date type.</li>
    * <li>`timestampFormat` (default `yyyy-MM-dd'T'HH:mm:ss.SSSXXX`): sets the string that
    * indicates a timestamp format. Custom date formats follow the formats at
-   * `java.time.format.DateTimeFormatter`. This applies to timestamp type.</li>
+   * http://spark.apache.org/docs/latest/sql-ref-datetime-pattern.html.
 
 Review comment:
   Shall we use `<a href="http://spark.apache.org/docs/latest/sql-ref-datetime-pattern.html"> Datetime patterns</a>`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org