You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/07/21 17:11:25 UTC
[GitHub] [rocketmq] JanWarlen opened a new pull request, #4657: [ISSUE #4644] Fix mqadmin deleteTopic bug when command exec on slave broker
JanWarlen opened a new pull request, #4657:
URL: https://github.com/apache/rocketmq/pull/4657
**Make sure set the target branch to `develop`**
## What is the purpose of the change
mqadmin deleteTopic only request master brokers
## Brief changelog
`org.apache.rocketmq.tools.command.topic.DeleteTopicSubCommand#deleteTopic`
-- Set brokerAddressSet = CommandUtil.fetchMasterAndSlaveAddrByClusterName(adminExt, clusterName);
-- adminExt.deleteTopicInBroker(brokerAddressSet, topic);
++ Set masterBrokerAddressSet = CommandUtil.fetchMasterAddrByClusterName(adminExt, clusterName);
++ adminExt.deleteTopicInBroker(masterBrokerAddressSet, topic);
## Verifying this change
create branch `develop-deleteTopic-command-fix` based on branch `develop`
Run `mvn -Prelease-all -DskipTests clean package -U` and deploy it by old config.but it cannot run.
```shell
Caused by: java.lang.ClassNotFoundException: com.alibaba.arthas.deps.ch.qos.logback.core.rolling.RollingFileAppender
```
So I use same code on branch `release-4.9.4` and tested on my 1m-2s-sync cluster.
here is the command exec test:
```shell
[root@master bin]# date
Thu Jul 21 12:44:57 EDT 2022
[root@master bin]# ./mqadmin topicList -n master:9876 -c
#Cluster Name #Topic #Consumer Group
DefaultCluster SCHEDULE_TOPIC_XXXX
DefaultCluster RMQ_SYS_TRANS_HALF_TOPIC
DefaultCluster DefaultCluster_REPLY_TOPIC
DefaultCluster BenchmarkTest
DefaultCluster OFFSET_MOVED_EVENT
DefaultCluster broker-a
DefaultCluster TBW102
DefaultCluster SELF_TEST_TOPIC
DefaultCluster DefaultCluster
[root@master bin]# date
Thu Jul 21 12:45:06 EDT 2022
[root@master bin]# ./mqadmin updateTopic -n master:9876 -c DefaultCluster -t test_topic
create topic to 192.168.125.201:10911 success.
TopicConfig [topicName=test_topic, readQueueNums=8, writeQueueNums=8, perm=RW-, topicFilterType=SINGLE_TAG, topicSysFlag=0, order=false][root@master bin]#
[root@master bin]# date
Thu Jul 21 12:45:22 EDT 2022
[root@master bin]# ./mqadmin topicList -n master:9876 -c
#Cluster Name #Topic #Consumer Group
DefaultCluster SCHEDULE_TOPIC_XXXX
DefaultCluster RMQ_SYS_TRANS_HALF_TOPIC
DefaultCluster DefaultCluster_REPLY_TOPIC
DefaultCluster test_topic
DefaultCluster BenchmarkTest
DefaultCluster OFFSET_MOVED_EVENT
DefaultCluster broker-a
DefaultCluster TBW102
DefaultCluster SELF_TEST_TOPIC
DefaultCluster DefaultCluster
[root@master bin]# date
Thu Jul 21 12:45:42 EDT 2022
[root@master bin]# ./mqadmin deleteTopic -n 'master:9876' -c DefaultCluster -t test_topic
brokerAddressSet:[192.168.125.201:10911]
org.apache.rocketmq.tools.admin.DefaultMQAdminExtImpl.deleteTopicInBroker:192.168.125.201:10911
delete topic [test_topic] from cluster [DefaultCluster] success.
delete topic [test_topic] from NameServer success.
[root@master bin]# date
Thu Jul 21 12:45:54 EDT 2022
[root@master bin]# ./mqadmin topicList -n master:9876 -c
#Cluster Name #Topic #Consumer Group
DefaultCluster SCHEDULE_TOPIC_XXXX
DefaultCluster RMQ_SYS_TRANS_HALF_TOPIC
DefaultCluster DefaultCluster_REPLY_TOPIC
DefaultCluster BenchmarkTest
DefaultCluster OFFSET_MOVED_EVENT
DefaultCluster broker-a
DefaultCluster TBW102
DefaultCluster SELF_TEST_TOPIC
DefaultCluster DefaultCluster
[root@master bin]# date
Thu Jul 21 12:46:03 EDT 2022
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-commenter commented on pull request #4657: [ISSUE #4644] Fix mqadmin deleteTopic bug when command exec on slave broker
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4657:
URL: https://github.com/apache/rocketmq/pull/4657#issuecomment-1191784942
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4657?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#4657](https://codecov.io/gh/apache/rocketmq/pull/4657?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3fc180c) into [develop](https://codecov.io/gh/apache/rocketmq/commit/8336b49949a37f2027273c4172c14824fc8d0218?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8336b49) will **decrease** coverage by `0.08%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## develop #4657 +/- ##
=============================================
- Coverage 44.68% 44.60% -0.09%
+ Complexity 7509 7496 -13
=============================================
Files 975 975
Lines 67378 67378
Branches 8892 8892
=============================================
- Hits 30107 30051 -56
- Misses 33547 33600 +53
- Partials 3724 3727 +3
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4657?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tmq/tools/command/topic/DeleteTopicSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4657/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvdG9waWMvRGVsZXRlVG9waWNTdWJDb21tYW5kLmphdmE=) | `27.27% <0.00%> (ø)` | |
| [...q/namesrv/routeinfo/BrokerHousekeepingService.java](https://codecov.io/gh/apache/rocketmq/pull/4657/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vQnJva2VySG91c2VrZWVwaW5nU2VydmljZS5qYXZh) | `72.72% <0.00%> (-9.10%)` | :arrow_down: |
| [...a/org/apache/rocketmq/logging/inner/SysLogger.java](https://codecov.io/gh/apache/rocketmq/pull/4657/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9TeXNMb2dnZXIuamF2YQ==) | `28.57% <0.00%> (-5.72%)` | :arrow_down: |
| [...etmq/namesrv/routeinfo/BatchUnRegisterService.java](https://codecov.io/gh/apache/rocketmq/pull/4657/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vQmF0Y2hVblJlZ2lzdGVyU2VydmljZS5qYXZh) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
| [...ache/rocketmq/common/stats/MomentStatsItemSet.java](https://codecov.io/gh/apache/rocketmq/pull/4657/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vc3RhdHMvTW9tZW50U3RhdHNJdGVtU2V0LmphdmE=) | `39.13% <0.00%> (-4.35%)` | :arrow_down: |
| [...java/org/apache/rocketmq/logging/inner/Logger.java](https://codecov.io/gh/apache/rocketmq/pull/4657/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnZXIuamF2YQ==) | `51.67% <0.00%> (-4.31%)` | :arrow_down: |
| [...a/org/apache/rocketmq/broker/BrokerController.java](https://codecov.io/gh/apache/rocketmq/pull/4657/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9icm9rZXIvQnJva2VyQ29udHJvbGxlci5qYXZh) | `44.02% <0.00%> (-2.67%)` | :arrow_down: |
| [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/4657/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (-2.57%)` | :arrow_down: |
| [...lient/impl/consumer/DefaultMQPushConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4657/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TVFQdXNoQ29uc3VtZXJJbXBsLmphdmE=) | `31.64% <0.00%> (-1.56%)` | :arrow_down: |
| [...rg/apache/rocketmq/remoting/netty/NettyLogger.java](https://codecov.io/gh/apache/rocketmq/pull/4657/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5TG9nZ2VyLmphdmE=) | `14.96% <0.00%> (-1.37%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/rocketmq/pull/4657/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] RongtongJin merged pull request #4657: [ISSUE #4644] Fix mqadmin deleteTopic bug when command exec on slave broker
Posted by GitBox <gi...@apache.org>.
RongtongJin merged PR #4657:
URL: https://github.com/apache/rocketmq/pull/4657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #4657: [ISSUE #4644] Fix mqadmin deleteTopic bug when command exec on slave broker
Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4657:
URL: https://github.com/apache/rocketmq/pull/4657#issuecomment-1191784018
[](https://coveralls.io/builds/51062549)
Coverage increased (+0.07%) to 48.991% when pulling **3fc180cac7401342bd359dbf8fc56ca5a7f95513 on JanWarlen:develop-deleteTopic-command-fix** into **8336b49949a37f2027273c4172c14824fc8d0218 on apache:develop**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org