You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tamaya.apache.org by acoburn <gi...@git.apache.org> on 2018/03/20 19:40:38 UTC

[GitHub] incubator-tamaya-extensions pull request #3: TAMAYA-330: Add jdk9+ build sup...

GitHub user acoburn opened a pull request:

    https://github.com/apache/incubator-tamaya-extensions/pull/3

    TAMAYA-330: Add jdk9+ build support

    This change makes it possible to build Tamaya extensions on JDK 9 and 10.
    
    Most of the changes here related to Maven plugin updates or updates to the dependencies of the Maven plugins. The only code-level change of any consequence is that the OSGi bnd packaging now imports the `javax.annotation` package. In JDK 9+, the Java EE packages are no longer available by default, and so `javax.annotation` must be explicitly imported.
    
    Also, one of the microprofile tests had to be changed -- the test was expecting that converting the Java version into an `Integer` would throw an `IllegalArgumentException`. However, with JDK 10, the Java version _is_ an `Integer`. I changed the type to `java.time.Instant`, which throws the expected exception in Java 8, 9 and 10.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/acoburn/incubator-tamaya-extensions TAMAYA-330

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-tamaya-extensions/pull/3.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3
    
----
commit 54b190666c28df138595cc0fdc39a632e5842a7b
Author: Aaron Coburn <ac...@...>
Date:   2018-03-20T19:33:11Z

    TAMAYA-330: Add jdk9+ build support
    
    This change makes it possible to build Tamaya extensions on JDK 9 and 10.

----


---

[GitHub] incubator-tamaya-extensions pull request #3: TAMAYA-330: Add jdk9+ build sup...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-tamaya-extensions/pull/3


---