You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by "zstan (via GitHub)" <gi...@apache.org> on 2026/05/20 13:25:01 UTC
[PR] IGNITE-28706 Fix TxWithExceptionalInterceptorTest.testTxWithExceptionInterceptor fails [ignite]
zstan opened a new pull request, #13162:
URL: https://github.com/apache/ignite/pull/13162
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28706 Fix TxWithExceptionalInterceptorTest.testTxWithExceptionInterceptor fails [ignite]
Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan commented on PR #13162:
URL: https://github.com/apache/ignite/pull/13162#issuecomment-4498851476
<img width="752" height="275" alt="image" src="https://github.com/user-attachments/assets/9a3f51ee-5ec6-4367-8c4e-be7c3dafda99" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28706 Fix TxWithExceptionalInterceptorTest.testTxWithExceptionInterceptor fails [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13162:
URL: https://github.com/apache/ignite/pull/13162#issuecomment-4499558177
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13162) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=13162&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=13162&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=13162&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=13162&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=13162&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13162)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28706 Fix TxWithExceptionalInterceptorTest.testTxWithExceptionInterceptor fails [ignite]
Posted by "alex-plekhanov (via GitHub)" <gi...@apache.org>.
alex-plekhanov commented on code in PR #13162:
URL: https://github.com/apache/ignite/pull/13162#discussion_r3279745790
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/tx/TxWithExceptionalInterceptorTest.java:
##########
@@ -363,8 +366,19 @@ public void testTxWithExceptionInterceptor() throws Exception {
continue;
}
+ Object sqlVal;
+
// obtain sql results first, kv api can eventually recover results, thus for more clear test - let`s check sql first
- Object sqlVal = getSqlResultByKey(node, PROC_CACHE_NAME, primaryKey, false);
+ try {
+ sqlVal = getSqlResultByKey(node, PROC_CACHE_NAME, primaryKey, false);
+ }
+ catch (IgniteSQLException ex) {
+ assertTrue(X.hasCause(ex, ClusterTopologyException.class));
Review Comment:
1. Block under condition `txCoord == TxCoordNodeRole.PRIMARY` uses `getSqlResultByKey` method too, but not covered by the same check. Why?
2. There is a line in this method:
```
Integer primaryKeyCommon = primaryKeyCoordAware(PROC_CACHE_NAME);
```
Here PROC_CACHE_NAME is used, but not COMMON_CACHE_NAME. Is it intentional?
3. Several code style violations in this method (comment is not started with uppercase, and not ended with the point. Let's fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28706 Fix TxWithExceptionalInterceptorTest.testTxWithExceptionInterceptor fails [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13162:
URL: https://github.com/apache/ignite/pull/13162#issuecomment-4506715487
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13162) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=13162&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=13162&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=13162&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=13162&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=13162&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13162)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28706 Fix TxWithExceptionalInterceptorTest.testTxWithExceptionInterceptor fails [ignite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #13162:
URL: https://github.com/apache/ignite/pull/13162#issuecomment-4499073272
## [](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13162) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=13162&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ignite&pullRequest=13162&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ignite&pullRequest=13162&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=13162&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ignite&pullRequest=13162&metric=new_duplicated_lines_density&view=list)
<!-- sqra-placement-anchor -->
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ignite&pullRequest=13162)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28706 Fix TxWithExceptionalInterceptorTest.testTxWithExceptionInterceptor fails [ignite]
Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan commented on code in PR #13162:
URL: https://github.com/apache/ignite/pull/13162#discussion_r3280032099
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/tx/TxWithExceptionalInterceptorTest.java:
##########
@@ -363,8 +366,19 @@ public void testTxWithExceptionInterceptor() throws Exception {
continue;
}
+ Object sqlVal;
+
// obtain sql results first, kv api can eventually recover results, thus for more clear test - let`s check sql first
- Object sqlVal = getSqlResultByKey(node, PROC_CACHE_NAME, primaryKey, false);
+ try {
+ sqlVal = getSqlResultByKey(node, PROC_CACHE_NAME, primaryKey, false);
+ }
+ catch (IgniteSQLException ex) {
+ assertTrue(X.hasCause(ex, ClusterTopologyException.class));
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] IGNITE-28706 Fix TxWithExceptionalInterceptorTest.testTxWithExceptionInterceptor fails [ignite]
Posted by "zstan (via GitHub)" <gi...@apache.org>.
zstan merged PR #13162:
URL: https://github.com/apache/ignite/pull/13162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org