[GitHub] [spark] zsxwing commented on a change in pull request #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter

[GitBox <gi...@apache.org>]

zsxwing commented on a change in pull request #24365: [SPARK-27453] Pass partitionBy as options in DataFrameWriter
URL: https://github.com/apache/spark/pull/24365#discussion_r275965141
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
 ##########
 @@ -1687,6 +1687,15 @@ object SQLConf {
       .booleanConf
       .createWithDefault(false)
 
+  val LEGACY_PASS_PARTITION_BY_AS_OPTIONS =
+    buildConf("spark.sql.legacy.sources.write.passPartitionByAsOptions")
+      .internal()
 
 Review comment:
   We don't want to document this flag for users. This is just in case we break some existing production workloads. For other users, they don't need to know anything about this flag.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org