You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/09 17:27:27 UTC

[GitHub] [incubator-superset] dpgaspar opened a new pull request #10818: fix(tests): export dataset tests fails with presto

dpgaspar opened a new pull request #10818:
URL: https://github.com/apache/incubator-superset/pull/10818


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10818: fix(tests): export dataset tests fails with presto

Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10818:
URL: https://github.com/apache/incubator-superset/pull/10818#discussion_r485827732



##########
File path: tests/datasets/api_tests.py
##########
@@ -824,6 +824,8 @@ def test_export_dataset(self):
         Dataset API: Test export dataset
         """
         birth_names_dataset = self.get_birth_names_dataset()
+        if birth_names_dataset.database.backend == "presto":

Review comment:
       :) try https://github.com/apache/incubator-superset/blob/master/tox.ini#L37 for the local development ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10818: fix(tests): export dataset tests fails with presto

Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10818:
URL: https://github.com/apache/incubator-superset/pull/10818#discussion_r485798143



##########
File path: tests/datasets/api_tests.py
##########
@@ -824,6 +824,8 @@ def test_export_dataset(self):
         Dataset API: Test export dataset
         """
         birth_names_dataset = self.get_birth_names_dataset()
+        if birth_names_dataset.database.backend == "presto":

Review comment:
       maybe add a todo / git issue to fix it ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch merged pull request #10818: fix(tests): export dataset tests fails with presto

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10818:
URL: https://github.com/apache/incubator-superset/pull/10818


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10818: fix(tests): export dataset tests fails with presto

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10818:
URL: https://github.com/apache/incubator-superset/pull/10818#discussion_r485799601



##########
File path: tests/datasets/api_tests.py
##########
@@ -824,6 +824,8 @@ def test_export_dataset(self):
         Dataset API: Test export dataset
         """
         birth_names_dataset = self.get_birth_names_dataset()
+        if birth_names_dataset.database.backend == "presto":

Review comment:
       that's fast @bkyryliuk :)
   
   Still want to see it fail, so doing the `pass`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10818: fix(tests): export dataset tests fails with presto

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #10818:
URL: https://github.com/apache/incubator-superset/pull/10818#discussion_r485826545



##########
File path: tests/datasets/api_tests.py
##########
@@ -824,6 +824,8 @@ def test_export_dataset(self):
         Dataset API: Test export dataset
         """
         birth_names_dataset = self.get_birth_names_dataset()
+        if birth_names_dataset.database.backend == "presto":

Review comment:
       Did some debuging, take a look at `36f0907` commit, where I raise to see the dump from presto metadata. It's really strange it should work. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10818: fix(tests): export dataset tests fails with presto

Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on a change in pull request #10818:
URL: https://github.com/apache/incubator-superset/pull/10818#discussion_r485827732



##########
File path: tests/datasets/api_tests.py
##########
@@ -824,6 +824,8 @@ def test_export_dataset(self):
         Dataset API: Test export dataset
         """
         birth_names_dataset = self.get_birth_names_dataset()
+        if birth_names_dataset.database.backend == "presto":

Review comment:
       :) try https://github.com/apache/incubator-superset/blob/master/tox.ini#L37 for the local development, much easier to iterate on a single test




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org