You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/21 22:45:57 UTC

[GitHub] [arrow] eerhardt opened a new pull request #7246: ARROW-8882: [C#] Add .editorconfig to C# code

eerhardt opened a new pull request #7246:
URL: https://github.com/apache/arrow/pull/7246


   Adding an `.editorconfig` using the rules from dotnet/runtime repo. See:
   
   * https://github.com/dotnet/runtime/blob/master/docs/coding-guidelines/coding-style.md
   * https://github.com/dotnet/runtime/blob/master/.editorconfig
   
   Violating these rules won't fail the build, but Visual Studio will respect these rules when formatting the code and make suggestions.
   
   The bulk of the violations were `var` usages. There was one unnecessary usage of `this.`. And the rest were naming static fields with `s_`. In `BitUtility.cs`, I made a slight optimization using the pattern recognized by https://github.com/dotnet/roslyn/pull/24621 instead of prefixing the fields with `s_`.
   
   Tagging anyone who has contributed to the C# library (please let me know if I missed anyone):
   @chutchinson @zgramana @nhustler @HashidaTKS @abbotware @pgovind @stephentoub 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] zgramana commented on pull request #7246: ARROW-8882: [C#] Add .editorconfig to C# code

Posted by GitBox <gi...@apache.org>.
zgramana commented on pull request #7246:
URL: https://github.com/apache/arrow/pull/7246#issuecomment-632754359


   This is helpful, thanks @eerhardt! Editorconfig is preferable for those of us using VS Code on *nix.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] eerhardt commented on pull request #7246: ARROW-8882: [C#] Add .editorconfig to C# code

Posted by GitBox <gi...@apache.org>.
eerhardt commented on pull request #7246:
URL: https://github.com/apache/arrow/pull/7246#issuecomment-634206767


   > If there is a mechanism to fail the build with these rules I would recommend trying to add it to the list for check to avoid regressions
   
   There is an experimental package that hasn't been released yet that will allow for enforcement during the build:
   
   https://dotnet.myget.org/feed/roslyn/package/nuget/Microsoft.CodeAnalysis.CSharp.CodeStyle
   
   When this feature is shipped, we can update to using it to start enforcement of code-style rules.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] emkornfield commented on pull request #7246: ARROW-8882: [C#] Add .editorconfig to C# code

Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #7246:
URL: https://github.com/apache/arrow/pull/7246#issuecomment-633101224


   If there is a mechanism to fail the build with these rules I would recommend trying to add it to the list for check to avoid regressions


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] eerhardt commented on pull request #7246: ARROW-8882: [C#] Add .editorconfig to C# code

Posted by GitBox <gi...@apache.org>.
eerhardt commented on pull request #7246:
URL: https://github.com/apache/arrow/pull/7246#issuecomment-632909076


   Also tagging @mr-smidge (sorry I forgot initially)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #7246: ARROW-8882: [C#] Add .editorconfig to C# code

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7246:
URL: https://github.com/apache/arrow/pull/7246#issuecomment-632384111


   https://issues.apache.org/jira/browse/ARROW-8882


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] eerhardt closed pull request #7246: ARROW-8882: [C#] Add .editorconfig to C# code

Posted by GitBox <gi...@apache.org>.
eerhardt closed pull request #7246:
URL: https://github.com/apache/arrow/pull/7246


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org