You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/01/06 10:58:40 UTC
[GitHub] [hbase] wchevreuil commented on a change in pull request #2848: HBASE-25459 WAL can't be cleaned in some scenes
wchevreuil commented on a change in pull request #2848:
URL: https://github.com/apache/hbase/pull/2848#discussion_r552502099
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceIdAccounting.java
##########
@@ -250,7 +250,12 @@ void updateStore(byte[] encodedRegionName, byte[] familyName, Long sequenceId,
*/
private static long getLowestSequenceId(Map<?, Long> sequenceids) {
long lowest = HConstants.NO_SEQNUM;
- for (Long sid: sequenceids.values()) {
+ for (Map.Entry<? , Long> entry : sequenceids.entrySet()){
+ if (entry.getKey() instanceof ImmutableByteArray && entry.getKey().toString().equals("METAFAMILY")){
+ LOG.info("ColumnFamily is METAFAMILY! continue ...");
Review comment:
Should we rather do _trace_ here?
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/SequenceIdAccounting.java
##########
@@ -250,7 +250,12 @@ void updateStore(byte[] encodedRegionName, byte[] familyName, Long sequenceId,
*/
private static long getLowestSequenceId(Map<?, Long> sequenceids) {
long lowest = HConstants.NO_SEQNUM;
- for (Long sid: sequenceids.values()) {
+ for (Map.Entry<? , Long> entry : sequenceids.entrySet()){
+ if (entry.getKey() instanceof ImmutableByteArray && entry.getKey().toString().equals("METAFAMILY")){
Review comment:
Do we need this extra `entry.getKey() instanceof ImmutableByteArray` check? Wouldn't `entry.getKey().toString().equals("METAFAMILY")` already gives `false` in the cases `entry.getKey()` isn't a `ImmutableByteArray`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org