You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/14 04:40:41 UTC

[GitHub] [flink] wuchong commented on a change in pull request #14631: [FLINK-20885][canal][json] Deserialization exception when using 'canal-json.table.include' to filter out the binlog of the specified table

wuchong commented on a change in pull request #14631:
URL: https://github.com/apache/flink/pull/14631#discussion_r557038157



##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowDataDeserializationSchema.java
##########
@@ -113,6 +113,36 @@ public RowData deserialize(@Nullable byte[] message) throws IOException {
         }
     }
 
+    public JsonNode deserializeToJsonNode(@Nullable byte[] message) throws IOException {

Review comment:
       Could you update `deserialize(..)` to reuse these two method?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org