You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by pnowojski <gi...@git.apache.org> on 2017/08/31 15:13:09 UTC
[GitHub] flink pull request #4631: [hotfix][kafka][docs] Add warning regarding data l...
GitHub user pnowojski opened a pull request:
https://github.com/apache/flink/pull/4631
[hotfix][kafka][docs] Add warning regarding data losses when writing …
This pull request add an alert in the documentation about possible data loses while writing to Kafka.
CC @tzulitai @aljoscha
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pnowojski/flink kafka-docs
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4631.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4631
----
commit 0ce3991b7cf01c1c4eba980b2b6563f1f836594f
Author: Piotr Nowojski <pi...@gmail.com>
Date: 2017-08-31T15:10:36Z
[hotfix][kafka][docs] Add warning regarding data losses when writing to Kafka
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4631: [hotfix][kafka][docs] Add warning regarding data l...
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski closed the pull request at:
https://github.com/apache/flink/pull/4631
---
[GitHub] flink issue #4631: [hotfix][kafka][docs] Add warning regarding data losses w...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4631
Merged! 😃
Could you please close this PR if it doesn't auto-merge?
---
[GitHub] flink issue #4631: [hotfix][kafka][docs] Add warning regarding data losses w...
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4631
@aljoscha fixed
---
[GitHub] flink pull request #4631: [hotfix][kafka][docs] Add warning regarding data l...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4631#discussion_r137256929
--- Diff: docs/dev/connectors/kafka.md ---
@@ -475,7 +475,13 @@ are other constructor variants that allow providing the following:
### Kafka Producers and Fault Tolerance
-With Flink's checkpointing enabled, the Flink Kafka Producer can provide
+#### Kafka 0.8
+
+Before 0.9 Kafka did not provide any mechanisms to guarantee at-least-once or exactly-once semantics.
+
+#### Kafka 0.9 and 0.10
+
+With Flink's checkpointing enabled, the `FlinkKafkaProducer010` can provide
--- End diff --
I can fix when merging.
---
[GitHub] flink pull request #4631: [hotfix][kafka][docs] Add warning regarding data l...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4631#discussion_r137256892
--- Diff: docs/dev/connectors/kafka.md ---
@@ -475,7 +475,13 @@ are other constructor variants that allow providing the following:
### Kafka Producers and Fault Tolerance
-With Flink's checkpointing enabled, the Flink Kafka Producer can provide
+#### Kafka 0.8
+
+Before 0.9 Kafka did not provide any mechanisms to guarantee at-least-once or exactly-once semantics.
+
+#### Kafka 0.9 and 0.10
+
+With Flink's checkpointing enabled, the `FlinkKafkaProducer010` can provide
--- End diff --
Should this be `FlinkKafkaProducer09` and `FlinkKafkaProducer010`?
---
[GitHub] flink issue #4631: [hotfix][kafka][docs] Add warning regarding data losses w...
Posted by pnowojski <gi...@git.apache.org>.
Github user pnowojski commented on the issue:
https://github.com/apache/flink/pull/4631
Thanks :)
---