[GitHub] [lucene-solr] romseygeek commented on a change in pull request #162: SOLR-8776: Support RankQuery in grouping

[GitBox <gi...@apache.org>]

romseygeek commented on a change in pull request #162: SOLR-8776: Support RankQuery in grouping
URL: https://github.com/apache/lucene-solr/pull/162#discussion_r274321223
 
 

 ##########
 File path: lucene/grouping/src/java/org/apache/lucene/search/grouping/SecondPassGroupingCollector.java
 ##########
 @@ -52,6 +52,7 @@
   public SecondPassGroupingCollector(GroupSelector<T> groupSelector, Collection<SearchGroup<T>> groups, GroupReducer<T, ?> reducer) {
 
     //System.out.println("SP init");
+    //Do we want to check if groups is null here? instead of checking at line 62?
 
 Review comment:
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org