[GitHub] [echarts] plainheart commented on a diff in pull request #17102: Feature: coarse pointer tolerance

[GitBox <gi...@apache.org>]

plainheart commented on code in PR #17102:
URL: https://github.com/apache/echarts/pull/17102#discussion_r950090072


##########
test/runTest/server.js:
##########
@@ -399,6 +402,7 @@ async function start() {
                     actualVersion: data.actualVersion,
                     expectedVersion: data.expectedVersion,
                     renderer: data.renderer || '',
+                    useCoarsePointer: data.useCoarsePointer || 'auto',

Review Comment:
   If `useCoarsePointer` is `false`?



##########
test/runTest/store.js:
##########
@@ -92,7 +93,8 @@ function parseRunHash(str) {
     return {
         expectedVersion: parts[0],
         actualVersion: parts[1],
-        renderer: parts[2]
+        renderer: parts[2],
+        useCoarsePointer: parts[3]

Review Comment:
   Whether this new hash part should be one of the conditions that check the store version.
   https://github.com/apache/echarts/blob/c1c9faf2691ff94231e8019f375ac8c210b2b5e8/test/runTest/store.js#L111-L117



##########
src/core/echarts.ts:
##########
@@ -418,6 +422,8 @@ class ECharts extends Eventful<ECEventDefinition> {
 
             defaultRenderer = root.__ECHARTS__DEFAULT__RENDERER__ || defaultRenderer;
 
+            defaultCoarsePointer = root.__ECHARTS__DEFAULT__COARSE_POINTER || defaultCoarsePointer;

Review Comment:
   If `root.__ECHARTS__DEFAULT__COARSE_POINTER` is `false`, the default coarse pointer mode still fallbacks to `auto`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org