You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/11/08 07:38:32 UTC
[jira] Created: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
AsyncHammerTest is broken, callbacks need to validate rc parameter
------------------------------------------------------------------
Key: ZOOKEEPER-570
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
Project: Zookeeper
Issue Type: Bug
Components: tests
Affects Versions: 3.2.1
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Priority: Critical
Fix For: 3.2.2, 3.3.0
the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-570:
------------------------------------
Hadoop Flags: [Reviewed]
> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
> Project: Zookeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.2.2, 3.3.0
>
> Attachments: ZOOKEEPER-570.patch, ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774865#action_12774865 ]
Hudson commented on ZOOKEEPER-570:
----------------------------------
Integrated in ZooKeeper-trunk #528 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/528/])
> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
> Project: Zookeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.2.2, 3.3.0
>
> Attachments: ZOOKEEPER-570.patch, ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated ZOOKEEPER-570:
------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed revision 833938.
> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
> Project: Zookeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.2.2, 3.3.0
>
> Attachments: ZOOKEEPER-570.patch, ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780517#action_12780517 ]
Hudson commented on ZOOKEEPER-570:
----------------------------------
Integrated in ZooKeeper-trunk #545 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/545/])
. AsyncHammerTest is broken, callbacks need to validate rc parameter
> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
> Project: Zookeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-570.patch, ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774833#action_12774833 ]
Benjamin Reed commented on ZOOKEEPER-570:
-----------------------------------------
+1 good job. what a messed up patch!
> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
> Project: Zookeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.2.2, 3.3.0
>
> Attachments: ZOOKEEPER-570.patch, ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-570:
-----------------------------------
Attachment: ZOOKEEPER-570.patch
Fixed the test:
1) delete now uses name rather than path (since create is using seq flag)
this was the main issue previously
2) fail the test if create or delete operations fail
3) don't send messages to the server until connected - otw false positive failure due to queued aysnc op when client times out
> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
> Project: Zookeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.2.2, 3.3.0
>
> Attachments: ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-570:
-----------------------------------
Status: Patch Available (was: Open)
> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
> Project: Zookeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.2.2, 3.3.0
>
> Attachments: ZOOKEEPER-570.patch, ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-570:
-----------------------------------
Status: Patch Available (was: Open)
> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
> Project: Zookeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.2.2, 3.3.0
>
> Attachments: ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-570:
-----------------------------------
Fix Version/s: (was: 3.2.2)
Dropping this from 3.2.2, it's not a bug fix (well, it is a fix to a test) but it does depend on refactored code from
3.3, it's not clear how this would be done (easily/successfully), dropping from 3.2.2
> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
> Project: Zookeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-570.patch, ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-570:
-----------------------------------
Attachment: ZOOKEEPER-570.patch
same patch as before, however I noticed that there was a serious flaw with the
verification phase, which restarted the quorum. The restart code was wrong,
it caused a new quorum to be started, rather than restarting the existing quorum.
This addresses the original cause of the test failing, plus the original patch's
fix for the delete not being correct (etc...)
> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
> Project: Zookeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.2.2, 3.3.0
>
> Attachments: ZOOKEEPER-570.patch, ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774740#action_12774740 ]
Hadoop QA commented on ZOOKEEPER-570:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12424290/ZOOKEEPER-570.patch
against trunk revision 833639.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/55/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/55/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/55/console
This message is automatically generated.
> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
> Project: Zookeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.2.2, 3.3.0
>
> Attachments: ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-570) AsyncHammerTest is broken,
callbacks need to validate rc parameter
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-570:
-----------------------------------
Status: Open (was: Patch Available)
> AsyncHammerTest is broken, callbacks need to validate rc parameter
> ------------------------------------------------------------------
>
> Key: ZOOKEEPER-570
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-570
> Project: Zookeeper
> Issue Type: Bug
> Components: tests
> Affects Versions: 3.2.1
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Priority: Critical
> Fix For: 3.2.2, 3.3.0
>
> Attachments: ZOOKEEPER-570.patch
>
>
> the asynchammertest is not validating the rc in the callback, more serious is that it is using path in the create callback
> to delete the node, rather than name (which is important in the case of a sequential node creation as in this case)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.