You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2018/12/19 18:38:47 UTC
[GitHub] [geode] PurelyApplied opened pull request #3022: GEODE-6224:
Do not use internal BOM to resolve versions.
* The BOM creation at task execution time made downstream consumption at configuration time untenable.
* Until a cleaner solution is identified, we explicitly add the dependency management to each module's POM.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/3022 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] nabarunnag commented on issue #3022: GEODE-6224: Do
not use internal BOM to resolve versions.
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
This still fails
checkout geode-benchmark project
run
./gradlew --include-build <path to geode with this PR applied> build
[ Full content available at: https://github.com/apache/geode/pull/3022 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] nabarunnag commented on issue #3022: GEODE-6224: Do
not use internal BOM to resolve versions.
Posted by "nabarunnag (GitHub)" <gi...@apache.org>.
This still fails
checkout geode-benchmark project
run
./gradlew --include-build [ path to geode with this PR applied ] build
[ Full content available at: https://github.com/apache/geode/pull/3022 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied closed pull request #3022: GEODE-6224:
Do not use internal BOM to resolve versions.
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
[ pull request closed by PurelyApplied ]
[ Full content available at: https://github.com/apache/geode/pull/3022 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on issue #3022: GEODE-6224:
Do not use internal BOM to resolve versions.
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
The two `build.gradle` file changes is really just a migration of the `dependencyManagement` block. The rest is an update / bloating of the POM for now so that things are visible at build configuration time.
[ Full content available at: https://github.com/apache/geode/pull/3022 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org