You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by dawidwys <gi...@git.apache.org> on 2017/07/27 08:51:47 UTC
[GitHub] flink pull request #4406: [FLINK-7280] Wrong clearing SharedBuffer of Equal ...
GitHub user dawidwys opened a pull request:
https://github.com/apache/flink/pull/4406
[FLINK-7280] Wrong clearing SharedBuffer of Equal elements with same …
## What is the purpose of the change
Fixes a bug that resulted in not clearing the NFA when the matched sequence ended with elements of same timestamp.
## Brief change log
- clearing the elements by counter of the newly created computation state instead of previous one
## Verifying this change
This change added tests and can be verified as follows:
- Added tests when a sequence ends with elements of same timestamp
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dawidwys/flink cep-same-elements-bug
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4406.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4406
----
commit 410822caa2ecd60395570dae535e11909f56810f
Author: Dawid Wysakowicz <dw...@apache.org>
Date: 2017-07-27T08:45:17Z
[FLINK-7280] Wrong clearing SharedBuffer of Equal elements with same Timestamp
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4406: [FLINK-7280] Wrong clearing SharedBuffer of Equal ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4406
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4406: [FLINK-7280] Wrong clearing SharedBuffer of Equal element...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4406
@dawidwys I will have a look later today!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4406: [FLINK-7280] Wrong clearing SharedBuffer of Equal element...
Posted by dawidwys <gi...@git.apache.org>.
Github user dawidwys commented on the issue:
https://github.com/apache/flink/pull/4406
merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4406: [FLINK-7280] Wrong clearing SharedBuffer of Equal element...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/4406
@dawidwys The changes look good! I checked with `oneOrMore()` and `zeroOrMore()` to see if we prematurely clean up the state and it seems to be ok.
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---