You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Eric Conner <er...@gmail.com> on 2017/06/22 16:49:22 UTC
Broken Build?
Hi all,
I am a (potentially) new contributor who is trying to add a patch. It
appears that the build is broken.
The first 3 cross language tests fail with
[java] Sample TSimpleJSONProtocol output:
[java] {}
[java] org.apache.thrift.transport.TTransportException:
javax.net.ssl.SSLProtocolException: handshake alert: internal_error
...
And the other two failures appear to be caused by missing npm:
UBSan...
/bin/bash: npm: command not found
Java, Lua, Php...
/bin/bash: npm: command not found
I'd be happy to help try to fix these failures, but I'm not exactly sure
how to replicate the build environments locally. Are there instructions on
how to do that? (I've looked at "make cross" but that doesn't appear to
use docker as the build does).
Thanks!
-Eric
Re: Broken Build?
Posted by Jens Geyer <je...@hotmail.com>.
Ywes, you are right. The NPM maintainers do not intend to fix their crap and
nobody else seems to care.
-----Ursprüngliche Nachricht-----
From: Eric Conner
Sent: Thursday, June 22, 2017 6:49 PM
To: dev@thrift.apache.org
Subject: Broken Build?
Hi all,
I am a (potentially) new contributor who is trying to add a patch. It
appears that the build is broken.
The first 3 cross language tests fail with
[java] Sample TSimpleJSONProtocol output:
[java] {}
[java] org.apache.thrift.transport.TTransportException:
javax.net.ssl.SSLProtocolException: handshake alert: internal_error
...
And the other two failures appear to be caused by missing npm:
UBSan...
/bin/bash: npm: command not found
Java, Lua, Php...
/bin/bash: npm: command not found
I'd be happy to help try to fix these failures, but I'm not exactly sure
how to replicate the build environments locally. Are there instructions on
how to do that? (I've looked at "make cross" but that doesn't appear to
use docker as the build does).
Thanks!
-Eric
Re: Broken Build?
Posted by Eric Conner <er...@gmail.com>.
Ok, these 2 PRs together should fix the build:
https://github.com/apache/thrift/pull/1296
https://github.com/apache/thrift/pull/1295
On Sat, Jun 24, 2017 at 7:04 PM, Eric Conner <er...@gmail.com> wrote:
> Great, I've updated the issue with a PR and some comments. We can move
> the discussion there.
>
> On Sat, Jun 24, 2017 at 3:05 AM, Jens Geyer <je...@hotmail.com> wrote:
>
>> Hi,
>>
>> the ticket describing the issue in more detail is this:
>>
>> https://issues.apache.org/jira/browse/THRIFT-4213
>>
>> There is also a link to the recently auto-closed npm issue.
>>
>> The builds use some docker container infrastructure which one can find in
>> the /builds directory.
>>
>> Appreciating your help!
>>
>> Have fun,
>> JensG
>>
>>
>>
>>
>> -----Ursprüngliche Nachricht-----
>> From: Eric Conner
>> Sent: Thursday, June 22, 2017 6:49 PM
>> To: dev@thrift.apache.org
>> Subject: Broken Build?
>>
>> Hi all,
>> I am a (potentially) new contributor who is trying to add a patch. It
>> appears that the build is broken.
>>
>> The first 3 cross language tests fail with
>> [java] Sample TSimpleJSONProtocol output:
>> [java] {}
>> [java] org.apache.thrift.transport.TTransportException:
>> javax.net.ssl.SSLProtocolException: handshake alert: internal_error
>> ...
>>
>> And the other two failures appear to be caused by missing npm:
>> UBSan...
>> /bin/bash: npm: command not found
>>
>> Java, Lua, Php...
>> /bin/bash: npm: command not found
>>
>> I'd be happy to help try to fix these failures, but I'm not exactly sure
>> how to replicate the build environments locally. Are there instructions
>> on
>> how to do that? (I've looked at "make cross" but that doesn't appear to
>> use docker as the build does).
>>
>> Thanks!
>> -Eric
>>
>>
>
Re: Broken Build?
Posted by Eric Conner <er...@gmail.com>.
Great, I've updated the issue with a PR and some comments. We can move the
discussion there.
On Sat, Jun 24, 2017 at 3:05 AM, Jens Geyer <je...@hotmail.com> wrote:
> Hi,
>
> the ticket describing the issue in more detail is this:
>
> https://issues.apache.org/jira/browse/THRIFT-4213
>
> There is also a link to the recently auto-closed npm issue.
>
> The builds use some docker container infrastructure which one can find in
> the /builds directory.
>
> Appreciating your help!
>
> Have fun,
> JensG
>
>
>
>
> -----Ursprüngliche Nachricht-----
> From: Eric Conner
> Sent: Thursday, June 22, 2017 6:49 PM
> To: dev@thrift.apache.org
> Subject: Broken Build?
>
> Hi all,
> I am a (potentially) new contributor who is trying to add a patch. It
> appears that the build is broken.
>
> The first 3 cross language tests fail with
> [java] Sample TSimpleJSONProtocol output:
> [java] {}
> [java] org.apache.thrift.transport.TTransportException:
> javax.net.ssl.SSLProtocolException: handshake alert: internal_error
> ...
>
> And the other two failures appear to be caused by missing npm:
> UBSan...
> /bin/bash: npm: command not found
>
> Java, Lua, Php...
> /bin/bash: npm: command not found
>
> I'd be happy to help try to fix these failures, but I'm not exactly sure
> how to replicate the build environments locally. Are there instructions on
> how to do that? (I've looked at "make cross" but that doesn't appear to
> use docker as the build does).
>
> Thanks!
> -Eric
>
>
Re: Broken Build?
Posted by Jens Geyer <je...@hotmail.com>.
Hi,
the ticket describing the issue in more detail is this:
https://issues.apache.org/jira/browse/THRIFT-4213
There is also a link to the recently auto-closed npm issue.
The builds use some docker container infrastructure which one can find in
the /builds directory.
Appreciating your help!
Have fun,
JensG
-----Ursprüngliche Nachricht-----
From: Eric Conner
Sent: Thursday, June 22, 2017 6:49 PM
To: dev@thrift.apache.org
Subject: Broken Build?
Hi all,
I am a (potentially) new contributor who is trying to add a patch. It
appears that the build is broken.
The first 3 cross language tests fail with
[java] Sample TSimpleJSONProtocol output:
[java] {}
[java] org.apache.thrift.transport.TTransportException:
javax.net.ssl.SSLProtocolException: handshake alert: internal_error
...
And the other two failures appear to be caused by missing npm:
UBSan...
/bin/bash: npm: command not found
Java, Lua, Php...
/bin/bash: npm: command not found
I'd be happy to help try to fix these failures, but I'm not exactly sure
how to replicate the build environments locally. Are there instructions on
how to do that? (I've looked at "make cross" but that doesn't appear to
use docker as the build does).
Thanks!
-Eric