You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by pietermartin <gi...@git.apache.org> on 2017/11/19 10:30:27 UTC

[GitHub] tinkerpop pull request #751: TINKERPOP-1832: TraversalHelper.replaceStep set...

GitHub user pietermartin opened a pull request:

    https://github.com/apache/tinkerpop/pull/751

    TINKERPOP-1832: TraversalHelper.replaceStep sets previousStep to the wrong step

    https://issues.apache.org/jira/browse/TINKERPOP-1832
    
    `TraversalHelper.replaceStep` needs to first remove the step before adding in the new step. Else it gets its `previousStep` pointer wrong.
    
    Added `TraversalHelperTest.shouldSetPreviousStepToEmptyStep` which was the scenario that originally made me aware of the issue.
    
    Ran `mvn clean install` and tested Sqlg's tests with the fix.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pietermartin/tinkerpop TINKERPOP-1832

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/751.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #751
    
----
commit d40381c337ade06cf02388d014b7cc6d4ac8d7a1
Author: pieter <pi...@riseup.net>
Date:   2017-11-19T10:17:50Z

    TINKERPOP-1832 - Fix bug where TraversalHelper.replaceStep sets the steps' previousStep incorrectly.
    It needs to remove the replaced step before inserting the new step.

----


---

[GitHub] tinkerpop issue #751: TINKERPOP-1832: TraversalHelper.replaceStep sets previ...

Posted by pietermartin <gi...@git.apache.org>.

Github user pietermartin commented on the issue:

    https://github.com/apache/tinkerpop/pull/751
  
    VOTE +1


---

[GitHub] tinkerpop issue #751: TINKERPOP-1832: TraversalHelper.replaceStep sets previ...

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/751
  
    This PR is targetted at master (3.3.x) - any reason to not also target tp32 (3.2.x) or is this just a problem on the 3.3.x line?


---

[GitHub] tinkerpop pull request #751: TINKERPOP-1832: TraversalHelper.replaceStep set...

Posted by pietermartin <gi...@git.apache.org>.

Github user pietermartin closed the pull request at:

    https://github.com/apache/tinkerpop/pull/751


---

[GitHub] tinkerpop issue #751: TINKERPOP-1832: TraversalHelper.replaceStep sets previ...

Posted by pietermartin <gi...@git.apache.org>.

Github user pietermartin commented on the issue:

    https://github.com/apache/tinkerpop/pull/751
  
    I'd have to check but pretty sure its the same on 3.2.x


---

[GitHub] tinkerpop issue #751: TINKERPOP-1832: TraversalHelper.replaceStep sets previ...

Posted by pietermartin <gi...@git.apache.org>.

Github user pietermartin commented on the issue:

    https://github.com/apache/tinkerpop/pull/751
  
    Closing to retarget tp32


---

[GitHub] tinkerpop issue #751: TINKERPOP-1832: TraversalHelper.replaceStep sets previ...

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/751
  
    It is the same in 3.2.x and was actually testing the fix in `tp32` when the discussion first came up.
    
    VOTE: +1 (after retargeting)


---