You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@celeborn.apache.org by zh...@apache.org on 2023/10/24 13:17:04 UTC
[incubator-celeborn] branch branch-0.3 updated: [CELEBORN-1086] Fix JVM metrics grafana expression issue
This is an automated email from the ASF dual-hosted git repository.
zhouky pushed a commit to branch branch-0.3
in repository https://gitbox.apache.org/repos/asf/incubator-celeborn.git
The following commit(s) were added to refs/heads/branch-0.3 by this push:
new c1e73efa3 [CELEBORN-1086] Fix JVM metrics grafana expression issue
c1e73efa3 is described below
commit c1e73efa36579962dd0e03f689dc6e6a29538f78
Author: fwang12 <fw...@ebay.com>
AuthorDate: Tue Oct 24 21:16:42 2023 +0800
[CELEBORN-1086] Fix JVM metrics grafana expression issue
### What changes were proposed in this pull request?
Fix jvm metrics grafana expression issue.
### Why are the changes needed?
![image](https://github.com/apache/incubator-celeborn/assets/6757692/becedc53-da90-4cce-a494-497b1c55c7a4)
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Local Test.
<img width="867" alt="image" src="https://github.com/apache/incubator-celeborn/assets/6757692/a9720fc1-9699-47e8-847e-951947f57e01">
Closes #2036 from turboFei/fix_metrics.
Authored-by: fwang12 <fw...@ebay.com>
Signed-off-by: zky.zhoukeyong <zk...@alibaba-inc.com>
(cherry picked from commit 819df5f2c4c1aae122a39c6f35fb1668f8ba7f25)
Signed-off-by: zky.zhoukeyong <zk...@alibaba-inc.com>
---
assets/grafana/celeborn-jvm-dashboard.json | 74 +++++++++++++++++++++++++++---
1 file changed, 68 insertions(+), 6 deletions(-)
diff --git a/assets/grafana/celeborn-jvm-dashboard.json b/assets/grafana/celeborn-jvm-dashboard.json
index 50515c03d..5aa3d4750 100644
--- a/assets/grafana/celeborn-jvm-dashboard.json
+++ b/assets/grafana/celeborn-jvm-dashboard.json
@@ -739,13 +739,13 @@
"downsampleAggregator": "avg",
"downsampleFillPolicy": "none",
"editorMode": "code",
- "expr": "increase(metrics_jvm_gc_time_Value{instance=~\"${instance}\"})",
+ "expr": "increase(metrics_jvm_gc_time_Value{instance=~\"${instance}\"}[${interval}])",
"legendFormat": "{{name}}_{{instance}}",
"range": true,
"refId": "A"
}
],
- "title": "Collection Time",
+ "title": "Collection Time Increase[${interval}]",
"type": "timeseries"
},
{
@@ -834,13 +834,13 @@
"downsampleAggregator": "avg",
"downsampleFillPolicy": "none",
"editorMode": "code",
- "expr": "increase(metrics_jvm_gc_count_Value{instance=~\"${instance}\"})",
+ "expr": "increase(metrics_jvm_gc_count_Value{instance=~\"${instance}\"}[${interval}])",
"legendFormat": "{{name}}_{{instance}}",
"range": true,
"refId": "A"
}
],
- "title": "Collection Counts",
+ "title": "Collection Counts Increase[${interval}]",
"type": "timeseries"
},
{
@@ -943,13 +943,13 @@
"downsampleAggregator": "avg",
"downsampleFillPolicy": "none",
"editorMode": "code",
- "expr": "increase(metrics_JVMCPUTime_Value{instance=~\"${instance}\"})",
+ "expr": "increase(metrics_JVMCPUTime_Value{instance=~\"${instance}\"}[${interval}])",
"legendFormat": "{{instance}}",
"range": true,
"refId": "A"
}
],
- "title": "CPU Usage",
+ "title": "CPU Usage Increase[${interval}]",
"type": "timeseries"
},
{
@@ -1892,6 +1892,68 @@
"skipUrlSync": false,
"sort": 1,
"type": "query"
+ },
+ {
+ "current": {
+ "selected": true,
+ "text": [
+ "5m"
+ ],
+ "value": [
+ "5m"
+ ]
+ },
+ "description": "",
+ "hide": 0,
+ "includeAll": false,
+ "multi": false,
+ "name": "interval",
+ "options": [
+ {
+ "selected": false,
+ "text": "5m",
+ "value": "5m"
+ },
+ {
+ "selected": false,
+ "text": "30m",
+ "value": "30m"
+ },
+ {
+ "selected": false,
+ "text": "1h",
+ "value": "1h"
+ },
+ {
+ "selected": false,
+ "text": "6h",
+ "value": "6h"
+ },
+ {
+ "selected": false,
+ "text": "12h",
+ "value": "12h"
+ },
+ {
+ "selected": true,
+ "text": "1d",
+ "value": "1d"
+ },
+ {
+ "selected": false,
+ "text": "3d",
+ "value": "3d"
+ },
+ {
+ "selected": false,
+ "text": "7d",
+ "value": "7d"
+ }
+ ],
+ "query": "5m,30m,1h,6h,12h,1d,3d,7d",
+ "queryValue": "",
+ "skipUrlSync": false,
+ "type": "custom"
}
]
},