You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Ho (Code Review)" <ge...@cloudera.org> on 2018/11/07 22:57:55 UTC
[Impala-ASF-CR] IMPALA-7148: Make test profile fragment instances() more robust
Michael Ho has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11906
Change subject: IMPALA-7148: Make test_profile_fragment_instances() more robust
......................................................................
IMPALA-7148: Make test_profile_fragment_instances() more robust
test_profile_fragment_instances() makes assumption about number
of instances of each scan node in the distributed query plan.
The number of instances for each scan nodes can actually vary
depending on how data is loaded and scheduler's decision.
This change relaxes the check for number of instances of each
scan node is a multiple of 3 which is the number of scan nodes
in the plan.
Change-Id: I08b068c21e9637575c85f4d54be9f7c56c106bf1
---
M tests/query_test/test_observability.py
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/11906/1
--
To view, visit http://gerrit.cloudera.org:8080/11906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08b068c21e9637575c85f4d54be9f7c56c106bf1
Gerrit-Change-Number: 11906
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
[Impala-ASF-CR] IMPALA-7148: Make test profile fragment instances() more robust
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11906 )
Change subject: IMPALA-7148: Make test_profile_fragment_instances() more robust
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1321/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/11906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b068c21e9637575c85f4d54be9f7c56c106bf1
Gerrit-Change-Number: 11906
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Wed, 07 Nov 2018 23:35:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7148: Make test profile fragment instances() more robust
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11906 )
Change subject: IMPALA-7148: Make test_profile_fragment_instances() more robust
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b068c21e9637575c85f4d54be9f7c56c106bf1
Gerrit-Change-Number: 11906
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 00:22:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7148: Make test profile fragment instances() more robust
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11906 )
Change subject: IMPALA-7148: Make test_profile_fragment_instances() more robust
......................................................................
IMPALA-7148: Make test_profile_fragment_instances() more robust
test_profile_fragment_instances() makes assumption about number
of instances of each scan node in the distributed query plan.
The number of instances for each scan nodes can actually vary
depending on how data is loaded and scheduler's decision.
This change relaxes the check for number of instances of each
scan node is a multiple of 3 which is the number of scan nodes
in the plan.
Change-Id: I08b068c21e9637575c85f4d54be9f7c56c106bf1
Reviewed-on: http://gerrit.cloudera.org:8080/11906
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/query_test/test_observability.py
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/11906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I08b068c21e9637575c85f4d54be9f7c56c106bf1
Gerrit-Change-Number: 11906
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
[Impala-ASF-CR] IMPALA-7148: Make test profile fragment instances() more robust
Posted by "Michael Ho (Code Review)" <ge...@cloudera.org>.
Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11906 )
Change subject: IMPALA-7148: Make test_profile_fragment_instances() more robust
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11906/1/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:
http://gerrit.cloudera.org:8080/#/c/11906/1/tests/query_test/test_observability.py@166
PS1, Line 166: assert results.runtime_profile.count("EXCHANGE_NODE") == 6
> This count is affected too, right? eg. if the query was scheduled on 2 host
I believe there are only one instance of each exchange nodes and there are 3 exchange nodes. So it's 3*2 == 6.
--
To view, visit http://gerrit.cloudera.org:8080/11906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b068c21e9637575c85f4d54be9f7c56c106bf1
Gerrit-Change-Number: 11906
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 00:17:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7148: Make test profile fragment instances() more robust
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11906 )
Change subject: IMPALA-7148: Make test_profile_fragment_instances() more robust
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/11906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b068c21e9637575c85f4d54be9f7c56c106bf1
Gerrit-Change-Number: 11906
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 09:54:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7148: Make test profile fragment instances() more robust
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11906 )
Change subject: IMPALA-7148: Make test_profile_fragment_instances() more robust
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11906/1/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:
http://gerrit.cloudera.org:8080/#/c/11906/1/tests/query_test/test_observability.py@166
PS1, Line 166: assert results.runtime_profile.count("EXCHANGE_NODE") == 6
This count is affected too, right? eg. if the query was scheduled on 2 hosts this should be 4, so it should be n * 2
--
To view, visit http://gerrit.cloudera.org:8080/11906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b068c21e9637575c85f4d54be9f7c56c106bf1
Gerrit-Change-Number: 11906
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Wed, 07 Nov 2018 23:54:47 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-7148: Make test profile fragment instances() more robust
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11906 )
Change subject: IMPALA-7148: Make test_profile_fragment_instances() more robust
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b068c21e9637575c85f4d54be9f7c56c106bf1
Gerrit-Change-Number: 11906
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 05:56:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-7148: Make test profile fragment instances() more robust
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11906 )
Change subject: IMPALA-7148: Make test_profile_fragment_instances() more robust
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3445/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/11906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I08b068c21e9637575c85f4d54be9f7c56c106bf1
Gerrit-Change-Number: 11906
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <th...@cmu.edu>
Gerrit-Comment-Date: Thu, 08 Nov 2018 05:56:30 +0000
Gerrit-HasComments: No