You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Jörg Hohwiller (JIRA)" <ji...@codehaus.org> on 2013/10/24 18:12:52 UTC

[jira] (SUREFIRE-560) tests with @Ignore are treated as "unsuccessful"

    [ https://jira.codehaus.org/browse/SUREFIRE-560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=334630#comment-334630 ] 

Jörg Hohwiller commented on SUREFIRE-560:
-----------------------------------------

I still disagree:

Tests 	Errors 	Failures 	Skipped 	Success Rate 	Time
348 	0 	0 		3	 	99.138% 	35.919


Success rate should be 100%. Otherwise Skipped is considered as unsuccessful what is the topic of this issue.

So I cannot use @Ignore for manual tests :(
Seems I have to refactor all my tests and extract tests that can not run reliable or platform-independent in automation to different classes that are not matching the surefire test pattern. However, this sucks as I have sub-classes to test the same thing with and without spring what duplicates my effort.
                
> tests with @Ignore are treated as "unsuccessful"
> ------------------------------------------------
>
>                 Key: SUREFIRE-560
>                 URL: https://jira.codehaus.org/browse/SUREFIRE-560
>             Project: Maven Surefire
>          Issue Type: Bug
>          Components: Maven Surefire Report Plugin
>    Affects Versions: 2.4.3
>            Reporter: Jörg Hohwiller
>            Assignee: Kristian Rosenvold
>             Fix For: 2.7.2
>
>
> According to SUREFIRE-303 you care about @Ignore tests which is generally a good idea.
> However you treat them as "unsuccessful" and then dashboard-maven-plugin marks this in red.
> I am using @Ignore for JUnit test-methods that can NOT run headless or in a os-independent batch, or whatever.
> Generally I think that this is what @Ignore is all about. If I have tests that do not work but definitely should, I would
> NOT add an @Ignore and get an according failure until the bug is fixed.
> So either provide a way to mark test-methods as skipped by maven but not treated unsuccessful, e.g.
> via some prefix like "OK:" in @Ignore("OK: manual test") or by generally treating @Ignore
> as harmless. I personally suggest the latter.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira