You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/30 01:38:57 UTC
[GitHub] [dubbo-go] codecov-io commented on pull request #823: optimize get url with pointer type
codecov-io commented on pull request #823:
URL: https://github.com/apache/dubbo-go/pull/823#issuecomment-719117994
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/823?src=pr&el=h1) Report
> Merging [#823](https://codecov.io/gh/apache/dubbo-go/pull/823?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/0384e201ecac8a1a76659b5dbf5f9f07edf41533?el=desc) will **decrease** coverage by `0.33%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/823?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #823 +/- ##
===========================================
- Coverage 59.84% 59.50% -0.34%
===========================================
Files 260 260
Lines 12762 12764 +2
===========================================
- Hits 7637 7595 -42
- Misses 4169 4211 +42
- Partials 956 958 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/823?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/823/diff?src=pr&el=tree#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `66.66% <ø> (ø)` | |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/823/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `61.48% <ø> (ø)` | |
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/823/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `61.97% <0.00%> (ø)` | |
| [filter/filter\_impl/sentinel\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/823/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3NlbnRpbmVsX2ZpbHRlci5nbw==) | `62.22% <ø> (ø)` | |
| [...lter/filter\_impl/tps/tps\_limiter\_method\_service.go](https://codecov.io/gh/apache/dubbo-go/pull/823/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tZXRob2Rfc2VydmljZS5nbw==) | `78.57% <ø> (ø)` | |
| [filter/filter\_impl/tps/tps\_limiter\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/823/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL3Rwcy90cHNfbGltaXRlcl9tb2NrLmdv) | `0.00% <ø> (ø)` | |
| [filter/handler/rejected\_execution\_handler\_mock.go](https://codecov.io/gh/apache/dubbo-go/pull/823/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfbW9jay5nbw==) | `0.00% <ø> (ø)` | |
| [...ter/handler/rejected\_execution\_handler\_only\_log.go](https://codecov.io/gh/apache/dubbo-go/pull/823/diff?src=pr&el=tree#diff-ZmlsdGVyL2hhbmRsZXIvcmVqZWN0ZWRfZXhlY3V0aW9uX2hhbmRsZXJfb25seV9sb2cuZ28=) | `100.00% <ø> (ø)` | |
| [metrics/prometheus/reporter.go](https://codecov.io/gh/apache/dubbo-go/pull/823/diff?src=pr&el=tree#diff-bWV0cmljcy9wcm9tZXRoZXVzL3JlcG9ydGVyLmdv) | `100.00% <ø> (ø)` | |
| [protocol/invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/823/diff?src=pr&el=tree#diff-cHJvdG9jb2wvaW52b2tlci5nbw==) | `0.00% <ø> (ø)` | |
| ... and [36 more](https://codecov.io/gh/apache/dubbo-go/pull/823/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/823?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/823?src=pr&el=footer). Last update [0384e20...4d55a06](https://codecov.io/gh/apache/dubbo-go/pull/823?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org