You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Taras Ledkov <tl...@apache.org> on 2022/12/01 13:48:44 UTC

Re:[DISCUSSION] Removal of ignitevisorcmd

Hi,

+1 for remove Visor related code.
Unfortunately we have to migrate `control-utility` to use IgniteClient (thin client) before drop GridClient. I guess we will do it in the future.

Also, the old thin JDBC based on the GridClient (classes placed at the org.apache.ignite.internal.jdbc.*) must be removed.

Re: [DISCUSSION] Removal of ignitevisorcmd

Posted by Nikolay Izhikov <ni...@apache.org>.
Thanks.

Ticket created - https://issues.apache.org/jira/browse/IGNITE-18327

пт, 2 дек. 2022 г. в 15:25, 18624049226 <18...@163.com>:

> Visor has a 'cache -clear' function, this function is very useful,
> especially in some O&M scenarios.
>
> Because Ignite does not support the TRUNCATE command, it is necessary to
> provide a high-performance clear table data command.
>
> 在 2022/12/2 19:13, Nikolay Izhikov 写道:
> > THanks, Slava, Stephen.
> >
> > Ticket to reimplement cache scan created -
> > https://issues.apache.org/jira/browse/IGNITE-18320
> >
> > пт, 2 дек. 2022 г. в 13:30, Stephen Darlington <
> > stephen.darlington@gridgain.com>:
> >
> >> One option that’s in Visor but not control.sh is the ability to view
> cache
> >> content (cache -scan). I do hear of people using that.
> >>
> >>> On 2 Dec 2022, at 09:17, Andrey Mashenkov<an...@gmail.com>
> >> wrote:
> >>> Hi Igniters,
> >>>
> >>> I agree with Slava, we have to provide alternative ways for users
> before
> >>> dropping a feature that just worked.
> >>> A user may use some feature for a long time without any issues, so,
> this
> >> is
> >>> why there is no mention in chats/mails.
> >>> I mean here, the feature is not only the whole visor command, but a
> >> command
> >>> option that just makes UX better.
> >>>
> >>> I think we can revise visor features, which are not supported by
> >>> control.sh, and create an umbrella ticket for supporting in control.sh.
> >>> Set this ticket either as 'required' for a 'dropping visor ticket', or
> >> as a
> >>> blocker for the next release if visor dropping will come first.
> >>>
> >>> On Fri, Dec 2, 2022 at 11:09 AM Nikolay Izhikov<ni...@apache.org>
> >> wrote:
> >>>> Hello, Slava.
> >>>>
> >>>>> However, do we have a list of useful features that do not exist in
> our
> >>>> control utility?
> >>>>
> >>>> I don't have the list on hand.
> >>>> Do you have some feature in mind that must be transferred in
> control.sh?
> >>>>
> >>>> I don't find any mentions of visorcmd on user list and in user chats
> so
> >> my
> >>>> guess is - this utility is not used by the users in any way.
> >>>> Do you have some other inputs?
> >>>>
> >>>> If yes, don't hesitate to create a ticket with the IEP-94 label.
> >>>>
> >>>>
> >>>> чт, 1 дек. 2022 г. в 19:11, Вячеслав Коптилин <
> slava.koptilin@gmail.com
> >>> :
> >>>>> Hi Igniters,
> >>>>>
> >>>>> I fully support the idea to stop supporting Visor and removing its
> >>>>> implementation.
> >>>>> However, do we have a list of useful features that do not exist in
> our
> >>>>> control utility?
> >>>>> Perhaps, it makes sense to reimplement such functionality and provide
> >> it
> >>>>> based on control.sh script.
> >>>>>
> >>>>> Thanks,
> >>>>> Slava.
> >>>>>
> >>>>> чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov<ni...@apache.org>:
> >>>>>
> >>>>>> PR is ready for review -https://github.com/apache/ignite/pull/10411
> >>>>>>
> >>>>>> чт, 1 дек. 2022 г. в 16:49, Taras Ledkov<tl...@apache.org>:
> >>>>>>
> >>>>>>> Hi,
> >>>>>>>
> >>>>>>> +1 for remove Visor related code.
> >>>>>>> Unfortunately we have to migrate `control-utility` to use
> >>>> IgniteClient
> >>>>>>> (thin client) before drop GridClient. I guess we will do it in the
> >>>>>> future.
> >>>>>>> Also, the old thin JDBC based on the GridClient (classes placed at
> >>>> the
> >>>>>>> org.apache.ignite.internal.jdbc.*) must be removed.
> >>>>>>>
> >>>
> >>> --
> >>> Best regards,
> >>> Andrey V. Mashenkov
> >>

Re: [DISCUSSION] Removal of ignitevisorcmd

Posted by 18624049226 <18...@163.com>.
Visor has a 'cache -clear' function, this function is very useful, 
especially in some O&M scenarios.

Because Ignite does not support the TRUNCATE command, it is necessary to 
provide a high-performance clear table data command.

在 2022/12/2 19:13, Nikolay Izhikov 写道:
> THanks, Slava, Stephen.
>
> Ticket to reimplement cache scan created -
> https://issues.apache.org/jira/browse/IGNITE-18320
>
> пт, 2 дек. 2022 г. в 13:30, Stephen Darlington <
> stephen.darlington@gridgain.com>:
>
>> One option that’s in Visor but not control.sh is the ability to view cache
>> content (cache -scan). I do hear of people using that.
>>
>>> On 2 Dec 2022, at 09:17, Andrey Mashenkov<an...@gmail.com>
>> wrote:
>>> Hi Igniters,
>>>
>>> I agree with Slava, we have to provide alternative ways for users before
>>> dropping a feature that just worked.
>>> A user may use some feature for a long time without any issues, so, this
>> is
>>> why there is no mention in chats/mails.
>>> I mean here, the feature is not only the whole visor command, but a
>> command
>>> option that just makes UX better.
>>>
>>> I think we can revise visor features, which are not supported by
>>> control.sh, and create an umbrella ticket for supporting in control.sh.
>>> Set this ticket either as 'required' for a 'dropping visor ticket', or
>> as a
>>> blocker for the next release if visor dropping will come first.
>>>
>>> On Fri, Dec 2, 2022 at 11:09 AM Nikolay Izhikov<ni...@apache.org>
>> wrote:
>>>> Hello, Slava.
>>>>
>>>>> However, do we have a list of useful features that do not exist in our
>>>> control utility?
>>>>
>>>> I don't have the list on hand.
>>>> Do you have some feature in mind that must be transferred in control.sh?
>>>>
>>>> I don't find any mentions of visorcmd on user list and in user chats so
>> my
>>>> guess is - this utility is not used by the users in any way.
>>>> Do you have some other inputs?
>>>>
>>>> If yes, don't hesitate to create a ticket with the IEP-94 label.
>>>>
>>>>
>>>> чт, 1 дек. 2022 г. в 19:11, Вячеслав Коптилин <slava.koptilin@gmail.com
>>> :
>>>>> Hi Igniters,
>>>>>
>>>>> I fully support the idea to stop supporting Visor and removing its
>>>>> implementation.
>>>>> However, do we have a list of useful features that do not exist in our
>>>>> control utility?
>>>>> Perhaps, it makes sense to reimplement such functionality and provide
>> it
>>>>> based on control.sh script.
>>>>>
>>>>> Thanks,
>>>>> Slava.
>>>>>
>>>>> чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov<ni...@apache.org>:
>>>>>
>>>>>> PR is ready for review -https://github.com/apache/ignite/pull/10411
>>>>>>
>>>>>> чт, 1 дек. 2022 г. в 16:49, Taras Ledkov<tl...@apache.org>:
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> +1 for remove Visor related code.
>>>>>>> Unfortunately we have to migrate `control-utility` to use
>>>> IgniteClient
>>>>>>> (thin client) before drop GridClient. I guess we will do it in the
>>>>>> future.
>>>>>>> Also, the old thin JDBC based on the GridClient (classes placed at
>>>> the
>>>>>>> org.apache.ignite.internal.jdbc.*) must be removed.
>>>>>>>
>>>
>>> --
>>> Best regards,
>>> Andrey V. Mashenkov
>>

Re: [DISCUSSION] Removal of ignitevisorcmd

Posted by Nikolay Izhikov <ni...@apache.org>.
THanks, Slava, Stephen.

Ticket to reimplement cache scan created -
https://issues.apache.org/jira/browse/IGNITE-18320

пт, 2 дек. 2022 г. в 13:30, Stephen Darlington <
stephen.darlington@gridgain.com>:

> One option that’s in Visor but not control.sh is the ability to view cache
> content (cache -scan). I do hear of people using that.
>
> > On 2 Dec 2022, at 09:17, Andrey Mashenkov <an...@gmail.com>
> wrote:
> >
> > Hi Igniters,
> >
> > I agree with Slava, we have to provide alternative ways for users before
> > dropping a feature that just worked.
> > A user may use some feature for a long time without any issues, so, this
> is
> > why there is no mention in chats/mails.
> > I mean here, the feature is not only the whole visor command, but a
> command
> > option that just makes UX better.
> >
> > I think we can revise visor features, which are not supported by
> > control.sh, and create an umbrella ticket for supporting in control.sh.
> > Set this ticket either as 'required' for a 'dropping visor ticket', or
> as a
> > blocker for the next release if visor dropping will come first.
> >
> > On Fri, Dec 2, 2022 at 11:09 AM Nikolay Izhikov <ni...@apache.org>
> wrote:
> >
> >> Hello, Slava.
> >>
> >>> However, do we have a list of useful features that do not exist in our
> >> control utility?
> >>
> >> I don't have the list on hand.
> >> Do you have some feature in mind that must be transferred in control.sh?
> >>
> >> I don't find any mentions of visorcmd on user list and in user chats so
> my
> >> guess is - this utility is not used by the users in any way.
> >> Do you have some other inputs?
> >>
> >> If yes, don't hesitate to create a ticket with the IEP-94 label.
> >>
> >>
> >> чт, 1 дек. 2022 г. в 19:11, Вячеслав Коптилин <slava.koptilin@gmail.com
> >:
> >>
> >>> Hi Igniters,
> >>>
> >>> I fully support the idea to stop supporting Visor and removing its
> >>> implementation.
> >>> However, do we have a list of useful features that do not exist in our
> >>> control utility?
> >>> Perhaps, it makes sense to reimplement such functionality and provide
> it
> >>> based on control.sh script.
> >>>
> >>> Thanks,
> >>> Slava.
> >>>
> >>> чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov <ni...@apache.org>:
> >>>
> >>>> PR is ready for review - https://github.com/apache/ignite/pull/10411
> >>>>
> >>>> чт, 1 дек. 2022 г. в 16:49, Taras Ledkov <tl...@apache.org>:
> >>>>
> >>>>> Hi,
> >>>>>
> >>>>> +1 for remove Visor related code.
> >>>>> Unfortunately we have to migrate `control-utility` to use
> >> IgniteClient
> >>>>> (thin client) before drop GridClient. I guess we will do it in the
> >>>> future.
> >>>>>
> >>>>> Also, the old thin JDBC based on the GridClient (classes placed at
> >> the
> >>>>> org.apache.ignite.internal.jdbc.*) must be removed.
> >>>>>
> >>>>
> >>>
> >>
> >
> >
> > --
> > Best regards,
> > Andrey V. Mashenkov
>
>

Re: [DISCUSSION] Removal of ignitevisorcmd

Posted by Stephen Darlington <st...@gridgain.com>.
One option that’s in Visor but not control.sh is the ability to view cache content (cache -scan). I do hear of people using that.

> On 2 Dec 2022, at 09:17, Andrey Mashenkov <an...@gmail.com> wrote:
> 
> Hi Igniters,
> 
> I agree with Slava, we have to provide alternative ways for users before
> dropping a feature that just worked.
> A user may use some feature for a long time without any issues, so, this is
> why there is no mention in chats/mails.
> I mean here, the feature is not only the whole visor command, but a command
> option that just makes UX better.
> 
> I think we can revise visor features, which are not supported by
> control.sh, and create an umbrella ticket for supporting in control.sh.
> Set this ticket either as 'required' for a 'dropping visor ticket', or as a
> blocker for the next release if visor dropping will come first.
> 
> On Fri, Dec 2, 2022 at 11:09 AM Nikolay Izhikov <ni...@apache.org> wrote:
> 
>> Hello, Slava.
>> 
>>> However, do we have a list of useful features that do not exist in our
>> control utility?
>> 
>> I don't have the list on hand.
>> Do you have some feature in mind that must be transferred in control.sh?
>> 
>> I don't find any mentions of visorcmd on user list and in user chats so my
>> guess is - this utility is not used by the users in any way.
>> Do you have some other inputs?
>> 
>> If yes, don't hesitate to create a ticket with the IEP-94 label.
>> 
>> 
>> чт, 1 дек. 2022 г. в 19:11, Вячеслав Коптилин <sl...@gmail.com>:
>> 
>>> Hi Igniters,
>>> 
>>> I fully support the idea to stop supporting Visor and removing its
>>> implementation.
>>> However, do we have a list of useful features that do not exist in our
>>> control utility?
>>> Perhaps, it makes sense to reimplement such functionality and provide it
>>> based on control.sh script.
>>> 
>>> Thanks,
>>> Slava.
>>> 
>>> чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov <ni...@apache.org>:
>>> 
>>>> PR is ready for review - https://github.com/apache/ignite/pull/10411
>>>> 
>>>> чт, 1 дек. 2022 г. в 16:49, Taras Ledkov <tl...@apache.org>:
>>>> 
>>>>> Hi,
>>>>> 
>>>>> +1 for remove Visor related code.
>>>>> Unfortunately we have to migrate `control-utility` to use
>> IgniteClient
>>>>> (thin client) before drop GridClient. I guess we will do it in the
>>>> future.
>>>>> 
>>>>> Also, the old thin JDBC based on the GridClient (classes placed at
>> the
>>>>> org.apache.ignite.internal.jdbc.*) must be removed.
>>>>> 
>>>> 
>>> 
>> 
> 
> 
> -- 
> Best regards,
> Andrey V. Mashenkov


Re: [DISCUSSION] Removal of ignitevisorcmd

Posted by Andrey Mashenkov <an...@gmail.com>.
Hi Igniters,

I agree with Slava, we have to provide alternative ways for users before
dropping a feature that just worked.
A user may use some feature for a long time without any issues, so, this is
why there is no mention in chats/mails.
I mean here, the feature is not only the whole visor command, but a command
option that just makes UX better.

I think we can revise visor features, which are not supported by
control.sh, and create an umbrella ticket for supporting in control.sh.
Set this ticket either as 'required' for a 'dropping visor ticket', or as a
blocker for the next release if visor dropping will come first.

On Fri, Dec 2, 2022 at 11:09 AM Nikolay Izhikov <ni...@apache.org> wrote:

> Hello, Slava.
>
> > However, do we have a list of useful features that do not exist in our
> control utility?
>
> I don't have the list on hand.
> Do you have some feature in mind that must be transferred in control.sh?
>
> I don't find any mentions of visorcmd on user list and in user chats so my
> guess is - this utility is not used by the users in any way.
> Do you have some other inputs?
>
> If yes, don't hesitate to create a ticket with the IEP-94 label.
>
>
> чт, 1 дек. 2022 г. в 19:11, Вячеслав Коптилин <sl...@gmail.com>:
>
> > Hi Igniters,
> >
> > I fully support the idea to stop supporting Visor and removing its
> > implementation.
> > However, do we have a list of useful features that do not exist in our
> > control utility?
> > Perhaps, it makes sense to reimplement such functionality and provide it
> > based on control.sh script.
> >
> > Thanks,
> > Slava.
> >
> > чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov <ni...@apache.org>:
> >
> > > PR is ready for review - https://github.com/apache/ignite/pull/10411
> > >
> > > чт, 1 дек. 2022 г. в 16:49, Taras Ledkov <tl...@apache.org>:
> > >
> > > > Hi,
> > > >
> > > > +1 for remove Visor related code.
> > > > Unfortunately we have to migrate `control-utility` to use
> IgniteClient
> > > > (thin client) before drop GridClient. I guess we will do it in the
> > > future.
> > > >
> > > > Also, the old thin JDBC based on the GridClient (classes placed at
> the
> > > > org.apache.ignite.internal.jdbc.*) must be removed.
> > > >
> > >
> >
>


-- 
Best regards,
Andrey V. Mashenkov

Re: [DISCUSSION] Removal of ignitevisorcmd

Posted by Nikolay Izhikov <ni...@apache.org>.
Hello, Slava.

> However, do we have a list of useful features that do not exist in our
control utility?

I don't have the list on hand.
Do you have some feature in mind that must be transferred in control.sh?

I don't find any mentions of visorcmd on user list and in user chats so my
guess is - this utility is not used by the users in any way.
Do you have some other inputs?

If yes, don't hesitate to create a ticket with the IEP-94 label.


чт, 1 дек. 2022 г. в 19:11, Вячеслав Коптилин <sl...@gmail.com>:

> Hi Igniters,
>
> I fully support the idea to stop supporting Visor and removing its
> implementation.
> However, do we have a list of useful features that do not exist in our
> control utility?
> Perhaps, it makes sense to reimplement such functionality and provide it
> based on control.sh script.
>
> Thanks,
> Slava.
>
> чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov <ni...@apache.org>:
>
> > PR is ready for review - https://github.com/apache/ignite/pull/10411
> >
> > чт, 1 дек. 2022 г. в 16:49, Taras Ledkov <tl...@apache.org>:
> >
> > > Hi,
> > >
> > > +1 for remove Visor related code.
> > > Unfortunately we have to migrate `control-utility` to use IgniteClient
> > > (thin client) before drop GridClient. I guess we will do it in the
> > future.
> > >
> > > Also, the old thin JDBC based on the GridClient (classes placed at the
> > > org.apache.ignite.internal.jdbc.*) must be removed.
> > >
> >
>

Re: [DISCUSSION] Removal of ignitevisorcmd

Posted by Вячеслав Коптилин <sl...@gmail.com>.
Hi Igniters,

I fully support the idea to stop supporting Visor and removing its
implementation.
However, do we have a list of useful features that do not exist in our
control utility?
Perhaps, it makes sense to reimplement such functionality and provide it
based on control.sh script.

Thanks,
Slava.

чт, 1 дек. 2022 г. в 15:51, Nikolay Izhikov <ni...@apache.org>:

> PR is ready for review - https://github.com/apache/ignite/pull/10411
>
> чт, 1 дек. 2022 г. в 16:49, Taras Ledkov <tl...@apache.org>:
>
> > Hi,
> >
> > +1 for remove Visor related code.
> > Unfortunately we have to migrate `control-utility` to use IgniteClient
> > (thin client) before drop GridClient. I guess we will do it in the
> future.
> >
> > Also, the old thin JDBC based on the GridClient (classes placed at the
> > org.apache.ignite.internal.jdbc.*) must be removed.
> >
>

Re: [DISCUSSION] Removal of ignitevisorcmd

Posted by Nikolay Izhikov <ni...@apache.org>.
PR is ready for review - https://github.com/apache/ignite/pull/10411

чт, 1 дек. 2022 г. в 16:49, Taras Ledkov <tl...@apache.org>:

> Hi,
>
> +1 for remove Visor related code.
> Unfortunately we have to migrate `control-utility` to use IgniteClient
> (thin client) before drop GridClient. I guess we will do it in the future.
>
> Also, the old thin JDBC based on the GridClient (classes placed at the
> org.apache.ignite.internal.jdbc.*) must be removed.
>