You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by le...@apache.org on 2024/03/26 21:14:28 UTC
(datasketches-java) branch fix_imports_and_finals created (now 12579521)
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a change to branch fix_imports_and_finals
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
at 12579521 Fix out-of-order imports and missing finals in PR 533.
This branch includes the following new commits:
new 12579521 Fix out-of-order imports and missing finals in PR 533.
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
(datasketches-java) 01/01: Fix out-of-order imports and missing finals in PR 533.
Posted by le...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
leerho pushed a commit to branch fix_imports_and_finals
in repository https://gitbox.apache.org/repos/asf/datasketches-java.git
commit 12579521559bce179f90cbbcc8c084d7ab1790c0
Author: Lee Rhodes <le...@users.noreply.github.com>
AuthorDate: Tue Mar 26 14:14:15 2024 -0700
Fix out-of-order imports and missing finals in PR 533.
Alan was not aware of these Checkstyle rules.
Not a big deal, they are easy to fix.
---
src/main/java/org/apache/datasketches/theta/Union.java | 4 ++--
src/main/java/org/apache/datasketches/theta/UnionImpl.java | 6 +++---
src/main/java/org/apache/datasketches/theta/UpdateSketch.java | 2 +-
src/main/java/org/apache/datasketches/tuple/UpdatableSketch.java | 4 ++--
.../tuple/arrayofdoubles/ArrayOfDoublesUpdatableSketch.java | 4 ++--
src/test/java/org/apache/datasketches/theta/UpdateSketchTest.java | 6 ++----
.../java/org/apache/datasketches/tuple/adouble/AdoubleTest.java | 7 +++----
.../arrayofdoubles/DirectArrayOfDoublesQuickSelectSketchTest.java | 6 ++----
8 files changed, 17 insertions(+), 22 deletions(-)
diff --git a/src/main/java/org/apache/datasketches/theta/Union.java b/src/main/java/org/apache/datasketches/theta/Union.java
index 96ea6d27..7a2ff9c5 100644
--- a/src/main/java/org/apache/datasketches/theta/Union.java
+++ b/src/main/java/org/apache/datasketches/theta/Union.java
@@ -19,12 +19,12 @@
package org.apache.datasketches.theta;
+import java.nio.ByteBuffer;
+
import org.apache.datasketches.common.Family;
import org.apache.datasketches.memory.Memory;
import org.apache.datasketches.memory.WritableMemory;
-import java.nio.ByteBuffer;
-
/**
* Compute the union of two or more theta sketches.
* A new instance represents an empty set.
diff --git a/src/main/java/org/apache/datasketches/theta/UnionImpl.java b/src/main/java/org/apache/datasketches/theta/UnionImpl.java
index 8516ec01..3ea5ca55 100644
--- a/src/main/java/org/apache/datasketches/theta/UnionImpl.java
+++ b/src/main/java/org/apache/datasketches/theta/UnionImpl.java
@@ -38,6 +38,8 @@ import static org.apache.datasketches.theta.PreambleUtil.insertUnionThetaLong;
import static org.apache.datasketches.theta.SingleItemSketch.otherCheckForSingleItem;
import static org.apache.datasketches.thetacommon.QuickSelect.selectExcludingZeros;
+import java.nio.ByteBuffer;
+
import org.apache.datasketches.common.Family;
import org.apache.datasketches.common.ResizeFactor;
import org.apache.datasketches.common.SketchesArgumentException;
@@ -47,8 +49,6 @@ import org.apache.datasketches.memory.WritableMemory;
import org.apache.datasketches.thetacommon.HashOperations;
import org.apache.datasketches.thetacommon.ThetaUtil;
-import java.nio.ByteBuffer;
-
/**
* Shared code for the HeapUnion and DirectUnion implementations.
*
@@ -483,7 +483,7 @@ final class UnionImpl extends Union {
}
@Override
- public void update(ByteBuffer data) {
+ public void update(final ByteBuffer data) {
gadget_.update(data);
}
diff --git a/src/main/java/org/apache/datasketches/theta/UpdateSketch.java b/src/main/java/org/apache/datasketches/theta/UpdateSketch.java
index 02fb599d..882c5e2e 100644
--- a/src/main/java/org/apache/datasketches/theta/UpdateSketch.java
+++ b/src/main/java/org/apache/datasketches/theta/UpdateSketch.java
@@ -284,7 +284,7 @@ public abstract class UpdateSketch extends Sketch {
* @return
* <a href="{@docRoot}/resources/dictionary.html#updateReturnState">See Update Return State</a>
*/
- public UpdateReturnState update(ByteBuffer buffer) {
+ public UpdateReturnState update(final ByteBuffer buffer) {
if (buffer == null || buffer.hasRemaining() == false) {
return RejectedNullOrEmpty;
}
diff --git a/src/main/java/org/apache/datasketches/tuple/UpdatableSketch.java b/src/main/java/org/apache/datasketches/tuple/UpdatableSketch.java
index 6a386661..36743618 100644
--- a/src/main/java/org/apache/datasketches/tuple/UpdatableSketch.java
+++ b/src/main/java/org/apache/datasketches/tuple/UpdatableSketch.java
@@ -19,12 +19,12 @@
package org.apache.datasketches.tuple;
+import java.nio.ByteBuffer;
+
import org.apache.datasketches.hash.MurmurHash3;
import org.apache.datasketches.memory.Memory;
import org.apache.datasketches.thetacommon.ThetaUtil;
-import java.nio.ByteBuffer;
-
/**
* An extension of QuickSelectSketch<S>, which can be updated with many types of keys.
* Summary objects are created using a user-defined SummaryFactory class,
diff --git a/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesUpdatableSketch.java b/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesUpdatableSketch.java
index 4febb117..cd3c1d2e 100644
--- a/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesUpdatableSketch.java
+++ b/src/main/java/org/apache/datasketches/tuple/arrayofdoubles/ArrayOfDoublesUpdatableSketch.java
@@ -19,6 +19,8 @@
package org.apache.datasketches.tuple.arrayofdoubles;
+import java.nio.ByteBuffer;
+
import org.apache.datasketches.common.ResizeFactor;
import org.apache.datasketches.hash.MurmurHash3;
import org.apache.datasketches.memory.Memory;
@@ -26,8 +28,6 @@ import org.apache.datasketches.memory.WritableMemory;
import org.apache.datasketches.thetacommon.ThetaUtil;
import org.apache.datasketches.tuple.Util;
-import java.nio.ByteBuffer;
-
/**
* The top level for updatable tuple sketches of type ArrayOfDoubles.
*/
diff --git a/src/test/java/org/apache/datasketches/theta/UpdateSketchTest.java b/src/test/java/org/apache/datasketches/theta/UpdateSketchTest.java
index 331d6e22..76f4707a 100644
--- a/src/test/java/org/apache/datasketches/theta/UpdateSketchTest.java
+++ b/src/test/java/org/apache/datasketches/theta/UpdateSketchTest.java
@@ -30,19 +30,17 @@ import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertTrue;
import static org.testng.Assert.fail;
+import java.nio.ByteBuffer;
+
import org.apache.datasketches.common.Family;
import org.apache.datasketches.common.ResizeFactor;
import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.memory.DefaultMemoryRequestServer;
-import org.apache.datasketches.memory.Memory;
import org.apache.datasketches.memory.MemoryRequestServer;
import org.apache.datasketches.memory.WritableMemory;
import org.apache.datasketches.thetacommon.ThetaUtil;
import org.testng.annotations.Test;
-import java.nio.ByteBuffer;
-import java.nio.ByteOrder;
-
/**
* @author Lee Rhodes
*/
diff --git a/src/test/java/org/apache/datasketches/tuple/adouble/AdoubleTest.java b/src/test/java/org/apache/datasketches/tuple/adouble/AdoubleTest.java
index a853b6da..a1cfc1a7 100644
--- a/src/test/java/org/apache/datasketches/tuple/adouble/AdoubleTest.java
+++ b/src/test/java/org/apache/datasketches/tuple/adouble/AdoubleTest.java
@@ -21,21 +21,20 @@ package org.apache.datasketches.tuple.adouble;
import static org.testng.Assert.assertEquals;
+import java.nio.ByteBuffer;
+
import org.apache.datasketches.common.ResizeFactor;
import org.apache.datasketches.common.SketchesArgumentException;
import org.apache.datasketches.memory.Memory;
import org.apache.datasketches.tuple.Sketch;
-import org.apache.datasketches.tuple.TupleSketchIterator;
import org.apache.datasketches.tuple.Sketches;
+import org.apache.datasketches.tuple.TupleSketchIterator;
import org.apache.datasketches.tuple.UpdatableSketch;
import org.apache.datasketches.tuple.UpdatableSketchBuilder;
import org.apache.datasketches.tuple.adouble.DoubleSummary.Mode;
import org.testng.Assert;
import org.testng.annotations.Test;
-import java.nio.ByteBuffer;
-import java.nio.ByteOrder;
-
public class AdoubleTest {
private final DoubleSummary.Mode mode = Mode.Sum;
diff --git a/src/test/java/org/apache/datasketches/tuple/arrayofdoubles/DirectArrayOfDoublesQuickSelectSketchTest.java b/src/test/java/org/apache/datasketches/tuple/arrayofdoubles/DirectArrayOfDoublesQuickSelectSketchTest.java
index dfb0c1fd..a8e066f4 100644
--- a/src/test/java/org/apache/datasketches/tuple/arrayofdoubles/DirectArrayOfDoublesQuickSelectSketchTest.java
+++ b/src/test/java/org/apache/datasketches/tuple/arrayofdoubles/DirectArrayOfDoublesQuickSelectSketchTest.java
@@ -19,16 +19,14 @@
package org.apache.datasketches.tuple.arrayofdoubles;
+import java.nio.ByteBuffer;
+
import org.apache.datasketches.common.ResizeFactor;
import org.apache.datasketches.common.SketchesArgumentException;
-import org.apache.datasketches.memory.Memory;
import org.apache.datasketches.memory.WritableMemory;
import org.testng.Assert;
import org.testng.annotations.Test;
-import java.nio.ByteBuffer;
-import java.nio.ByteOrder;
-
public class DirectArrayOfDoublesQuickSelectSketchTest {
@Test
public void isEmpty() {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org