You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/07 01:57:10 UTC
[GitHub] [spark] sunchao commented on a change in pull request #33912: [SPARK-36670][SPARK-36669][CORE][SQL] Add LZ4 hadoop wrapper and FileSourceCodecSuite
sunchao commented on a change in pull request #33912:
URL: https://github.com/apache/spark/pull/33912#discussion_r703125181
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources
+
+import org.apache.spark.sql.QueryTest
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.test.{SharedSparkSession, SQLTestUtils}
+
+trait FileSourceCodecSuite extends QueryTest with SQLTestUtils {
+
+ protected def format: String
+ protected val codecConfigName: String
+ protected def availableCodecs: Seq[String]
+
+ def testWithAllCodecs(name: String)(f: => Unit): Unit = {
+ for (codec <- availableCodecs) {
+ test(s"$name - file source $format - codec: $codec") {
+ withSQLConf(codecConfigName -> codec) {
+ f
+ }
+ }
+ }
+ }
+
+ testWithAllCodecs("write and read") {
+ withTempPath { dir =>
+ testData
+ .repartition(5)
+ .write
+ .format(format)
+ .save(dir.getCanonicalPath)
+
+ val df = spark.read.format(format).load(dir.getCanonicalPath)
+ checkAnswer(df, testData)
+ }
+ }
+}
+
+class ParquetCodecSuite extends FileSourceCodecSuite with SharedSparkSession {
+
+ override def format: String = "parquet"
+ override val codecConfigName = SQLConf.PARQUET_COMPRESSION.key
+ // Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
+ override protected def availableCodecs: Seq[String] = Seq("none", "uncompressed", "snappy",
+ "gzip", "brotli", "zstd", "lz4")
+}
+
+class OrcCodecSuite extends FileSourceCodecSuite with SharedSparkSession{
+
+ override def format: String = "orc"
+ override val codecConfigName = SQLConf.ORC_COMPRESSION.key
Review comment:
nit: add type annotation for public member?
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources
+
+import org.apache.spark.sql.QueryTest
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.test.{SharedSparkSession, SQLTestUtils}
+
+trait FileSourceCodecSuite extends QueryTest with SQLTestUtils {
+
+ protected def format: String
+ protected val codecConfigName: String
+ protected def availableCodecs: Seq[String]
+
+ def testWithAllCodecs(name: String)(f: => Unit): Unit = {
+ for (codec <- availableCodecs) {
+ test(s"$name - file source $format - codec: $codec") {
+ withSQLConf(codecConfigName -> codec) {
+ f
+ }
+ }
+ }
+ }
+
+ testWithAllCodecs("write and read") {
+ withTempPath { dir =>
+ testData
+ .repartition(5)
+ .write
+ .format(format)
+ .save(dir.getCanonicalPath)
+
+ val df = spark.read.format(format).load(dir.getCanonicalPath)
+ checkAnswer(df, testData)
+ }
+ }
+}
+
+class ParquetCodecSuite extends FileSourceCodecSuite with SharedSparkSession {
+
+ override def format: String = "parquet"
+ override val codecConfigName = SQLConf.PARQUET_COMPRESSION.key
+ // Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
+ override protected def availableCodecs: Seq[String] = Seq("none", "uncompressed", "snappy",
+ "gzip", "brotli", "zstd", "lz4")
+}
+
+class OrcCodecSuite extends FileSourceCodecSuite with SharedSparkSession{
Review comment:
nit: space before `{`
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources
+
+import org.apache.spark.sql.QueryTest
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.test.{SharedSparkSession, SQLTestUtils}
+
+trait FileSourceCodecSuite extends QueryTest with SQLTestUtils {
+
+ protected def dataSourceName: String
+ protected val codecConfigName: String
+ protected def availableCodecs: Seq[String]
+
+ def testWithAllCodecs(name: String)(f: => Unit): Unit = {
+ for (codec <- availableCodecs) {
+ test(s"$name - data source $dataSourceName - codec: $codec") {
+ withSQLConf(codecConfigName -> codec) {
+ f
+ }
+ }
+ }
+ }
+
+ testWithAllCodecs("write and read") {
+ withTempPath { dir =>
+ testData
+ .repartition(5)
+ .write
+ .format(dataSourceName)
+ .save(dir.getCanonicalPath)
+
+ val df = spark.read.format(dataSourceName).load(dir.getCanonicalPath)
+ checkAnswer(df, testData)
+ }
+ }
+}
+
+class ParquetCodecSuite extends FileSourceCodecSuite with SharedSparkSession {
+
+ override def dataSourceName: String = "parquet"
+ override val codecConfigName = SQLConf.PARQUET_COMPRESSION.key
+ // Exclude "lzo" because it is GPL-licenced so not included in Hadoop.
+ override protected def availableCodecs: Seq[String] = Seq("none", "uncompressed", "snappy",
Review comment:
Since Hadoop don't have GZIP compressor yet, the test will just fallback to use uncompressed?
Also it seems brotli-codec will fail on non-x86_64 architecture: https://issues.apache.org/jira/browse/PARQUET-1975
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceCodecSuite.scala
##########
@@ -0,0 +1,69 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources
+
+import org.apache.spark.sql.QueryTest
+import org.apache.spark.sql.internal.SQLConf
+import org.apache.spark.sql.test.{SharedSparkSession, SQLTestUtils}
+
+trait FileSourceCodecSuite extends QueryTest with SQLTestUtils {
+
+ protected def format: String
+ protected val codecConfigName: String
+ protected def availableCodecs: Seq[String]
+
+ def testWithAllCodecs(name: String)(f: => Unit): Unit = {
+ for (codec <- availableCodecs) {
+ test(s"$name - file source $format - codec: $codec") {
+ withSQLConf(codecConfigName -> codec) {
+ f
+ }
+ }
+ }
+ }
+
+ testWithAllCodecs("write and read") {
+ withTempPath { dir =>
+ testData
+ .repartition(5)
+ .write
+ .format(format)
+ .save(dir.getCanonicalPath)
+
+ val df = spark.read.format(format).load(dir.getCanonicalPath)
+ checkAnswer(df, testData)
+ }
+ }
+}
+
+class ParquetCodecSuite extends FileSourceCodecSuite with SharedSparkSession {
+
+ override def format: String = "parquet"
+ override val codecConfigName = SQLConf.PARQUET_COMPRESSION.key
Review comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org