You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2022/06/13 09:06:23 UTC

[GitHub] [calcite] danny0405 commented on a diff in pull request #2831: [CALCITE-5177] Query loses hint after decorrelation (minor follow-up)

danny0405 commented on code in PR #2831:
URL: https://github.com/apache/calcite/pull/2831#discussion_r895493970


##########
core/src/main/java/org/apache/calcite/plan/RelOptUtil.java:
##########
@@ -475,6 +475,10 @@ public static RelNode copyRelHints(RelNode originalRel, RelNode newRel) {
    * or {@code newRel} directly if one of them are not {@link Hintable}
    */
   public static RelNode copyRelHints(RelNode originalRel, RelNode newRel, boolean filterHints) {
+    if (originalRel == newRel && !filterHints) {
+      return originalRel;

Review Comment:
   Do we need to make decision for `filterHints` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org