You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "ruanhang1993 (via GitHub)" <gi...@apache.org> on 2026/03/19 03:41:08 UTC

Re: [PR] [FLINK-39071][oracle-cdc] Fix Oracle pipeline connector wrong field case [flink-cdc]

ruanhang1993 commented on code in PR #4292:
URL: https://github.com/apache/flink-cdc/pull/4292#discussion_r2957667502


##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-oracle/src/main/java/org/apache/flink/cdc/connectors/oracle/utils/OracleSchemaUtils.java:
##########
@@ -158,7 +158,7 @@ public static Schema getSchema(
             DataType dataType = OracleTypeUtils.fromDbzColumn(column);
             org.apache.flink.cdc.common.schema.Column cdcColumn =
                     org.apache.flink.cdc.common.schema.Column.physicalColumn(
-                            column.name().toLowerCase(Locale.ROOT), dataType);
+                            column.name(), dataType);

Review Comment:
   Removing the lowercase conversion may introduce an incompatibility. Should this be controlled by a configuration option for backward compatibility?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org