You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "Sergey Vladimirov (JIRA)" <xa...@xml.apache.org> on 2006/08/11 13:48:14 UTC
[jira] Created: (XALANJ-2313) XSLTC must reports about fatal error
if can't compile
XSLTC must reports about fatal error if can't compile
-----------------------------------------------------
Key: XALANJ-2313
URL: http://issues.apache.org/jira/browse/XALANJ-2313
Project: XalanJ2
Issue Type: Bug
Components: XSLTC
Affects Versions: 2.7
Reporter: Sergey Vladimirov
XSLTC must reports about fatal error when can't compile code, not recoverable error:
// Check that the transformation went well before returning
if (bytecodes == null) {
ErrorMsg err = new ErrorMsg(ErrorMsg.JAXP_COMPILE_ERR);
TransformerConfigurationException exc = new TransformerConfigurationException(err.toString());
// Pass compiler errors to the error listener
if (_errorListener != null) {
passErrorsToListener(xsltc.getErrors());
Here should be passFatalErrorToListener or something.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2313) XSLTC must reports about fatal
error if can't compile
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2313?page=comments#action_12443404 ]
Brian Minchau commented on XALANJ-2313:
---------------------------------------
Sergey, I think you are right. We may not currently report an error or throw an exception when XSLTC can't compile a stylesheet, but pretty soon that null bytecodes has to get you.
I agree this could have a better error, closer to the source of the problem.
> XSLTC must reports about fatal error if can't compile
> -----------------------------------------------------
>
> Key: XALANJ-2313
> URL: http://issues.apache.org/jira/browse/XALANJ-2313
> Project: XalanJ2
> Issue Type: Bug
> Components: XSLTC
> Affects Versions: 2.7
> Reporter: Sergey Vladimirov
> Attachments: patch.txt
>
>
> XSLTC must reports about fatal error when can't compile code, not recoverable error:
> // Check that the transformation went well before returning
> if (bytecodes == null) {
>
> ErrorMsg err = new ErrorMsg(ErrorMsg.JAXP_COMPILE_ERR);
> TransformerConfigurationException exc = new TransformerConfigurationException(err.toString());
>
> // Pass compiler errors to the error listener
> if (_errorListener != null) {
> passErrorsToListener(xsltc.getErrors());
> Here should be passFatalErrorToListener or something.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2313) XSLTC must reports about fatal
error if can't compile
Posted by "Sergey Vladimirov (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2313?page=comments#action_12443031 ]
Sergey Vladimirov commented on XALANJ-2313:
-------------------------------------------
There is one issue: XSLT will still throw fatal error later. But this error message will not contain enought information, as source one.
> XSLTC must reports about fatal error if can't compile
> -----------------------------------------------------
>
> Key: XALANJ-2313
> URL: http://issues.apache.org/jira/browse/XALANJ-2313
> Project: XalanJ2
> Issue Type: Bug
> Components: XSLTC
> Affects Versions: 2.7
> Reporter: Sergey Vladimirov
> Attachments: patch.txt
>
>
> XSLTC must reports about fatal error when can't compile code, not recoverable error:
> // Check that the transformation went well before returning
> if (bytecodes == null) {
>
> ErrorMsg err = new ErrorMsg(ErrorMsg.JAXP_COMPILE_ERR);
> TransformerConfigurationException exc = new TransformerConfigurationException(err.toString());
>
> // Pass compiler errors to the error listener
> if (_errorListener != null) {
> passErrorsToListener(xsltc.getErrors());
> Here should be passFatalErrorToListener or something.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2313) XSLTC must reports about fatal
error if can't compile
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2313?page=comments#action_12442993 ]
Brian Minchau commented on XALANJ-2313:
---------------------------------------
These comments are from the JIRA triage meeting on Oct 16, 2005:
<<
JAXP 1.3 was ambiguous about whether a processor was supposed to leave error handling to the user installed error handler, but if there was no user error handler then the default error handler was not permitted to throw TransformerConfigurationException-s for errors fatal errors. In JAXP 1.4 things were clarified to say the the default error handler can throw exceptions when a fatal error occurs.
Some concern about whether this will change the behavior and may have backward compatibility issues. Not planning to proceed on this one.
>>
> XSLTC must reports about fatal error if can't compile
> -----------------------------------------------------
>
> Key: XALANJ-2313
> URL: http://issues.apache.org/jira/browse/XALANJ-2313
> Project: XalanJ2
> Issue Type: Bug
> Components: XSLTC
> Affects Versions: 2.7
> Reporter: Sergey Vladimirov
> Attachments: patch.txt
>
>
> XSLTC must reports about fatal error when can't compile code, not recoverable error:
> // Check that the transformation went well before returning
> if (bytecodes == null) {
>
> ErrorMsg err = new ErrorMsg(ErrorMsg.JAXP_COMPILE_ERR);
> TransformerConfigurationException exc = new TransformerConfigurationException(err.toString());
>
> // Pass compiler errors to the error listener
> if (_errorListener != null) {
> passErrorsToListener(xsltc.getErrors());
> Here should be passFatalErrorToListener or something.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org