[GitHub] [iceberg] kbendick edited a comment on pull request #1227: Improve release script to detect archive list automatically

[GitBox <gi...@apache.org>]

kbendick edited a comment on pull request #1227:
URL: https://github.com/apache/iceberg/pull/1227#issuecomment-687572568


   Thank you so much for returning to this @waterlx! My apologies for the delay, my work has been rather busy this past week.
   
   I have concerns about not using quotes when calling `echo`. It's not technically required in all shells, but it's a fairly standard practice (`echo` uses quotes elsewhere in the script). It gives me some slight concerns for portability of the shell script (especially if people are running in containers and using stricter shells). Other than that, it looks great! I have a small nit / suggestion for making the script slightly more readable and to allow for removing hat entire sentence comment on `$adds` (but I'll leave that to your call).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org