You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ilya Berezhniuk (JIRA)" <ji...@apache.org> on 2007/10/30 16:33:50 UTC

[jira] Created: (HARMONY-5045) [drlvm][linux][em64t] Automatic switch to uncompressed mode for large heap

[drlvm][linux][em64t] Automatic switch to uncompressed mode for large heap
--------------------------------------------------------------------------

                 Key: HARMONY-5045
                 URL: https://issues.apache.org/jira/browse/HARMONY-5045
             Project: Harmony
          Issue Type: Sub-task
            Reporter: Ilya Berezhniuk




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5045) [drlvm][init] Automatic switch to uncompressed mode for large heap

Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541414 ] 

Ilya Berezhniuk commented on HARMONY-5045:
------------------------------------------

I agree that using such constant is not good solution; we don't know what actual maximal heap can be allocated by some GC in compressed mode.

I'll change this constant to the value of exactly 4Gb, to provide better diagnostics for evident cases.
Other cases, when requested heap size is less than 4Gb but greater than max GC heap size for compressed mode, will be reported by GC.

> [drlvm][init] Automatic switch to uncompressed mode for large heap
> ------------------------------------------------------------------
>
>                 Key: HARMONY-5045
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5045
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>         Environment: x86_64 Linux/Windows
>            Reporter: Ilya Berezhniuk
>         Attachments: auto_switch.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5045) [drlvm][init] Automatic switch to uncompressed mode for large heap

Posted by "Rana Dasgupta (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541396 ] 

Rana Dasgupta commented on HARMONY-5045:
----------------------------------------

The changes for runtime mod switchable look fine. 

Why is it useful to print an error message and terminate only if the compilation mode is compressed and the heapsize is > XXX?
Even for compilation mode = uncompressed, each OS sets limits on max addressability and so the heapsize has different limits on different OS's.
The max heapsize that works in each mode really depends on OS and java addressability and max memory installed on the machine. This kind of information is better in a tuning guide. It may be OK to let the program crash if the JVM at runtime tries to access more heap than supportable.

Thanks,
Rana


> [drlvm][init] Automatic switch to uncompressed mode for large heap
> ------------------------------------------------------------------
>
>                 Key: HARMONY-5045
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5045
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>         Environment: x86_64 Linux/Windows
>            Reporter: Ilya Berezhniuk
>         Attachments: auto_switch.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HARMONY-5045) [drlvm][init] Automatic switch to uncompressed mode for large heap

Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ilya Berezhniuk closed HARMONY-5045.
------------------------------------


All works fine, closing issue.

> [drlvm][init] Automatic switch to uncompressed mode for large heap
> ------------------------------------------------------------------
>
>                 Key: HARMONY-5045
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5045
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>         Environment: x86_64 Linux/Windows
>            Reporter: Ilya Berezhniuk
>            Assignee: Gregory Shimansky
>         Attachments: auto_switch.patch, auto_switch.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5045) [drlvm][linux][em64t] Automatic switch to uncompressed mode for large heap

Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ilya Berezhniuk updated HARMONY-5045:
-------------------------------------

    Attachment: auto_switch.patch

Here is the patch enabling automatic switching to uncompressed mode when large heap size is specified.
This works for runtime switchable mode of course.
Also when large heap is specified in compile-time compressed mode, VM writes a message and terminates.

! Please do not commit this patch; I did not check it carefully.

> [drlvm][linux][em64t] Automatic switch to uncompressed mode for large heap
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-5045
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5045
>             Project: Harmony
>          Issue Type: Sub-task
>            Reporter: Ilya Berezhniuk
>         Attachments: auto_switch.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5045) [drlvm][init] Automatic switch to uncompressed mode for large heap

Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ilya Berezhniuk updated HARMONY-5045:
-------------------------------------

    Attachment: auto_switch.patch

Attached new version of the patch.

- max. size is changed to 4Gb; added comment
- a comment is added to disabled call to check_compression()

> [drlvm][init] Automatic switch to uncompressed mode for large heap
> ------------------------------------------------------------------
>
>                 Key: HARMONY-5045
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5045
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>         Environment: x86_64 Linux/Windows
>            Reporter: Ilya Berezhniuk
>         Attachments: auto_switch.patch, auto_switch.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HARMONY-5045) [drlvm][init] Automatic switch to uncompressed mode for large heap

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky reassigned HARMONY-5045:
------------------------------------------

    Assignee: Gregory Shimansky

> [drlvm][init] Automatic switch to uncompressed mode for large heap
> ------------------------------------------------------------------
>
>                 Key: HARMONY-5045
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5045
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>         Environment: x86_64 Linux/Windows
>            Reporter: Ilya Berezhniuk
>            Assignee: Gregory Shimansky
>         Attachments: auto_switch.patch, auto_switch.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HARMONY-5045) [drlvm][init] Automatic switch to uncompressed mode for large heap

Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gregory Shimansky resolved HARMONY-5045.
----------------------------------------

    Resolution: Fixed

Patch is applied at 594180.

> [drlvm][init] Automatic switch to uncompressed mode for large heap
> ------------------------------------------------------------------
>
>                 Key: HARMONY-5045
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5045
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>         Environment: x86_64 Linux/Windows
>            Reporter: Ilya Berezhniuk
>            Assignee: Gregory Shimansky
>         Attachments: auto_switch.patch, auto_switch.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5045) [drlvm] Automatic switch to uncompressed mode for large heap

Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ilya Berezhniuk updated HARMONY-5045:
-------------------------------------

    Component/s: DRLVM
    Environment: x86_64 Linux/Windows
        Summary: [drlvm] Automatic switch to uncompressed mode for large heap  (was: [drlvm][linux][em64t] Automatic switch to uncompressed mode for large heap)

> [drlvm] Automatic switch to uncompressed mode for large heap
> ------------------------------------------------------------
>
>                 Key: HARMONY-5045
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5045
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>         Environment: x86_64 Linux/Windows
>            Reporter: Ilya Berezhniuk
>         Attachments: auto_switch.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5045) [drlvm][init] Automatic switch to uncompressed mode for large heap

Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ilya Berezhniuk updated HARMONY-5045:
-------------------------------------

    Patch Info: [Patch Available]

> [drlvm][init] Automatic switch to uncompressed mode for large heap
> ------------------------------------------------------------------
>
>                 Key: HARMONY-5045
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5045
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>         Environment: x86_64 Linux/Windows
>            Reporter: Ilya Berezhniuk
>         Attachments: auto_switch.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HARMONY-5045) [drlvm][init] Automatic switch to uncompressed mode for large heap

Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ilya Berezhniuk updated HARMONY-5045:
-------------------------------------

    Summary: [drlvm][init] Automatic switch to uncompressed mode for large heap  (was: [drlvm] Automatic switch to uncompressed mode for large heap)

> [drlvm][init] Automatic switch to uncompressed mode for large heap
> ------------------------------------------------------------------
>
>                 Key: HARMONY-5045
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5045
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>         Environment: x86_64 Linux/Windows
>            Reporter: Ilya Berezhniuk
>         Attachments: auto_switch.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HARMONY-5045) [drlvm][init] Automatic switch to uncompressed mode for large heap

Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-5045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12541405 ] 

Ilya Berezhniuk commented on HARMONY-5045:
------------------------------------------

This check is just for trowing away an evidently incorrect combination, when heap size exceeds the limit for compressed refs.
This value should be changed if compressed mode will support more than 4G heap.

I guess, OS limits checking can be performed by GC before Java heap allocation.
Anyway, if specified heap size exceeds OS limit, then memory allocation in GC will fail, and GC initialization will return error.


> [drlvm][init] Automatic switch to uncompressed mode for large heap
> ------------------------------------------------------------------
>
>                 Key: HARMONY-5045
>                 URL: https://issues.apache.org/jira/browse/HARMONY-5045
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>         Environment: x86_64 Linux/Windows
>            Reporter: Ilya Berezhniuk
>         Attachments: auto_switch.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.