[GitHub] [hadoop-ozone] adoroszlai opened a new pull request #185: HDDS-2509. Code cleanup in replication package

[GitBox <gi...@apache.org>]

adoroszlai opened a new pull request #185: HDDS-2509. Code cleanup in replication package
URL: https://github.com/apache/hadoop-ozone/pull/185
 
 
   ## What changes were proposed in this pull request?
   
   1. Fix simple Sonar warnings, eg.:
    * do not declare throwing of unchecked exception
    * use more specific exception instead of `RuntimeException`
    * avoid nesting `try` blocks
    * unused variables
    * document empty method
   2. Avoid `Thread.sleep` in the unit test.  This required a more complex refactoring.  By using same-thread and "discarding" `ExecutorService` instead of real multithreading.  Also added success/failure counters in `ReplicationSupervisor` for more specific state assertions.  Can be exposed later as metrics.
   3. Remove duplicate (leftover?) `package-info.java` for `org.apache.hadoop.ozone.container.replication` package.
   
   https://issues.apache.org/jira/browse/HDDS-2509
   
   ## How was this patch tested?
   
   Unit test (`TestReplicationSupervisor`).  Also tested successful replication in compose-based cluster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org