You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Frank Haefemeier (JIRA)" <ji...@apache.org> on 2008/06/15 18:40:44 UTC
[jira] Created: (CONFIGURATION-331) Missing factory method in
XMLBeanDeclaration.getNestedBeanDeclarations
Missing factory method in XMLBeanDeclaration.getNestedBeanDeclarations
-----------------------------------------------------------------------
Key: CONFIGURATION-331
URL: https://issues.apache.org/jira/browse/CONFIGURATION-331
Project: Commons Configuration
Issue Type: Bug
Affects Versions: 1.3
Reporter: Frank Haefemeier
I create a new BeanDeclaration class on base of XMLBeanDeclaration to extend the behaviour to fill up bean properties with pure XML text nodes. But the problem was, that the method getNestedBeanDeclaration create for all nested child new XMLBeanDeclarations and there
is no way to get my own class. I have to implement the whole method getNestedBeanDeclaration as a copy from the parent class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONFIGURATION-331) Missing factory method in
XMLBeanDeclaration.getNestedBeanDeclarations
Posted by "Oliver Heger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605395#action_12605395 ]
Oliver Heger commented on CONFIGURATION-331:
--------------------------------------------
Yes of course, this was what I had in mind.
I will have a look to integrate this feature into the next release. Thanks for the suggestion.
> Missing factory method in XMLBeanDeclaration.getNestedBeanDeclarations
> -----------------------------------------------------------------------
>
> Key: CONFIGURATION-331
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-331
> Project: Commons Configuration
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Frank Haefemeier
>
> I create a new BeanDeclaration class on base of XMLBeanDeclaration to extend the behaviour to fill up bean properties with pure XML text nodes. But the problem was, that the method getNestedBeanDeclaration create for all nested child new XMLBeanDeclarations and there
> is no way to get my own class. I have to implement the whole method getNestedBeanDeclaration as a copy from the parent class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONFIGURATION-331) Missing factory method in
XMLBeanDeclaration.getNestedBeanDeclarations
Posted by "Frank Haefemeier (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605168#action_12605168 ]
Frank Haefemeier commented on CONFIGURATION-331:
------------------------------------------------
IMHO more convenient for the method would be
{noformat}
/**
* Creates a nested <code>BeanDeclaration</code> for a child node of the current configuration node.
* @param node the affected child node
* @return the <code>BeanDeclaration</code> for this child node
*/
protected BeanDeclaration createBeanDeclaration(ConfigurationNode node);
{noformat}
I think, this is what you thought as you wrote it, right? Your proposal looks like a constructor...
Additional the method {{getNestedBeanDeclaration}} has to be changed to use this new factory method.
> Missing factory method in XMLBeanDeclaration.getNestedBeanDeclarations
> -----------------------------------------------------------------------
>
> Key: CONFIGURATION-331
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-331
> Project: Commons Configuration
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Frank Haefemeier
>
> I create a new BeanDeclaration class on base of XMLBeanDeclaration to extend the behaviour to fill up bean properties with pure XML text nodes. But the problem was, that the method getNestedBeanDeclaration create for all nested child new XMLBeanDeclarations and there
> is no way to get my own class. I have to implement the whole method getNestedBeanDeclaration as a copy from the parent class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CONFIGURATION-331) Missing factory method in
XMLBeanDeclaration.getNestedBeanDeclarations
Posted by "Oliver Heger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12605159#action_12605159 ]
Oliver Heger commented on CONFIGURATION-331:
--------------------------------------------
So you propose a method like
{code}
/**
* Creates a nested <code>BeanDeclaration</code> for a child node of the current configuration node.
* @param node the affected child node
* @return the <code>BeanDeclaration</code> for this child node
*/
protected BeanDeclaration(ConfigurationNode node);
{code}
in XMLBeanDeclaration. This seems reasonable to me. Are you fine with this method signature?
> Missing factory method in XMLBeanDeclaration.getNestedBeanDeclarations
> -----------------------------------------------------------------------
>
> Key: CONFIGURATION-331
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-331
> Project: Commons Configuration
> Issue Type: Bug
> Affects Versions: 1.3
> Reporter: Frank Haefemeier
>
> I create a new BeanDeclaration class on base of XMLBeanDeclaration to extend the behaviour to fill up bean properties with pure XML text nodes. But the problem was, that the method getNestedBeanDeclaration create for all nested child new XMLBeanDeclarations and there
> is no way to get my own class. I have to implement the whole method getNestedBeanDeclaration as a copy from the parent class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CONFIGURATION-331) Missing factory method in
XMLBeanDeclaration.getNestedBeanDeclarations
Posted by "Oliver Heger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Heger updated CONFIGURATION-331:
---------------------------------------
Affects Version/s: (was: 1.3)
1.5
Fix Version/s: 1.6
Issue Type: Improvement (was: Bug)
> Missing factory method in XMLBeanDeclaration.getNestedBeanDeclarations
> -----------------------------------------------------------------------
>
> Key: CONFIGURATION-331
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-331
> Project: Commons Configuration
> Issue Type: Improvement
> Affects Versions: 1.5
> Reporter: Frank Haefemeier
> Fix For: 1.6
>
>
> I create a new BeanDeclaration class on base of XMLBeanDeclaration to extend the behaviour to fill up bean properties with pure XML text nodes. But the problem was, that the method getNestedBeanDeclaration create for all nested child new XMLBeanDeclarations and there
> is no way to get my own class. I have to implement the whole method getNestedBeanDeclaration as a copy from the parent class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CONFIGURATION-331) Missing factory method in
XMLBeanDeclaration.getNestedBeanDeclarations
Posted by "Oliver Heger (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CONFIGURATION-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oliver Heger resolved CONFIGURATION-331.
----------------------------------------
Resolution: Fixed
Fixed in subversion. Thanks for this suggestion.
> Missing factory method in XMLBeanDeclaration.getNestedBeanDeclarations
> -----------------------------------------------------------------------
>
> Key: CONFIGURATION-331
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-331
> Project: Commons Configuration
> Issue Type: Improvement
> Affects Versions: 1.5
> Reporter: Frank Haefemeier
> Assignee: Oliver Heger
> Fix For: 1.6
>
>
> I create a new BeanDeclaration class on base of XMLBeanDeclaration to extend the behaviour to fill up bean properties with pure XML text nodes. But the problem was, that the method getNestedBeanDeclaration create for all nested child new XMLBeanDeclarations and there
> is no way to get my own class. I have to implement the whole method getNestedBeanDeclaration as a copy from the parent class.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.