You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/08/14 19:23:22 UTC

Review Request 37487: Fixed flaky HTTPTest.NestedGet test.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37487/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar and Ben Mahler.


Bugs: MESOS-3262
    https://issues.apache.org/jira/browse/MESOS-3262


Repository: mesos


Description
-------

Turns out the test was directly calling methods on HttpProcess instead of dispatching to it. Added routes for "/a/b/c" and "/a" handlers in initialize like we did with all the other handlers.


Diffs
-----

  3rdparty/libprocess/src/tests/http_tests.cpp 7351fa44e69743ab82e9cada7ba7f797a6899bab 

Diff: https://reviews.apache.org/r/37487/diff/


Testing
-------

Ran the test in a loop 10K times.


Thanks,

Vinod Kone

Re: Review Request 37487: Fixed flaky HTTPTest.NestedGet test.

Posted by Ben Mahler <be...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37487/#review95453
-----------------------------------------------------------

Ship it!


Ship It!

- Ben Mahler


On Aug. 14, 2015, 5:23 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37487/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2015, 5:23 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Bugs: MESOS-3262
>     https://issues.apache.org/jira/browse/MESOS-3262
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Turns out the test was directly calling methods on HttpProcess instead of dispatching to it. Added routes for "/a/b/c" and "/a" handlers in initialize like we did with all the other handlers.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/http_tests.cpp 7351fa44e69743ab82e9cada7ba7f797a6899bab 
> 
> Diff: https://reviews.apache.org/r/37487/diff/
> 
> 
> Testing
> -------
> 
> Ran the test in a loop 10K times.
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>