You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "virajjasani (via GitHub)" <gi...@apache.org> on 2026/10/06 22:30:50 UTC
[PR] PHOENIX-8007 Perf bottleneck - Server side Index metadata lookup overhead (ADDENDUM) [phoenix]
virajjasani opened a new pull request, #2629:
URL: https://github.com/apache/phoenix/pull/2629
Jira: PHOENIX-8007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-8007 Perf bottleneck - Server side Index metadata lookup overhead (ADDENDUM) [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #2629:
URL: https://github.com/apache/phoenix/pull/2629#issuecomment-6043178193
Instead of keeping url cached at regionserver JVM, the addendum lets it get cached at region level. This benefits existing test setups where single JVM is shared across regionserver, zookeeper, hmaster and other downstream services.
As for the production code, caching of the url at regionserver JVM vs region level has negligible difference in performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-8007 Perf bottleneck - Server side Index metadata lookup overhead (ADDENDUM) [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #2629:
URL: https://github.com/apache/phoenix/pull/2629#issuecomment-6030551880
Build: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-2629/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-8007 Perf bottleneck - Server side Index metadata lookup overhead (ADDENDUM) [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani merged PR #2629:
URL: https://github.com/apache/phoenix/pull/2629
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-8007 Perf bottleneck - Server side Index metadata lookup overhead (ADDENDUM) [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on code in PR #2629:
URL: https://github.com/apache/phoenix/pull/2629#discussion_r4213651776
##########
phoenix-core-server/src/main/java/org/apache/phoenix/index/PhoenixIndexMetaDataBuilder.java:
##########
@@ -162,8 +160,9 @@ private static IndexMetaDataCache getIndexMetaDataCacheFromPTable(
props.setProperty(PhoenixRuntime.TENANT_ID_ATTRIB, tenantId);
}
QueryUtil.setServerConnection(props);
- try (Connection conn = DriverManager.getConnection(getServerConnectionUrl(env), props)) {
+ try (Connection conn = DriverManager.getConnection(getServerConnectionUrl(), props)) {
PhoenixConnection pconn = conn.unwrap(PhoenixConnection.class);
+ pconn.getQueryServices().clearUpgradeRequired();
Review Comment:
This is already done by QueryUtil getServerConnection, just to be safer from doing any metadata upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-8007 Perf bottleneck - Server side Index metadata lookup overhead (ADDENDUM) [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #2629:
URL: https://github.com/apache/phoenix/pull/2629#issuecomment-6050176191
Yes the HA tests are all passing, so that should be good enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-8007 Perf bottleneck - Server side Index metadata lookup overhead (ADDENDUM) [phoenix]
Posted by "tkhurana (via GitHub)" <gi...@apache.org>.
tkhurana commented on PR #2629:
URL: https://github.com/apache/phoenix/pull/2629#issuecomment-6041862648
@virajjasani can you add more details on the addendum patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-8007 Perf bottleneck - Server side Index metadata lookup overhead (ADDENDUM) [phoenix]
Posted by "jpisaac (via GitHub)" <gi...@apache.org>.
jpisaac commented on code in PR #2629:
URL: https://github.com/apache/phoenix/pull/2629#discussion_r4211307159
##########
phoenix-core-server/src/main/java/org/apache/phoenix/index/PhoenixIndexMetaDataBuilder.java:
##########
@@ -162,8 +160,9 @@ private static IndexMetaDataCache getIndexMetaDataCacheFromPTable(
props.setProperty(PhoenixRuntime.TENANT_ID_ATTRIB, tenantId);
}
QueryUtil.setServerConnection(props);
- try (Connection conn = DriverManager.getConnection(getServerConnectionUrl(env), props)) {
+ try (Connection conn = DriverManager.getConnection(getServerConnectionUrl(), props)) {
PhoenixConnection pconn = conn.unwrap(PhoenixConnection.class);
+ pconn.getQueryServices().clearUpgradeRequired();
Review Comment:
Why was this clearUpgradeRequired needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-8007 Perf bottleneck - Server side Index metadata lookup overhead (ADDENDUM) [phoenix]
Posted by "virajjasani (via GitHub)" <gi...@apache.org>.
virajjasani commented on PR #2629:
URL: https://github.com/apache/phoenix/pull/2629#issuecomment-6051799461
@jpisaac added HA test with this scenario and verified that it passes only with the addendum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org