You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/07/06 23:49:28 UTC

Re: Review Request 23784: Missing Apache headers for stout

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23784/
-----------------------------------------------------------

(Updated July 6, 2015, 9:49 p.m.)


Review request for mesos, Benjamin Hindman and Dominic Hamon.


Repository: mesos


Description
-------

Adding missing Apache licence headers on .cpp, .hpp and Makefiles


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 9df5de4 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am ff6fb28 
  3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp c47bd13 
  3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp dc05284 
  3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp f8a0ba5 
  3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 724c5fe 
  3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 35a62b1 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 2a6f67b 
  3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 2211f31 
  3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 4a8176b 
  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 97a7167 
  3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
  3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp c50480b 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 0011f08 
  3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 0644d99 
  3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp b80fff9 
  3rdparty/libprocess/3rdparty/stout/tests/main.cpp f5f20ee 
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 11f3bf7 
  3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 1c1f8be 
  3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 4a0f60b 
  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp fee942c 
  3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 6d2d3d5 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 4a01d94 
  3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp dd3700d 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp b3ce131 
  3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp 3ddba94 
  3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 0689446 
  3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2e 
  3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 93339eb 
  3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 

Diff: https://reviews.apache.org/r/23784/diff/


Testing
-------


Thanks,

Isabel Jimenez

Re: Review Request 23784: Missing Apache headers for stout

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23784/#review90609
-----------------------------------------------------------


Patch looks great!

Reviews applied: [23784]

All tests passed.

- Mesos ReviewBot


On July 6, 2015, 10:02 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23784/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 10:02 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 9df5de4 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am ff6fb28 
>   3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp c47bd13 
>   3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp dc05284 
>   3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp f8a0ba5 
>   3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 724c5fe 
>   3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 35a62b1 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 2a6f67b 
>   3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 2211f31 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 4a8176b 
>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 97a7167 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
>   3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp c50480b 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 0011f08 
>   3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 0644d99 
>   3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp b80fff9 
>   3rdparty/libprocess/3rdparty/stout/tests/main.cpp f5f20ee 
>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 11f3bf7 
>   3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 1c1f8be 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 4a0f60b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp fee942c 
>   3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 6d2d3d5 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 4a01d94 
>   3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp dd3700d 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp b3ce131 
>   3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp 3ddba94 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 0689446 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2e 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 93339eb 
>   3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 
> 
> Diff: https://reviews.apache.org/r/23784/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 23784: Missing Apache headers for stout

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23784/#review90985
-----------------------------------------------------------


Bad patch!

Reviews applied: [23784]

Failed command: ./support/apply-review.sh -n -r 23784

Error:
 2015-07-08 20:43:30 URL:https://reviews.apache.org/r/23784/diff/raw/ [30874/30874] -> "23784.patch" [1]
Successfully applied: Missing Apache headers for stout

Adding missing Apache licence headers on .cpp, .hpp and Makefiles


Review: https://reviews.apache.org/r/23784
Checking 28 files using filter --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo
Total errors found: 0
ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
mesos:
  support/check-apache-header.sh
stout:
  3rdparty/libprocess/3rdparty/stout/Makefile.am
  3rdparty/libprocess/3rdparty/stout/configure.ac
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am
  3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/main.cpp
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp
  3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp
Failed to commit patch

- Mesos ReviewBot


On July 8, 2015, 6:55 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23784/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 6:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 9df5de4 
>   3rdparty/libprocess/3rdparty/stout/configure.ac 1988d19 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am ff6fb28 
>   3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp c47bd13 
>   3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 1fe7e08 
>   3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp f8d6e42 
>   3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 724c5fe 
>   3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 35a62b1 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 2a6f67b 
>   3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 2211f31 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 4a8176b 
>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 97a7167 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
>   3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp c50480b 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 0011f08 
>   3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 0644d99 
>   3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp b80fff9 
>   3rdparty/libprocess/3rdparty/stout/tests/main.cpp f5f20ee 
>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 11f3bf7 
>   3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 1c1f8be 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 4a0f60b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp fee942c 
>   3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 6d2d3d5 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 4a01d94 
>   3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp dd3700d 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp b3ce131 
>   3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp b3cd5f8 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp ed48279 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2e 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 6871e8b 
>   3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 
>   support/check-apache-header.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/23784/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 23784: Missing Apache headers for stout

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23784/#review91074
-----------------------------------------------------------

Ship it!



3rdparty/libprocess/3rdparty/stout/configure.ac (lines 13 - 14)
<https://reviews.apache.org/r/23784/#comment144346>

    These actually don't add any value, I think. We should get rid of them at some point (not part of this RR!).


- Till Toenshoff


On July 8, 2015, 8:51 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23784/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 8:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 9df5de4 
>   3rdparty/libprocess/3rdparty/stout/configure.ac 1988d19 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am ff6fb28 
>   3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp c47bd13 
>   3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 1fe7e08 
>   3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp f8d6e42 
>   3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 724c5fe 
>   3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 35a62b1 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 2a6f67b 
>   3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 2211f31 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 4a8176b 
>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 97a7167 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
>   3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp c50480b 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 0011f08 
>   3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 0644d99 
>   3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp b80fff9 
>   3rdparty/libprocess/3rdparty/stout/tests/main.cpp f5f20ee 
>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 11f3bf7 
>   3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 1c1f8be 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 4a0f60b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp fee942c 
>   3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 6d2d3d5 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp d7d4552 
>   3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp dd3700d 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp b3ce131 
>   3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp b3cd5f8 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp ed48279 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2e 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 6871e8b 
>   3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 
> 
> Diff: https://reviews.apache.org/r/23784/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 23784: Missing Apache headers for stout

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23784/#review91036
-----------------------------------------------------------


Patch looks great!

Reviews applied: [23784]

All tests passed.

- Mesos ReviewBot


On July 8, 2015, 8:51 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23784/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 8:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 9df5de4 
>   3rdparty/libprocess/3rdparty/stout/configure.ac 1988d19 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am ff6fb28 
>   3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp c47bd13 
>   3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 1fe7e08 
>   3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp f8d6e42 
>   3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 724c5fe 
>   3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 35a62b1 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 2a6f67b 
>   3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 2211f31 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 4a8176b 
>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 97a7167 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
>   3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp c50480b 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 0011f08 
>   3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 0644d99 
>   3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp b80fff9 
>   3rdparty/libprocess/3rdparty/stout/tests/main.cpp f5f20ee 
>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 11f3bf7 
>   3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 1c1f8be 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 4a0f60b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp fee942c 
>   3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 6d2d3d5 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp d7d4552 
>   3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp dd3700d 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp b3ce131 
>   3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp b3cd5f8 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp ed48279 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2e 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 6871e8b 
>   3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 
> 
> Diff: https://reviews.apache.org/r/23784/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 23784: Missing Apache headers for stout

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23784/#review91212
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On July 8, 2015, 8:51 p.m., Isabel Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23784/
> -----------------------------------------------------------
> 
> (Updated July 8, 2015, 8:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Dominic Hamon.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adding missing Apache licence headers on .cpp, .hpp and Makefiles
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/Makefile.am 9df5de4 
>   3rdparty/libprocess/3rdparty/stout/configure.ac 1988d19 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am ff6fb28 
>   3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp c47bd13 
>   3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 1fe7e08 
>   3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp f8d6e42 
>   3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 724c5fe 
>   3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 35a62b1 
>   3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 2a6f67b 
>   3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 2211f31 
>   3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 4a8176b 
>   3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 97a7167 
>   3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
>   3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp c50480b 
>   3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 0011f08 
>   3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 0644d99 
>   3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp b80fff9 
>   3rdparty/libprocess/3rdparty/stout/tests/main.cpp f5f20ee 
>   3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 11f3bf7 
>   3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 1c1f8be 
>   3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 4a0f60b 
>   3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp fee942c 
>   3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 6d2d3d5 
>   3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp d7d4552 
>   3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp dd3700d 
>   3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp b3ce131 
>   3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp b3cd5f8 
>   3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp ed48279 
>   3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2e 
>   3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 6871e8b 
>   3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 
> 
> Diff: https://reviews.apache.org/r/23784/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Isabel Jimenez
> 
>

Re: Review Request 23784: Missing Apache headers for stout

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23784/
-----------------------------------------------------------

(Updated July 8, 2015, 8:51 p.m.)


Review request for mesos, Benjamin Hindman and Dominic Hamon.


Repository: mesos


Description
-------

Adding missing Apache licence headers on .cpp, .hpp and Makefiles


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 9df5de4 
  3rdparty/libprocess/3rdparty/stout/configure.ac 1988d19 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am ff6fb28 
  3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp c47bd13 
  3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 1fe7e08 
  3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp f8d6e42 
  3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 724c5fe 
  3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 35a62b1 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 2a6f67b 
  3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 2211f31 
  3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 4a8176b 
  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 97a7167 
  3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
  3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp c50480b 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 0011f08 
  3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 0644d99 
  3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp b80fff9 
  3rdparty/libprocess/3rdparty/stout/tests/main.cpp f5f20ee 
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 11f3bf7 
  3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 1c1f8be 
  3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 4a0f60b 
  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp fee942c 
  3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 6d2d3d5 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp d7d4552 
  3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp dd3700d 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp b3ce131 
  3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp b3cd5f8 
  3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp ed48279 
  3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2e 
  3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 6871e8b 
  3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 

Diff: https://reviews.apache.org/r/23784/diff/


Testing
-------


Thanks,

Isabel Jimenez

Re: Review Request 23784: Missing Apache headers for stout

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23784/
-----------------------------------------------------------

(Updated July 8, 2015, 6:55 p.m.)


Review request for mesos, Benjamin Hindman and Dominic Hamon.


Repository: mesos


Description
-------

Adding missing Apache licence headers on .cpp, .hpp and Makefiles


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 9df5de4 
  3rdparty/libprocess/3rdparty/stout/configure.ac 1988d19 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am ff6fb28 
  3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp c47bd13 
  3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp 1fe7e08 
  3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp f8d6e42 
  3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 724c5fe 
  3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 35a62b1 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 2a6f67b 
  3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 2211f31 
  3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 4a8176b 
  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 97a7167 
  3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
  3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp c50480b 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 0011f08 
  3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 0644d99 
  3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp b80fff9 
  3rdparty/libprocess/3rdparty/stout/tests/main.cpp f5f20ee 
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 11f3bf7 
  3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 1c1f8be 
  3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 4a0f60b 
  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp fee942c 
  3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 6d2d3d5 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 4a01d94 
  3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp dd3700d 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp b3ce131 
  3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp b3cd5f8 
  3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp ed48279 
  3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2e 
  3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 6871e8b 
  3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 
  support/check-apache-header.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/23784/diff/


Testing
-------


Thanks,

Isabel Jimenez

Re: Review Request 23784: Missing Apache headers for stout

Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23784/
-----------------------------------------------------------

(Updated July 6, 2015, 10:02 p.m.)


Review request for mesos, Benjamin Hindman and Dominic Hamon.


Repository: mesos


Description
-------

Adding missing Apache licence headers on .cpp, .hpp and Makefiles


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am 9df5de4 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am ff6fb28 
  3rdparty/libprocess/3rdparty/stout/tests/bits_tests.cpp c47bd13 
  3rdparty/libprocess/3rdparty/stout/tests/bytes_tests.cpp dc05284 
  3rdparty/libprocess/3rdparty/stout/tests/cache_tests.cpp f8a0ba5 
  3rdparty/libprocess/3rdparty/stout/tests/duration_tests.cpp 724c5fe 
  3rdparty/libprocess/3rdparty/stout/tests/error_tests.cpp 35a62b1 
  3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 2a6f67b 
  3rdparty/libprocess/3rdparty/stout/tests/gzip_tests.cpp 2211f31 
  3rdparty/libprocess/3rdparty/stout/tests/hashmap_tests.cpp 4a8176b 
  3rdparty/libprocess/3rdparty/stout/tests/hashset_tests.cpp 97a7167 
  3rdparty/libprocess/3rdparty/stout/tests/interval_tests.cpp 1fa8fc1 
  3rdparty/libprocess/3rdparty/stout/tests/ip_tests.cpp c50480b 
  3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp 0011f08 
  3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 0644d99 
  3rdparty/libprocess/3rdparty/stout/tests/mac_tests.cpp b80fff9 
  3rdparty/libprocess/3rdparty/stout/tests/main.cpp f5f20ee 
  3rdparty/libprocess/3rdparty/stout/tests/multimap_tests.cpp 11f3bf7 
  3rdparty/libprocess/3rdparty/stout/tests/none_tests.cpp 1c1f8be 
  3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp 4a0f60b 
  3rdparty/libprocess/3rdparty/stout/tests/os/sendfile_tests.cpp fee942c 
  3rdparty/libprocess/3rdparty/stout/tests/os/signals_tests.cpp 6d2d3d5 
  3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 4a01d94 
  3rdparty/libprocess/3rdparty/stout/tests/proc_tests.cpp dd3700d 
  3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp b3ce131 
  3rdparty/libprocess/3rdparty/stout/tests/set_tests.cpp 3ddba94 
  3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp 0689446 
  3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 9733b2e 
  3rdparty/libprocess/3rdparty/stout/tests/thread_tests.cpp 93339eb 
  3rdparty/libprocess/3rdparty/stout/tests/uuid_tests.cpp 7ac8fc0 

Diff: https://reviews.apache.org/r/23784/diff/


Testing
-------


Thanks,

Isabel Jimenez