You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2013/06/03 10:29:58 UTC

Re: Review Request: HIVE-4546: Hive CLI leaves behind the per session resource directory on non-interactive invocation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11083/
-----------------------------------------------------------

(Updated June 3, 2013, 8:29 a.m.)


Review request for hive, Owen O'Malley and Gunther Hagleitner.


Changes
-------

Thanks for the review comments.
Updated patch with better error handling for CliDriver.run()

Regarding session id, its not much of a readable format it is (userid + vmName + timestamp) + proposed counter. We can still run into edge conditions with   multiple hive CLIs or multiple hive server (eg. for HA purpose) on different node. Using UUID as handle takes care such cases. 


Description
-------

Hive CLI leaves behind the per session resource directory on non-interactive invocation. The patch includes executing session state close() at the end of non-interactive invocation.
Also changed the session id format to be a UUID. This is avoid possible resource directory path conflict when there are multiple session HiveServer2 from same user at same time.


This addresses bug HIVE-4546.
    https://issues.apache.org/jira/browse/HIVE-4546


Diffs (updated)
-----

  cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 4239392 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 8e6e24a 

Diff: https://reviews.apache.org/r/11083/diff/


Testing
-------


Thanks,

Prasad Mujumdar