You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/21 17:44:11 UTC

[GitHub] [incubator-kyuubi] SteNicholas commented on a diff in pull request #2384: [KYUUBI #2032][Subtask] Hive Backend Engine - new APIs with hive-service-rpc 3.1.2 - SetClientInfo

SteNicholas commented on code in PR #2384:
URL: https://github.com/apache/incubator-kyuubi/pull/2384#discussion_r855439149


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -532,9 +533,27 @@ abstract class TFrontendService(name: String)
   }
 
   override def SetClientInfo(req: TSetClientInfoReq): TSetClientInfoResp = {
+    // TODO: We don't do anything for now, just log this for debugging.

Review Comment:
   Why do you add the `TODO` here? Any update in future?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org