You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/10 03:06:00 UTC
[GitHub] [incubator-nuttx] chrade opened a new pull request #5453: Phyplus rel 1.5
chrade opened a new pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453
## Summary
phyplus release version 1.5 , need notice this version should revert follow commit..
fb43fd73ed9d2b60984c3e0c5dd71ea9e25d7fcd
otherwise , system startup will generate a hard fault.
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] chrade commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
chrade commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803380382
##########
File path: boards/arm/phy62xx/phy6222/scripts/flash.ld
##########
@@ -88,8 +88,53 @@ SECTIONS
//*libarch.a:phy62xx_ble_patch.o(.text.ll_processBasicIRQ_SRX0)
//*libarch.a:phy62xx_ble_patch.o(.text.ll_hw_read_rfifo1)
+
+ *libphy6222_rf.a:patch.o(.text.ll_hw_go1)
+ *libphy6222_rf.a:patch.o(.text.TIM1_IRQHandler1)
+ *libphy6222_rf.a:patch.o(.text.LL_IRQHandler1)
+ *libphy6222_rf.a:patch.o(.text.rf_phy_change_cfg0)
+ *libphy6222_rf.a:patch.o(.text.rf_calibrate1)
+ *libphy6222_rf.a:patch.o(.text.l2capPocessFragmentTxData)
+ *libphy6222_rf.a:patch.o(.text.LL_SetDataLengh1)
+ *libphy6222_rf.a:patch.o(.text.llProcessTxData1)
+ *libphy6222_rf.a:patch.o(.text.ll_generateTxBuffer1)
+ *libphy6222_rf.a:patch.o(.text.ll_adptive_adj_next_time1)
+ *libphy6222_rf.a:patch.o(.text.llSecAdvAllow1)
+ *libphy6222_rf.a:patch.o(.text.ll_scheduler1)
+ *libphy6222_rf.a:patch.o(.text.osal_set_event1)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_SRX)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_secondaryAdvTRX)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_ScanTRX)
+ *libphy6222_rf.a:patch.o(.text.llSlaveEvt_TaskEndOk1)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_secondaryAdvTRX0)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_ScanTRX0)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_SRX0)
+ *libphy6222_rf.a:patch.o(.text.ll_hw_read_rfifo1)
+
+ *libphy6222_rf.a:patch.o(.text.LL_set_default_conn_params1)
+ *libphy6222_rf.a:patch.o(.text.llConnTerminate1)
+ *libphy6222_rf.a:patch.o(.text.config_RTC1)
+ *libphy6222_rf.a:patch.o(.text.wakeup_init1)
+ *libphy6222_rf.a:patch.o(.text.LL_ENC_AES128_Encrypt1)
+ *libphy6222_rf.a:patch.o(.text.LL_ENC_Encrypt1)
+ *libphy6222_rf.a:patch.o(.text.LL_ENC_Decrypt1)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_secondaryScanSRX)
+ *libphy6222_rf.a:patch.o(.text.llProcessSlaveControlProcedures1)
+ *libphy6222_rf.a:patch.o(.text.llCalcMaxScanTime1)
+ *libphy6222_rf.a:patch.o(.text.LL_SetAdvControl1)
+ *libphy6222_rf.a:patch.o(.text.llSetupSecAdvEvt1)
+ *libphy6222_rf.a:patch.o(.text.ll_scheduler2)
+ *libphy6222_rf.a:patch.o(.text.llSetupNextSlaveEvent1)
+
+ *libapps.a:flash.c.*.o(.text .text.*)
+ *libapps.a:*.o(.text.drv_disable_irq1)
+ *libapps.a:*.o(.text.drv_enable_irq1)
+
Review comment:
i will fit it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
LingaoM commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803340505
##########
File path: arch/arm/src/phy62xx/pplus_mtd_flash.c
##########
@@ -144,7 +147,10 @@ static int pplus_fls_erase_chip(struct pplus_fls_dev_s *priv)
for (i = 0; i < priv->nsectors; i++)
{
+ _HAL_CS_ALLOC_();
+ HAL_ENTER_CRITICAL_SECTION();
hal_flash_erase_sector(address);
+ HAL_EXIT_CRITICAL_SECTION();
Review comment:
During critical time period, is it an appropriate way to erase flash?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803814335
##########
File path: arch/arm/src/phy62xx/pplus_mtd_flash.c
##########
@@ -144,7 +147,10 @@ static int pplus_fls_erase_chip(struct pplus_fls_dev_s *priv)
for (i = 0; i < priv->nsectors; i++)
{
+ _HAL_CS_ALLOC_();
+ HAL_ENTER_CRITICAL_SECTION();
hal_flash_erase_sector(address);
+ HAL_EXIT_CRITICAL_SECTION();
Review comment:
it may block the interrupt for a long time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
LingaoM commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803275713
##########
File path: boards/arm/phy62xx/phy6222/scripts/flash.ld
##########
@@ -88,8 +88,53 @@ SECTIONS
//*libarch.a:phy62xx_ble_patch.o(.text.ll_processBasicIRQ_SRX0)
//*libarch.a:phy62xx_ble_patch.o(.text.ll_hw_read_rfifo1)
+
+ *libphy6222_rf.a:patch.o(.text.ll_hw_go1)
+ *libphy6222_rf.a:patch.o(.text.TIM1_IRQHandler1)
+ *libphy6222_rf.a:patch.o(.text.LL_IRQHandler1)
+ *libphy6222_rf.a:patch.o(.text.rf_phy_change_cfg0)
+ *libphy6222_rf.a:patch.o(.text.rf_calibrate1)
+ *libphy6222_rf.a:patch.o(.text.l2capPocessFragmentTxData)
+ *libphy6222_rf.a:patch.o(.text.LL_SetDataLengh1)
+ *libphy6222_rf.a:patch.o(.text.llProcessTxData1)
+ *libphy6222_rf.a:patch.o(.text.ll_generateTxBuffer1)
+ *libphy6222_rf.a:patch.o(.text.ll_adptive_adj_next_time1)
+ *libphy6222_rf.a:patch.o(.text.llSecAdvAllow1)
+ *libphy6222_rf.a:patch.o(.text.ll_scheduler1)
+ *libphy6222_rf.a:patch.o(.text.osal_set_event1)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_SRX)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_secondaryAdvTRX)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_ScanTRX)
+ *libphy6222_rf.a:patch.o(.text.llSlaveEvt_TaskEndOk1)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_secondaryAdvTRX0)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_ScanTRX0)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_SRX0)
+ *libphy6222_rf.a:patch.o(.text.ll_hw_read_rfifo1)
+
+ *libphy6222_rf.a:patch.o(.text.LL_set_default_conn_params1)
+ *libphy6222_rf.a:patch.o(.text.llConnTerminate1)
+ *libphy6222_rf.a:patch.o(.text.config_RTC1)
+ *libphy6222_rf.a:patch.o(.text.wakeup_init1)
+ *libphy6222_rf.a:patch.o(.text.LL_ENC_AES128_Encrypt1)
+ *libphy6222_rf.a:patch.o(.text.LL_ENC_Encrypt1)
+ *libphy6222_rf.a:patch.o(.text.LL_ENC_Decrypt1)
+ *libphy6222_rf.a:patch.o(.text.ll_processBasicIRQ_secondaryScanSRX)
+ *libphy6222_rf.a:patch.o(.text.llProcessSlaveControlProcedures1)
+ *libphy6222_rf.a:patch.o(.text.llCalcMaxScanTime1)
+ *libphy6222_rf.a:patch.o(.text.LL_SetAdvControl1)
+ *libphy6222_rf.a:patch.o(.text.llSetupSecAdvEvt1)
+ *libphy6222_rf.a:patch.o(.text.ll_scheduler2)
+ *libphy6222_rf.a:patch.o(.text.llSetupNextSlaveEvent1)
+
+ *libapps.a:flash.c.*.o(.text .text.*)
+ *libapps.a:*.o(.text.drv_disable_irq1)
+ *libapps.a:*.o(.text.drv_enable_irq1)
+
Review comment:
```suggestion
*libphy6222_rf.a:patch.o(.text.llSetupNextSlaveEvent1)
*libapps.a:flash.c.*.o(.text .text.*)
*libapps.a:*.o(.text.drv_disable_irq1)
*libapps.a:*.o(.text.drv_enable_irq1)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
LingaoM commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803335085
##########
File path: arch/arm/src/phy62xx/phy62xx_exception.S
##########
@@ -339,6 +340,13 @@ exception_common_inline:
.size exception_common_inline, .-exception_common_inline
+/****************************************************************************
+ * Name: g_intstackalloc/g_intstacktop
+ *
+ * Description:
+ * Shouldn't happen
+ *
+ ****************************************************************************/
Review comment:
Already exists below,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
LingaoM commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803275874
##########
File path: boards/arm/phy62xx/phy6222/scripts/flash.ld
##########
@@ -121,6 +167,9 @@ SECTIONS
*libmm.a:circbuf.o(.text .text.*)
+ *libc.a:lib_libvsprintf.o(.text .text.*)
+ *libc.a:lib_printf.o(.text .text.*)
+ *libc.a:lib_vfprintf.o(.text .text.*)
*libc.a:lib_skipspace.o(.text .text.*)
*libc.a:lib_sprintf.o(.text .text.*)
Review comment:
```suggestion
*libmm.a:circbuf.o(.text .text.*)
*libc.a:lib_libvsprintf.o(.text .text.*)
*libc.a:lib_printf.o(.text .text.*)
*libc.a:lib_vfprintf.o(.text .text.*)
*libc.a:lib_skipspace.o(.text .text.*)
*libc.a:lib_sprintf.o(.text .text.*)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] chrade commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
chrade commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803381901
##########
File path: boards/arm/phy62xx/phy6222/src/bringup.c
##########
@@ -125,16 +137,26 @@ int phy62xx_bringup(void)
/* Mount the LittleFS file system */
- ret = nx_mount("/dev/mtd", "/mnt/lfs", "littlefs", 0,
+ ret = nx_mount("/dev/mtd", "/data", "littlefs", 0,
"forceformat");
Review comment:
ok , i will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] chrade commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
chrade commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803380128
##########
File path: boards/arm/phy62xx/phy6222/configs/newostest/defconfig.bak
##########
@@ -0,0 +1,147 @@
+#
Review comment:
ok. i will delete it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] chrade closed pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
chrade closed pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] chrade commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
chrade commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803381170
##########
File path: arch/arm/src/phy62xx/uart.c
##########
@@ -62,6 +68,9 @@ typedef struct _uart_Context
uint8_t tx_state;
uart_Tx_Buf_t tx_buf;
uart_Cfg_t cfg;
+ uint8_t fifo_buf_store[UART_RX_BUFFER_SIZE];
+ int buf_head;
+ int buf_tail;
} uart_Ctx_t;
static uart_Ctx_t m_uartCtx[2] =
Review comment:
ok, i will reduce the RX_BUFF_SIZE and self check first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
LingaoM commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803277507
##########
File path: arch/arm/src/phy62xx/uart.c
##########
@@ -62,6 +68,9 @@ typedef struct _uart_Context
uint8_t tx_state;
uart_Tx_Buf_t tx_buf;
uart_Cfg_t cfg;
+ uint8_t fifo_buf_store[UART_RX_BUFFER_SIZE];
+ int buf_head;
+ int buf_tail;
} uart_Ctx_t;
static uart_Ctx_t m_uartCtx[2] =
Review comment:
Why reserve so much memory for devices with limited available resources? Is it necessary to put `UART_RX_BUFFER_SIZE` into kconfig?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] chrade commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
chrade commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803382074
##########
File path: boards/arm/phy62xx/phy6222/configs/newostest/defconfig
##########
@@ -0,0 +1,139 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_DISABLE_OS_API is not set
+# CONFIG_DISABLE_PSEUDOFS_OPERATIONS is not set
+# CONFIG_LIBC_ERR is not set
+# CONFIG_NSH_DISABLEBG is not set
+# CONFIG_NSH_DISABLE_BASENAME is not set
+# CONFIG_NSH_DISABLE_CAT is not set
+# CONFIG_NSH_DISABLE_CD is not set
+# CONFIG_NSH_DISABLE_CMP is not set
+# CONFIG_NSH_DISABLE_CP is not set
+# CONFIG_NSH_DISABLE_DF is not set
+# CONFIG_NSH_DISABLE_DIRNAME is not set
+# CONFIG_NSH_DISABLE_ECHO is not set
+# CONFIG_NSH_DISABLE_ENV is not set
+# CONFIG_NSH_DISABLE_EXEC is not set
+# CONFIG_NSH_DISABLE_EXIT is not set
+# CONFIG_NSH_DISABLE_EXPORT is not set
+# CONFIG_NSH_DISABLE_FREE is not set
+# CONFIG_NSH_DISABLE_HELP is not set
+# CONFIG_NSH_DISABLE_HEXDUMP is not set
+# CONFIG_NSH_DISABLE_KILL is not set
+# CONFIG_NSH_DISABLE_LS is not set
+# CONFIG_NSH_DISABLE_MKDIR is not set
+# CONFIG_NSH_DISABLE_MOUNT is not set
+# CONFIG_NSH_DISABLE_PS is not set
+# CONFIG_NSH_DISABLE_PSSTACKUSAGE is not set
+# CONFIG_NSH_DISABLE_PWD is not set
+# CONFIG_NSH_DISABLE_REBOOT is not set
+# CONFIG_NSH_DISABLE_RM is not set
+# CONFIG_NSH_DISABLE_RMDIR is not set
+# CONFIG_NSH_DISABLE_SET is not set
+# CONFIG_NSH_DISABLE_SLEEP is not set
+# CONFIG_NSH_DISABLE_SOURCE is not set
+# CONFIG_NSH_DISABLE_TELNETD is not set
+# CONFIG_NSH_DISABLE_TEST is not set
+# CONFIG_NSH_DISABLE_TIME is not set
+# CONFIG_NSH_DISABLE_UMOUNT is not set
+# CONFIG_NSH_DISABLE_UNAME is not set
+# CONFIG_NSH_DISABLE_UNSET is not set
+# CONFIG_NSH_DISABLE_USLEEP is not set
+# CONFIG_NSH_DISABLE_XD is not set
+CONFIG_ARCH="arm"
+CONFIG_ARCH_BOARD="phy6222"
+CONFIG_ARCH_BOARD_PHY6222=y
+CONFIG_ARCH_CHIP="phy62xx"
+CONFIG_ARCH_CHIP_PHY6222=y
+CONFIG_ARCH_CHIP_PHY62XX=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_BOARDCTL=y
+CONFIG_BOARDCTL_RESET=y
+CONFIG_BOARD_LATE_INITIALIZE=y
+CONFIG_BUILTIN=y
+CONFIG_CLOCK_MONOTONIC=y
+CONFIG_DEBUG_ASSERTIONS=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_FS=y
+CONFIG_DEBUG_FULLOPT=y
+CONFIG_DEBUG_HARDFAULT_ALERT=y
+CONFIG_DEBUG_LIB=y
+CONFIG_DEBUG_MM=y
+CONFIG_DEBUG_SCHED=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_TIMER=y
+CONFIG_DEBUG_WATCHDOG=y
+CONFIG_DEFAULT_SMALL=y
+CONFIG_DEV_GPIO=y
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_TIMER=y
+CONFIG_EXAMPLES_WATCHDOG=y
+CONFIG_FS_AUTOMOUNTER=y
+CONFIG_FS_LITTLEFS=y
+CONFIG_FS_LITTLEFS_BLOCK_FACTOR=1
+CONFIG_FS_PROCFS=y
+CONFIG_FS_TEST=y
+CONFIG_FS_TEST_API=y
+CONFIG_FS_TEST_PERFORMANCE=y
+CONFIG_IDLETHREAD_STACKSIZE=2048
+CONFIG_INIT_ENTRYNAME="init"
+CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INIT_STACKSIZE=2560
+CONFIG_INTELHEX_BINARY=y
+CONFIG_IOEXPANDER=y
+CONFIG_IOEXPANDER_MULTIPIN=y
+CONFIG_LIBC_LOCALTIME=y
+CONFIG_MM_CIRCBUF=y
+CONFIG_MM_SMALL=y
+CONFIG_MM_TEST=y
+CONFIG_MTD=y
+CONFIG_NFILE_DESCRIPTORS_PER_BLOCK=6
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FILEIOSIZE=64
+CONFIG_NUNGET_CHARS=0
+CONFIG_PIPES=y
+CONFIG_PREALLOC_TIMERS=0
+CONFIG_PSEUDOFS_ATTRIBUTES=y
+CONFIG_PSEUDOFS_SOFTLINKS=y
+CONFIG_PTHREAD_CLEANUP=y
+CONFIG_PTHREAD_CLEANUP_STACKSIZE=2
+CONFIG_PTHREAD_MUTEX_TYPES=y
+CONFIG_PTHREAD_SPINLOCKS=y
+CONFIG_PTHREAD_STACK_DEFAULT=3072
+CONFIG_RAM_SIZE=58368
+CONFIG_RAM_START=0x1fff1c00
Review comment:
i will check and fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] CV-Bowen commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
CV-Bowen commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803362939
##########
File path: boards/arm/phy62xx/phy6222/src/bringup.c
##########
@@ -125,16 +137,26 @@ int phy62xx_bringup(void)
/* Mount the LittleFS file system */
- ret = nx_mount("/dev/mtd", "/mnt/lfs", "littlefs", 0,
+ ret = nx_mount("/dev/mtd", "/data", "littlefs", 0,
"forceformat");
Review comment:
the "forceformat" should be modified to "autoformat"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] CV-Bowen commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
CV-Bowen commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803360770
##########
File path: boards/arm/phy62xx/phy6222/configs/newostest/defconfig
##########
@@ -0,0 +1,139 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_DISABLE_OS_API is not set
+# CONFIG_DISABLE_PSEUDOFS_OPERATIONS is not set
+# CONFIG_LIBC_ERR is not set
+# CONFIG_NSH_DISABLEBG is not set
+# CONFIG_NSH_DISABLE_BASENAME is not set
+# CONFIG_NSH_DISABLE_CAT is not set
+# CONFIG_NSH_DISABLE_CD is not set
+# CONFIG_NSH_DISABLE_CMP is not set
+# CONFIG_NSH_DISABLE_CP is not set
+# CONFIG_NSH_DISABLE_DF is not set
+# CONFIG_NSH_DISABLE_DIRNAME is not set
+# CONFIG_NSH_DISABLE_ECHO is not set
+# CONFIG_NSH_DISABLE_ENV is not set
+# CONFIG_NSH_DISABLE_EXEC is not set
+# CONFIG_NSH_DISABLE_EXIT is not set
+# CONFIG_NSH_DISABLE_EXPORT is not set
+# CONFIG_NSH_DISABLE_FREE is not set
+# CONFIG_NSH_DISABLE_HELP is not set
+# CONFIG_NSH_DISABLE_HEXDUMP is not set
+# CONFIG_NSH_DISABLE_KILL is not set
+# CONFIG_NSH_DISABLE_LS is not set
+# CONFIG_NSH_DISABLE_MKDIR is not set
+# CONFIG_NSH_DISABLE_MOUNT is not set
+# CONFIG_NSH_DISABLE_PS is not set
+# CONFIG_NSH_DISABLE_PSSTACKUSAGE is not set
+# CONFIG_NSH_DISABLE_PWD is not set
+# CONFIG_NSH_DISABLE_REBOOT is not set
+# CONFIG_NSH_DISABLE_RM is not set
+# CONFIG_NSH_DISABLE_RMDIR is not set
+# CONFIG_NSH_DISABLE_SET is not set
+# CONFIG_NSH_DISABLE_SLEEP is not set
+# CONFIG_NSH_DISABLE_SOURCE is not set
+# CONFIG_NSH_DISABLE_TELNETD is not set
+# CONFIG_NSH_DISABLE_TEST is not set
+# CONFIG_NSH_DISABLE_TIME is not set
+# CONFIG_NSH_DISABLE_UMOUNT is not set
+# CONFIG_NSH_DISABLE_UNAME is not set
+# CONFIG_NSH_DISABLE_UNSET is not set
+# CONFIG_NSH_DISABLE_USLEEP is not set
+# CONFIG_NSH_DISABLE_XD is not set
+CONFIG_ARCH="arm"
+CONFIG_ARCH_BOARD="phy6222"
+CONFIG_ARCH_BOARD_PHY6222=y
+CONFIG_ARCH_CHIP="phy62xx"
+CONFIG_ARCH_CHIP_PHY6222=y
+CONFIG_ARCH_CHIP_PHY62XX=y
+CONFIG_ARCH_STACKDUMP=y
+CONFIG_BOARDCTL=y
+CONFIG_BOARDCTL_RESET=y
+CONFIG_BOARD_LATE_INITIALIZE=y
+CONFIG_BUILTIN=y
+CONFIG_CLOCK_MONOTONIC=y
+CONFIG_DEBUG_ASSERTIONS=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_FS=y
+CONFIG_DEBUG_FULLOPT=y
+CONFIG_DEBUG_HARDFAULT_ALERT=y
+CONFIG_DEBUG_LIB=y
+CONFIG_DEBUG_MM=y
+CONFIG_DEBUG_SCHED=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_TIMER=y
+CONFIG_DEBUG_WATCHDOG=y
+CONFIG_DEFAULT_SMALL=y
+CONFIG_DEV_GPIO=y
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_TIMER=y
+CONFIG_EXAMPLES_WATCHDOG=y
+CONFIG_FS_AUTOMOUNTER=y
+CONFIG_FS_LITTLEFS=y
+CONFIG_FS_LITTLEFS_BLOCK_FACTOR=1
+CONFIG_FS_PROCFS=y
+CONFIG_FS_TEST=y
+CONFIG_FS_TEST_API=y
+CONFIG_FS_TEST_PERFORMANCE=y
+CONFIG_IDLETHREAD_STACKSIZE=2048
+CONFIG_INIT_ENTRYNAME="init"
+CONFIG_INIT_ENTRYPOINT="nsh_main"
+CONFIG_INIT_STACKSIZE=2560
+CONFIG_INTELHEX_BINARY=y
+CONFIG_IOEXPANDER=y
+CONFIG_IOEXPANDER_MULTIPIN=y
+CONFIG_LIBC_LOCALTIME=y
+CONFIG_MM_CIRCBUF=y
+CONFIG_MM_SMALL=y
+CONFIG_MM_TEST=y
+CONFIG_MTD=y
+CONFIG_NFILE_DESCRIPTORS_PER_BLOCK=6
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FILEIOSIZE=64
+CONFIG_NUNGET_CHARS=0
+CONFIG_PIPES=y
+CONFIG_PREALLOC_TIMERS=0
+CONFIG_PSEUDOFS_ATTRIBUTES=y
+CONFIG_PSEUDOFS_SOFTLINKS=y
+CONFIG_PTHREAD_CLEANUP=y
+CONFIG_PTHREAD_CLEANUP_STACKSIZE=2
+CONFIG_PTHREAD_MUTEX_TYPES=y
+CONFIG_PTHREAD_SPINLOCKS=y
+CONFIG_PTHREAD_STACK_DEFAULT=3072
+CONFIG_RAM_SIZE=58368
+CONFIG_RAM_START=0x1fff1c00
Review comment:
the CONFIG_RAM_START and CONFIG_RAM_SIZE should be equal to the value defined in flash.ld.
In flash.ld, the CONFIG_RAM_START = 0x1fff1880 and CONFIG_RAM_SIZE = 59264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] LingaoM commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
LingaoM commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803340899
##########
File path: arch/arm/src/phy62xx/pplus_mtd_flash.c
##########
@@ -144,7 +147,10 @@ static int pplus_fls_erase_chip(struct pplus_fls_dev_s *priv)
for (i = 0; i < priv->nsectors; i++)
{
+ _HAL_CS_ALLOC_();
+ HAL_ENTER_CRITICAL_SECTION();
hal_flash_erase_sector(address);
+ HAL_EXIT_CRITICAL_SECTION();
Review comment:
@xiaoxiang781216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] CV-Bowen commented on a change in pull request #5453: Phyplus rel 1.5
Posted by GitBox <gi...@apache.org>.
CV-Bowen commented on a change in pull request #5453:
URL: https://github.com/apache/incubator-nuttx/pull/5453#discussion_r803359077
##########
File path: boards/arm/phy62xx/phy6222/configs/newostest/defconfig.bak
##########
@@ -0,0 +1,147 @@
+#
Review comment:
do not need the defconfig.bak
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org