[GitHub] [bookkeeper] hangc0276 opened a new pull request, #3903: Fix keys leak in EntryLocationIndex when ledgersToDelete is empty

["hangc0276 (via GitHub)" <gi...@apache.org>]

hangc0276 opened a new pull request, #3903:
URL: https://github.com/apache/bookkeeper/pull/3903

   ### Motivation
   In EntryLocationIndex#removeOffsetFromDeletedLedgers, if there are no ledgers to delete, the key pair will leak.
   
   ### Changes
   Check the ledgers to deletion Set first, and if the set is not empty, then generate the keys.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] hangc0276 merged pull request #3903: Fix keys leak in EntryLocationIndex when ledgersToDelete is empty

["hangc0276 (via GitHub)" <gi...@apache.org>]

hangc0276 merged PR #3903:
URL: https://github.com/apache/bookkeeper/pull/3903


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [bookkeeper] AnonHxy commented on pull request #3903: Fix keys leak in EntryLocationIndex when ledgersToDelete is empty

["AnonHxy (via GitHub)" <gi...@apache.org>]

AnonHxy commented on PR #3903:
URL: https://github.com/apache/bookkeeper/pull/3903#issuecomment-1495374378

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org