You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/03/21 11:54:04 UTC
[GitHub] [hadoop] esahekmat opened a new pull request #1904: HADOOP-16931:
reduce the execution time of the TestRolloverSignerSecretProvider
esahekmat opened a new pull request #1904: HADOOP-16931: reduce the execution time of the TestRolloverSignerSecretProvider
URL: https://github.com/apache/hadoop/pull/1904
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] goiri commented on a change in pull request #1904:
HADOOP-16931. reduce the execution time of the
TestRolloverSignerSecretProvider
Posted by GitBox <gi...@apache.org>.
goiri commented on a change in pull request #1904: HADOOP-16931. reduce the execution time of the TestRolloverSignerSecretProvider
URL: https://github.com/apache/hadoop/pull/1904#discussion_r396001301
##########
File path: hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/util/TestRolloverSignerSecretProvider.java
##########
@@ -52,7 +52,6 @@ public void testGetAndRollSecrets() throws Exception {
Assert.assertEquals(2, allSecrets.length);
Assert.assertArrayEquals(secret3, allSecrets[0]);
Assert.assertArrayEquals(secret2, allSecrets[1]);
- Thread.sleep(rolloverFrequency + 2000);
Review comment:
As we are trying to improve this, let's do this test a little more controlled and use wairFor, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] esahekmat commented on a change in pull request #1904:
HADOOP-16931. Reduce the execution time of the
TestRolloverSignerSecretProvider
Posted by GitBox <gi...@apache.org>.
esahekmat commented on a change in pull request #1904: HADOOP-16931. Reduce the execution time of the TestRolloverSignerSecretProvider
URL: https://github.com/apache/hadoop/pull/1904#discussion_r396013880
##########
File path: hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/util/TestRolloverSignerSecretProvider.java
##########
@@ -52,7 +52,6 @@ public void testGetAndRollSecrets() throws Exception {
Assert.assertEquals(2, allSecrets.length);
Assert.assertArrayEquals(secret3, allSecrets[0]);
Assert.assertArrayEquals(secret2, allSecrets[1]);
- Thread.sleep(rolloverFrequency + 2000);
Review comment:
I made a change to use a monitor object on the TRolloverSignerSecretProvider object, is this what are you looking for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] esahekmat commented on a change in pull request #1904:
HADOOP-16931. Reduce the execution time of the
TestRolloverSignerSecretProvider
Posted by GitBox <gi...@apache.org>.
esahekmat commented on a change in pull request #1904: HADOOP-16931. Reduce the execution time of the TestRolloverSignerSecretProvider
URL: https://github.com/apache/hadoop/pull/1904#discussion_r396005668
##########
File path: hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/util/TestRolloverSignerSecretProvider.java
##########
@@ -52,7 +52,6 @@ public void testGetAndRollSecrets() throws Exception {
Assert.assertEquals(2, allSecrets.length);
Assert.assertArrayEquals(secret3, allSecrets[0]);
Assert.assertArrayEquals(secret2, allSecrets[1]);
- Thread.sleep(rolloverFrequency + 2000);
Review comment:
would you please explain more?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] esahekmat commented on a change in pull request #1904:
HADOOP-16931. Reduce the execution time of the
TestRolloverSignerSecretProvider
Posted by GitBox <gi...@apache.org>.
esahekmat commented on a change in pull request #1904: HADOOP-16931. Reduce the execution time of the TestRolloverSignerSecretProvider
URL: https://github.com/apache/hadoop/pull/1904#discussion_r396005668
##########
File path: hadoop-common-project/hadoop-auth/src/test/java/org/apache/hadoop/security/authentication/util/TestRolloverSignerSecretProvider.java
##########
@@ -52,7 +52,6 @@ public void testGetAndRollSecrets() throws Exception {
Assert.assertEquals(2, allSecrets.length);
Assert.assertArrayEquals(secret3, allSecrets[0]);
Assert.assertArrayEquals(secret2, allSecrets[1]);
- Thread.sleep(rolloverFrequency + 2000);
Review comment:
would you please explain more?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org