[GitHub] [doris] morningman commented on a diff in pull request #10602: [feature-wip](multi-catalog)(fix) federation query failed

[GitBox <gi...@apache.org>]

morningman commented on code in PR #10602:
URL: https://github.com/apache/doris/pull/10602#discussion_r913326561


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/Analyzer.java:
##########
@@ -680,7 +680,7 @@ public TableRef resolveTableRef(TableRef tableRef) throws AnalysisException {
         // which may not be the same as the user's reference to the table name, causing the table name not to be found
         // in registerColumnRef(). So here the tblName is constructed using tableName.getTbl()
         // instead of table.getName().
-        TableName tblName = new TableName(tableName.getDb(), tableName.getTbl());
+        TableName tblName = new TableName(tableName.getCtl(), tableName.getDb(), tableName.getTbl());

Review Comment:
   I think we should disable the constructor of `TableName` with 2 params.
   That is very error-prone



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org