You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "aleksraiden (via GitHub)" <gi...@apache.org> on 2023/03/22 09:43:18 UTC

[GitHub] [incubator-kvrocks] aleksraiden opened a new issue, #1344: Add BACKUP new command with options

aleksraiden opened a new issue, #1344:
URL: https://github.com/apache/incubator-kvrocks/issues/1344

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   At now we have only BGSAVE command (for compatibility with original Redis semantic), and need a separate SET config options for backup_path. And, as I see, not supporting sync/async mode of backup.
   
   ### Solution
   
   Command BGSAVE hasn't clear semantic, so I propose a new command: BACKUP <backup_path> SYNC|ASYNC
   
   - <backup_path> are optional path to store current backup (e.g. /tmp/backup etc.) If backup are exists, it will be destroy before perform a new.
   - SYNC|ASYNC is an option flag (default are ASYNC) for creating backup using sync/async method (see [BackupableDBOptions::sync](https://rocksdb.org/blog/2014/03/27/how-to-backup-rocksdb.html)
   
   ### Are you willing to submit a PR?
   
   - [ ] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1344: Add BACKUP new command with options

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1344:
URL: https://github.com/apache/incubator-kvrocks/issues/1344#issuecomment-1482283598

   Hi @aleksraiden 
   
   I think it's a good proposal, I even think if possible to backup and restore from the remote storage directly. https://github.com/orgs/apache/projects/199?pane=issue&itemId=23218575


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] aleksraiden commented on issue #1344: Add BACKUP new command with options

Posted by "aleksraiden (via GitHub)" <gi...@apache.org>.
aleksraiden commented on issue #1344:
URL: https://github.com/apache/incubator-kvrocks/issues/1344#issuecomment-1480332752

   A some internal discussion are here - https://github.com/apache/incubator-kvrocks/discussions/483


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org