You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/04/04 13:24:41 UTC
[GitHub] [kylin] nichunen commented on a change in pull request #568:
KYLIN-3841 Build Global Dict by Hive
nichunen commented on a change in pull request #568: KYLIN-3841 Build Global Dict by Hive
URL: https://github.com/apache/kylin/pull/568#discussion_r272066234
##########
File path: core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##########
@@ -1339,11 +1340,38 @@ public int getYarnStatusCheckIntervalSeconds() {
return Integer.parseInt(getOptional("kylin.engine.mr.yarn-check-interval-seconds", "10"));
}
-
public boolean isUseLocalClasspathEnabled() {
return Boolean.parseBoolean(getOptional("kylin.engine.mr.use-local-classpath", TRUE));
}
+ // ============================================================================
+ // mr-hive dict
+ // ============================================================================
+
+ public String[] getMrHiveDictColumns() {
+ String columnStr = getOptional("kylin.dictionary.mr-hive.columns", "");
Review comment:
Should be defined besides properties start with "kylin.dictionary"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services