You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by ce...@apache.org on 2021/11/07 15:00:04 UTC
svn commit: r1894814 - in /poi/trunk:
poi-ooxml/src/main/java/org/apache/poi/xssf/binary/
poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/
poi-scratchpad/src/test/java/org/apache/poi/hemf/usermodel/
poi/src/main/java/org/apache/poi/hssf/record/ p...
Author: centic
Date: Sun Nov 7 15:00:03 2021
New Revision: 1894814
URL: http://svn.apache.org/viewvc?rev=1894814&view=rev
Log:
Use append(char) instead of string where possible
Modified:
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/binary/XSSFBHeaderFooter.java
poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFConditionalFormatting.java
poi/trunk/poi-scratchpad/src/test/java/org/apache/poi/hemf/usermodel/TestHemfPicture.java
poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/SupBookRecord.java
poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java
poi/trunk/poi/src/main/java/org/apache/poi/poifs/eventfilesystem/POIFSReader.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/format/CellFormatPart.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/CellEvaluationFrame.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/NameIdentifier.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/SheetIdentifier.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/SheetRangeIdentifier.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Averageifs.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/usermodel/FractionFormat.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/util/CellRangeAddress.java
poi/trunk/poi/src/main/java/org/apache/poi/ss/util/NormalisedDecimal.java
poi/trunk/poi/src/test/java/org/apache/poi/hpsf/basic/TestMetaDataIPI.java
Modified: poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/binary/XSSFBHeaderFooter.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/binary/XSSFBHeaderFooter.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/binary/XSSFBHeaderFooter.java (original)
+++ poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/binary/XSSFBHeaderFooter.java Sun Nov 7 15:00:03 2021
@@ -56,13 +56,13 @@ class XSSFBHeaderFooter {
}
if (center != null && center.length() > 0) {
if (sb.length() > 0) {
- sb.append(" ");
+ sb.append(' ');
}
sb.append(center);
}
if (right != null && right.length() > 0) {
if (sb.length() > 0) {
- sb.append(" ");
+ sb.append(' ');
}
sb.append(right);
}
Modified: poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFConditionalFormatting.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFConditionalFormatting.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFConditionalFormatting.java (original)
+++ poi/trunk/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFConditionalFormatting.java Sun Nov 7 15:00:03 2021
@@ -70,7 +70,7 @@ public class XSSFConditionalFormatting i
boolean first = true;
for (CellRangeAddress range : ranges) {
if (!first) {
- sb.append(" ");
+ sb.append(' ');
} else {
first = false;
}
Modified: poi/trunk/poi-scratchpad/src/test/java/org/apache/poi/hemf/usermodel/TestHemfPicture.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi-scratchpad/src/test/java/org/apache/poi/hemf/usermodel/TestHemfPicture.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi-scratchpad/src/test/java/org/apache/poi/hemf/usermodel/TestHemfPicture.java (original)
+++ poi/trunk/poi-scratchpad/src/test/java/org/apache/poi/hemf/usermodel/TestHemfPicture.java Sun Nov 7 15:00:03 2021
@@ -129,7 +129,7 @@ public class TestHemfPicture {
lastX = -1;
}
if (lastX > -1 && reference.getX() - lastX > fudgeFactorX) {
- sb.append(" ");
+ sb.append(' ');
}
sb.append(extTextOutW.getText());
lastY = reference.getY();
@@ -192,7 +192,7 @@ public class TestHemfPicture {
lastX = -1;
}
if (lastX > -1 && reference.getX() - lastX > fudgeFactorX) {
- sb.append(" ");
+ sb.append(' ');
}
String txt = extTextOutW.getText();
if (expectedParts.contains(txt)) {
Modified: poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/SupBookRecord.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/SupBookRecord.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/SupBookRecord.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/hssf/record/SupBookRecord.java Sun Nov 7 15:00:03 2021
@@ -228,7 +228,7 @@ public final class SupBookRecord extends
case CH_ALT_STARTUP_DIR:
case CH_LIB_DIR:
LOG.atWarn().log("EXCEL.EXE path unknown - using this directory instead: .");
- sb.append(".").append(PATH_SEPERATOR);
+ sb.append('.').append(PATH_SEPERATOR);
break;
default:
sb.append(c);
Modified: poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/hssf/usermodel/HSSFWorkbook.java Sun Nov 7 15:00:03 2021
@@ -1653,10 +1653,10 @@ public final class HSSFWorkbook extends
StringBuilder sb = new StringBuilder(32);
for (int i = 0; i < parts.length; i++) {
if (i > 0) {
- sb.append(",");
+ sb.append(',');
}
SheetNameFormatter.appendFormat(sb, getSheetName(sheetIndex));
- sb.append("!");
+ sb.append('!');
sb.append(parts[i]);
}
name.setNameDefinition(HSSFFormulaParser.parse(sb.toString(), this, FormulaType.NAMEDRANGE, sheetIndex));
Modified: poi/trunk/poi/src/main/java/org/apache/poi/poifs/eventfilesystem/POIFSReader.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/poifs/eventfilesystem/POIFSReader.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/poifs/eventfilesystem/POIFSReader.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/poifs/eventfilesystem/POIFSReader.java Sun Nov 7 15:00:03 2021
@@ -203,10 +203,10 @@ public class POIFSReader
sb.setLength(0);
int pathLength = path.length();
for (int k = 0; k < pathLength; k++) {
- sb.append("/").append(path.getComponent(k));
+ sb.append('/').append(path.getComponent(k));
}
byte[] data = IOUtils.toByteArray(istream);
- sb.append("/").append(event.getName()).append(": ").append(data.length).append(" bytes read");
+ sb.append('/').append(event.getName()).append(": ").append(data.length).append(" bytes read");
System.out.println(sb);
} catch (IOException ignored) {
}
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/format/CellFormatPart.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/format/CellFormatPart.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/format/CellFormatPart.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/format/CellFormatPart.java Sun Nov 7 15:00:03 2021
@@ -415,10 +415,10 @@ public class CellFormatPart {
boolean special = type.isSpecial(ch.charAt(0));
if (special)
- sb.append("'");
+ sb.append('\'');
sb.append(ch);
if (special)
- sb.append("'");
+ sb.append('\'');
}
return sb.toString();
}
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/CellEvaluationFrame.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/CellEvaluationFrame.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/CellEvaluationFrame.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/CellEvaluationFrame.java Sun Nov 7 15:00:03 2021
@@ -42,7 +42,7 @@ final class CellEvaluationFrame {
public String toString() {
StringBuilder sb = new StringBuilder(64);
sb.append(getClass().getName()).append(" [");
- sb.append("]");
+ sb.append(']');
return sb.toString();
}
/**
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/CollaboratingWorkbooksEnvironment.java Sun Nov 7 15:00:03 2021
@@ -187,9 +187,9 @@ public final class CollaboratingWorkbook
if (count++>0) {
sb.append(", ");
}
- sb.append("'").append(i.next()).append("'");
+ sb.append('\'').append(i.next()).append("'");
}
- sb.append(")");
+ sb.append(')');
}
throw new WorkbookNotFoundException(sb.toString());
}
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/NameIdentifier.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/NameIdentifier.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/NameIdentifier.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/NameIdentifier.java Sun Nov 7 15:00:03 2021
@@ -36,11 +36,11 @@ public class NameIdentifier {
sb.append(getClass().getName());
sb.append(" [");
if (_isQuoted) {
- sb.append("'").append(_name).append("'");
+ sb.append('\'').append(_name).append("'");
} else {
sb.append(_name);
}
- sb.append("]");
+ sb.append(']');
return sb.toString();
}
}
\ No newline at end of file
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/SheetIdentifier.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/SheetIdentifier.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/SheetIdentifier.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/SheetIdentifier.java Sun Nov 7 15:00:03 2021
@@ -36,7 +36,7 @@ public class SheetIdentifier {
sb.append(" [").append(_sheetIdentifier.getName()).append("]");
}
if (_sheetIdentifier.isQuoted()) {
- sb.append("'").append(_sheetIdentifier.getName()).append("'");
+ sb.append('\'').append(_sheetIdentifier.getName()).append("'");
} else {
sb.append(_sheetIdentifier.getName());
}
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/SheetRangeIdentifier.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/SheetRangeIdentifier.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/SheetRangeIdentifier.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/SheetRangeIdentifier.java Sun Nov 7 15:00:03 2021
@@ -34,7 +34,7 @@ public class SheetRangeIdentifier extend
super.asFormulaString(sb);
sb.append(':');
if (_lastSheetIdentifier.isQuoted()) {
- sb.append("'").append(_lastSheetIdentifier.getName()).append("'");
+ sb.append('\'').append(_lastSheetIdentifier.getName()).append("'");
} else {
sb.append(_lastSheetIdentifier.getName());
}
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Averageifs.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Averageifs.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Averageifs.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/functions/Averageifs.java Sun Nov 7 15:00:03 2021
@@ -67,7 +67,7 @@ public final class Averageifs extends Ba
public void addValue(ValueEval value) {
if(!(value instanceof NumberEval)) return;
- double d = ((NumberEval) value).getNumberValue();;
+ double d = ((NumberEval) value).getNumberValue();
sum += d;
count++;
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/usermodel/FractionFormat.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/usermodel/FractionFormat.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/usermodel/FractionFormat.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/usermodel/FractionFormat.java Sun Nov 7 15:00:03 2021
@@ -132,7 +132,7 @@ public class FractionFormat extends Form
StringBuilder sb = new StringBuilder();
if (isNeg){
- sb.append("-");
+ sb.append('-');
}
sb.append(wholePart);
return sb.toString();
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/util/CellRangeAddress.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/util/CellRangeAddress.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/util/CellRangeAddress.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/util/CellRangeAddress.java Sun Nov 7 15:00:03 2021
@@ -93,7 +93,7 @@ public class CellRangeAddress extends Ce
StringBuilder sb = new StringBuilder();
if (sheetName != null) {
sb.append(SheetNameFormatter.format(sheetName));
- sb.append("!");
+ sb.append('!');
}
CellReference cellRefFrom = new CellReference(getFirstRow(), getFirstColumn(),
useAbsoluteAddress, useAbsoluteAddress);
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/util/NormalisedDecimal.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/util/NormalisedDecimal.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/util/NormalisedDecimal.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/util/NormalisedDecimal.java Sun Nov 7 15:00:03 2021
@@ -247,9 +247,9 @@ final class NormalisedDecimal {
sb.append(ws.substring(1));
sb.append(' ');
sb.append(getFractionalDigits());
- sb.append("E");
+ sb.append('E');
sb.append(getDecimalExponent());
- sb.append("]");
+ sb.append(']');
return sb.toString();
}
}
Modified: poi/trunk/poi/src/test/java/org/apache/poi/hpsf/basic/TestMetaDataIPI.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/hpsf/basic/TestMetaDataIPI.java?rev=1894814&r1=1894813&r2=1894814&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/hpsf/basic/TestMetaDataIPI.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/hpsf/basic/TestMetaDataIPI.java Sun Nov 7 15:00:03 2021
@@ -551,7 +551,7 @@ final class TestMetaDataIPI {
StringBuilder sb = new StringBuilder();
for (int i = 0; i < 10000; i++) {
sb.append(s);
- sb.append(" ");
+ sb.append(' ');
}
return sb.toString();
}
@@ -586,14 +586,14 @@ final class TestMetaDataIPI {
Random rand = new Random(0); // TODO - no Random - tests should be completely deterministic
for (int i = 0; i < 5; i++) {
sb.append(s);
- sb.append(" ");
+ sb.append(' ');
char j = (char) rand.nextInt(220);
j += 33;
- sb.append(">");
+ sb.append('>');
sb.append(Character.valueOf(j));
- sb.append("=");
+ sb.append('=');
sb.append(umlaute[rand.nextInt(umlaute.length)]);
- sb.append("<");
+ sb.append('<');
}
return sb;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org