You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/08 03:29:04 UTC
[GitHub] [incubator-dolphinscheduler] elonlo opened a new pull request
#1765: fixbug: login interface cannot jump to home interface
elonlo opened a new pull request #1765: fixbug: login interface cannot jump to home interface
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1765
## What is the purpose of the pull request
*fix: login interface cannot jump to home interface*
## Brief change log
- *Add SessionId comparison logic in ui module*
## Verify this pull request
- *Manually verified the change by testing locally.*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #1765:
fixbug: login interface cannot jump to home interface
Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #1765: fixbug: login interface cannot jump to home interface
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1765#issuecomment-571877039
@break60 please review
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1765:
fixbug: login interface cannot jump to home interface
Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1765: fixbug: login interface cannot jump to home interface
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1765
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] break60 commented on issue #1765:
fixbug: login interface cannot jump to home interface
Posted by GitBox <gi...@apache.org>.
break60 commented on issue #1765: fixbug: login interface cannot jump to home interface
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1765#issuecomment-571875817
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io edited a comment on issue
#1765: fixbug: login interface cannot jump to home interface
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #1765: fixbug: login interface cannot jump to home interface
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1765#issuecomment-571876482
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=h1) Report
> Merging [#1765](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/995b5ca4a16097d6ce82ad1d8255534fdac2264b?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1765 +/- ##
=======================================
Coverage 20.22% 20.22%
=======================================
Files 290 290
Lines 14082 14082
Branches 2376 2376
=======================================
Hits 2848 2848
Misses 10908 10908
Partials 326 326
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=footer). Last update [995b5ca...a4fc57e](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1765:
fixbug: login interface cannot jump to home interface
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1765: fixbug: login interface cannot jump to home interface
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1765#issuecomment-571876482
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=h1) Report
> Merging [#1765](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/995b5ca4a16097d6ce82ad1d8255534fdac2264b?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1765 +/- ##
==========================================
- Coverage 20.22% 20.21% -0.01%
==========================================
Files 290 290
Lines 14082 14082
Branches 2376 2376
==========================================
- Hits 2848 2847 -1
- Misses 10908 10910 +2
+ Partials 326 325 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (-14.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=footer). Last update [995b5ca...a4fc57e](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1765?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] sonarcloud[bot] commented on issue
#1765: fixbug: login interface cannot jump to home interface
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on issue #1765: fixbug: login interface cannot jump to home interface
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1765#issuecomment-571877932
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1765&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1765&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1765&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1765&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1765&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1765&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1765&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1765&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1765&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1765&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=1765&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1765&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1765&metric=new_coverage&view=list)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1765&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=1765&metric=new_duplicated_lines_density&view=list)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services