[GitHub] spark pull request #16365: [SPARK-18950][SQL] Report conflicting fields when...

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16365#discussion_r130261747
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ---
    @@ -469,9 +469,16 @@ object StructType extends AbstractDataType {
               case leftField @ StructField(leftName, leftType, leftNullable, _) =>
                 rightMapped.get(leftName)
                   .map { case rightField @ StructField(_, rightType, rightNullable, _) =>
    -                leftField.copy(
    -                  dataType = merge(leftType, rightType),
    -                  nullable = leftNullable || rightNullable)
    +                Try {
    --- End diff --
    
    Could we use the JAVA style `try` and `catch`? See the https://github.com/databricks/scala-style-guide#exception-handling-try-vs-try
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org