You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/02 14:06:23 UTC

[GitHub] [dolphinscheduler] Radeity commented on pull request #12930: [Bug][Worker] Fix duplicated key bug when have out parameters of same name

Radeity commented on PR #12930:
URL: https://github.com/apache/dolphinscheduler/pull/12930#issuecomment-1335278193

   > I can see your point here. But I'm wondering why u choose to remove the previous var instead of preventing users from defining multiple vars of the same `prop`?
   > 
   > https://github.com/apache/dolphinscheduler/blob/ffc9fb280aa4609efc219550899a599ece2a5ada/dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/api/parameters/AbstractParameters.java#L202-L205
   
   
   Hi, @EricGao888, this change provides two ways to update upstream parameters:
   - Use `setValue` in script without additional output parameter definition.  **(Original way, with higher priority)**
   - Define the output parameter with same name, directly set value in the definition. **(New way,  bug will be fixed in this pr)**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org