You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/04/14 07:01:44 UTC

[GitHub] [rocketmq] BurningCN opened a new issue #2806: remove redundant separator

BurningCN opened a new issue #2806:
URL: https://github.com/apache/rocketmq/issues/2806


   In the test program `MappedFileQueueTest`, the `storePath` last slash is redundant when passing `storePath` to the `MappedFileQueue` constructor, because after defining the MappedFileQueue object, and then call `mappedFileQueue.getLastMappedFile(0)` method, this method inside will be joining the `File.separator`(slash)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] RongtongJin closed issue #2806: remove redundant separator

Posted by GitBox <gi...@apache.org>.
RongtongJin closed issue #2806:
URL: https://github.com/apache/rocketmq/issues/2806


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [rocketmq] RongtongJin commented on issue #2806: remove redundant separator

Posted by GitBox <gi...@apache.org>.
RongtongJin commented on issue #2806:
URL: https://github.com/apache/rocketmq/issues/2806#issuecomment-822970315


   IMO, this pull request is not very helpful to the project, so I will close it first. Plz feel free to reopen it if you have another question.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org