You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Masahiro Tanaka <ta...@oss.nttdata.com> on 2017/04/06 08:11:21 UTC
Re: Review Request 57687: AMBARI-20443 No need to show
`hive_ambari_database`
> On 3\u6708 17, 2017, 5:21 a.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml
> > Line 97 (original), 97 (patched)
> > <https://reviews.apache.org/r/57687/diff/1/?file=1666075#file1666075line97>
> >
> > Does this config need to be deleted from existing clusters? Which stack versions does this affect?
> >
> > If so, you can mark the property as <deleted>, which will also cause Ambari to delete it during EU/RU
>
> Masahiro Tanaka wrote:
> Sorry for late reply, and thank you for your reviewing.
> I'll check if existing clusters do not need this property.
I checked the Ambari source code, and found out that ambari 1.2.3 used `hive_ambari_database` in puppet manifest.
But it was disappered from ambari 1.2.4 (maybe in [AMBARI-2144](https://issues.apache.org/jira/browse/AMBARI-2144))
- Masahiro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57687/#review169205
-----------------------------------------------------------
On 3\u6708 16, 2017, 9:55 p.m., Masahiro Tanaka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57687/
> -----------------------------------------------------------
>
> (Updated 3\u6708 16, 2017, 9:55 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Yusaku Sako.
>
>
> Bugs: AMBARI-20443
> https://issues.apache.org/jira/browse/AMBARI-20443
>
>
> Repository: ambari
>
>
> Description
> -------
>
> In Advanced hive-env, there is a parameter named hive_ambari_database. Though I change the parameter, it looks like nothing has changed. I greped the entire ambari source code, the parameter is not referenced.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml be79331
>
>
> Diff: https://reviews.apache.org/r/57687/diff/1/
>
>
> Testing
> -------
>
> -1 overall. Here are the results of testing the latest attachment
> http://issues.apache.org/jira/secure/attachment/12858664/AMBARI-20443.0.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac compiler warnings.
> +1 release audit. The applied patch does not increase the total number of release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: https://builds.apache.org/job/Ambari-trunk-test-patch/11023//testReport/
> Console output: https://builds.apache.org/job/Ambari-trunk-test-patch/11023//console
> This message is automatically generated.
>
>
> Thanks,
>
> Masahiro Tanaka
>
>